)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"abb9db2b02f23c830178ad0abae28fae54fcdc9a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Minor `update_on_match` improvement:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If state was changed in another transaction the retrying of update"},{"line_number":10,"context_line":"statements doesn\u0027t make sense"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibcaf088f5cbfa317a3364d51762027dda09368f7"},{"line_number":13,"context_line":"Signed-off-by: Vitalii Solodilov \u003cmcdkr@yandex.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_857d85b3","line":10,"updated":"2018-04-23 08:31:53.000000000","message":"Please try and get into the habit of opening bugs and providing more information. I had to dig around in the oslo.db docs to understand this change.\n\nIt seems the default is 3 attempts.\n\nhttps://docs.openstack.org/oslo.db/ocata/api/oslo_db.sqlalchemy.update_match.html#oslo_db.sqlalchemy.update_match.update_on_match","commit_id":"beabba1089651b518d0e0b44cf5c9e8a4f531945"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"274088efbfd53469b909f4360f328a63fa5c94ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Minor `update_on_match` improvement:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If state was changed in another transaction the retrying of update"},{"line_number":10,"context_line":"statements doesn\u0027t make sense"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibcaf088f5cbfa317a3364d51762027dda09368f7"},{"line_number":13,"context_line":"Signed-off-by: Vitalii Solodilov \u003cmcdkr@yandex.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_9e8b861d","line":10,"in_reply_to":"9f6a8fd7_857d85b3","updated":"2018-04-23 16:26:45.000000000","message":"Sorry. I don\u0027t want to open a bug because it\u0027s not a bug :) I just noticed extra sql queries.\nCommit message was updated.","commit_id":"beabba1089651b518d0e0b44cf5c9e8a4f531945"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"b910fbd070d24531b2bc1fe409ff7c16ac4b7439","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Minor `update_on_match` improvement:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If state was changed in another transaction the retrying of update"},{"line_number":10,"context_line":"statements doesn\u0027t make sense"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibcaf088f5cbfa317a3364d51762027dda09368f7"},{"line_number":13,"context_line":"Signed-off-by: Vitalii Solodilov \u003cmcdkr@yandex.ru\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_cae4aa3e","line":10,"in_reply_to":"9f6a8fd7_9e8b861d","updated":"2018-04-25 13:44:35.000000000","message":"I would argue that if something \"doesn\u0027t make sense\" - then it is a bug.","commit_id":"beabba1089651b518d0e0b44cf5c9e8a4f531945"}],"mistral/db/v2/sqlalchemy/api.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"10c0a00574be7c0622bfa168d1badabfe06ae984","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            specimen\u003dspecimen,"},{"line_number":177,"context_line":"            surrogate_key\u003d\u0027id\u0027,"},{"line_number":178,"context_line":"            values\u003dvalues,"},{"line_number":179,"context_line":"            attempts\u003d1"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"    except oslo_sqlalchemy.update_match.NoRowsMatched:"},{"line_number":182,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_0559758c","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":20},"updated":"2018-04-23 08:25:11.000000000","message":"Right change but at the wrong place. Pay attention that this is a generic utility method that has no idea about a particular case in which it will be used (updating wf executions etc.) You need to add another argument to this method and pass it properly where needed.","commit_id":"beabba1089651b518d0e0b44cf5c9e8a4f531945"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"274088efbfd53469b909f4360f328a63fa5c94ea","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            specimen\u003dspecimen,"},{"line_number":177,"context_line":"            surrogate_key\u003d\u0027id\u0027,"},{"line_number":178,"context_line":"            values\u003dvalues,"},{"line_number":179,"context_line":"            attempts\u003d1"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"    except oslo_sqlalchemy.update_match.NoRowsMatched:"},{"line_number":182,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_9e2f063e","line":179,"range":{"start_line":179,"start_character":12,"end_line":179,"end_character":20},"in_reply_to":"9f6a8fd7_0559758c","updated":"2018-04-23 16:26:45.000000000","message":"Done.","commit_id":"beabba1089651b518d0e0b44cf5c9e8a4f531945"}]}
