)]}'
{"mistral/api/controllers/v2/execution.py":[{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"e57f0b80e6673e598e2e70acaeae80328b6c2bef","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # ensure that workflow execution exists"},{"line_number":121,"context_line":"                db_api.get_workflow_execution("},{"line_number":122,"context_line":"                    id,"},{"line_number":123,"context_line":"                    fields\u003d(db_models.WorkflowExecution.id,)"},{"line_number":124,"context_line":"                )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                delta \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_573e10b8","line":123,"range":{"start_line":123,"start_character":20,"end_line":123,"end_character":60},"updated":"2018-05-15 14:32:56.000000000","message":"Do we need to pass in the id from the database, as wouldn\u0027t it be duplicate information?","commit_id":"6359053677f1d08406552c254e852329de82bb98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"bc920670d3ba17deb9083f0ef8fa6c6d370b25bb","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # ensure that workflow execution exists"},{"line_number":121,"context_line":"                db_api.get_workflow_execution("},{"line_number":122,"context_line":"                    id,"},{"line_number":123,"context_line":"                    fields\u003d(db_models.WorkflowExecution.id,)"},{"line_number":124,"context_line":"                )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                delta \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a6ac109f","line":123,"range":{"start_line":123,"start_character":20,"end_line":123,"end_character":60},"in_reply_to":"5f7c97a3_573e10b8","updated":"2018-05-15 18:05:36.000000000","message":"The point here is that we need to pass the name of any field here, just not to load the entire object. The obvious choice is id.","commit_id":"6359053677f1d08406552c254e852329de82bb98"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"f1e766701b560abdb04a9a5352816f632ff3a8ae","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # ensure that workflow execution exists"},{"line_number":121,"context_line":"                db_api.get_workflow_execution("},{"line_number":122,"context_line":"                    id,"},{"line_number":123,"context_line":"                    fields\u003d(db_models.WorkflowExecution.id,)"},{"line_number":124,"context_line":"                )"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"                delta \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_13a09a8f","line":123,"range":{"start_line":123,"start_character":20,"end_line":123,"end_character":60},"in_reply_to":"5f7c97a3_a6ac109f","updated":"2018-05-16 09:18:27.000000000","message":"Yeah, this doesn\u0027t pass the ID, but rather a reference to the ID column. So we are essentially passing the ID value and the ID column.","commit_id":"6359053677f1d08406552c254e852329de82bb98"}],"mistral/db/v2/api.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"58479e930a9b1372f06f171a8e7c3c82bf168589","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Workflow executions."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# TODO(rakhmerov): Add \u0027fields\u0027 parameter to all \u0027get\u0027 methods."},{"line_number":246,"context_line":"def get_workflow_execution(id, fields\u003d()):"},{"line_number":247,"context_line":"    return IMPL.get_workflow_execution(id, fields\u003dfields)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3f331d64","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":63},"updated":"2018-05-16 05:32:46.000000000","message":"Can you please turn this into a storyboard task?","commit_id":"6359053677f1d08406552c254e852329de82bb98"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"c4ae5475ea5f43528ae8e00d8b4ccfe50329cc0f","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Workflow executions."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# TODO(rakhmerov): Add \u0027fields\u0027 parameter to all \u0027get\u0027 methods."},{"line_number":246,"context_line":"def get_workflow_execution(id, fields\u003d()):"},{"line_number":247,"context_line":"    return IMPL.get_workflow_execution(id, fields\u003dfields)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_65858406","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":63},"in_reply_to":"5f7c97a3_05c850a3","updated":"2018-05-16 07:43:10.000000000","message":"Oh, I thought the Storyboard project has already been created (https://storyboard.openstack.org/#!/story/2002014). Now I see it is for Quinling.\nIn this case, yes a Launchpad bug. I see these kinds of comments all over the code rarely getting actually addressed. Maybe it\u0027s better tracking them as explicit bugs or bps.","commit_id":"6359053677f1d08406552c254e852329de82bb98"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"e27afed9ef536c470c9b8b30da9844e06d379c6a","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Workflow executions."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# TODO(rakhmerov): Add \u0027fields\u0027 parameter to all \u0027get\u0027 methods."},{"line_number":246,"context_line":"def get_workflow_execution(id, fields\u003d()):"},{"line_number":247,"context_line":"    return IMPL.get_workflow_execution(id, fields\u003dfields)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_05c850a3","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":63},"in_reply_to":"5f7c97a3_3f331d64","updated":"2018-05-16 07:24:00.000000000","message":"You mean Launchpad may be? Or we\u0027re already switching to Storyboard?","commit_id":"6359053677f1d08406552c254e852329de82bb98"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"f1e766701b560abdb04a9a5352816f632ff3a8ae","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Workflow executions."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"# TODO(rakhmerov): Add \u0027fields\u0027 parameter to all \u0027get\u0027 methods."},{"line_number":246,"context_line":"def get_workflow_execution(id, fields\u003d()):"},{"line_number":247,"context_line":"    return IMPL.get_workflow_execution(id, fields\u003dfields)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_33e596dc","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":63},"in_reply_to":"5f7c97a3_65858406","updated":"2018-05-16 09:18:27.000000000","message":"+1, creating a small bug and tagging it with \"tech-debt\" would be a good way to track them.","commit_id":"6359053677f1d08406552c254e852329de82bb98"}]}
