)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"051a813486df4fa45462836ce27283c61790dfe4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use register_session_conf_options API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using this API is needed to correctly initialize the configuration."},{"line_number":10,"context_line":"WORKING NOTICE: It is possible that this will incur config file changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: wangxiyuan\u003cwangxiyuan@huawei.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_6ab9f6c8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":72},"updated":"2018-07-19 11:48:53.000000000","message":"We can remove this note.","commit_id":"ffdf5fe6675cc60bc7282daeacd5fb0e228420dc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f68527946cad3583d590e351cd62e3f2ae53f646","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use register_session_conf_options API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using this API is needed to correctly initialize the configuration."},{"line_number":10,"context_line":"WORKING NOTICE: It is possible that this will incur config file changes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: wangxiyuan\u003cwangxiyuan@huawei.com\u003e"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_29ed3ab7","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":72},"in_reply_to":"5f7c97a3_6ab9f6c8","updated":"2018-07-20 01:23:11.000000000","message":"Done","commit_id":"ffdf5fe6675cc60bc7282daeacd5fb0e228420dc"}],"mistral/cmd/launch.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"051a813486df4fa45462836ce27283c61790dfe4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if opt in CONF[\u0027keystone\u0027]:"},{"line_number":187,"context_line":"            default_value \u003d auth_opts._group._opts[opt][\u0027opt\u0027].default"},{"line_number":188,"context_line":"            if default_value !\u003d value !\u003d CONF[\u0027keystone\u0027][opt]:"},{"line_number":189,"context_line":"                LOG.warning(\"Please add a same option \u0027%s\u0027 to [keystone] \""},{"line_number":190,"context_line":"                            \"section in the config file if you still want to \""},{"line_number":191,"context_line":"                            \"use it when talking with Keystone.\", opt)"},{"line_number":192,"context_line":"                CONF.set_override(opt, value, group\u003d\u0027keystone\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_6a8b361d","line":191,"range":{"start_line":189,"start_character":29,"end_line":191,"end_character":62},"updated":"2018-07-19 11:48:53.000000000","message":"I\u0027d reword like:\n\nThe config option \u0027%s\u0027 in section [keystone_authtoken] is deprecated. Please add the same option to the [keystone] section to keep using it.","commit_id":"ffdf5fe6675cc60bc7282daeacd5fb0e228420dc"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"f68527946cad3583d590e351cd62e3f2ae53f646","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if opt in CONF[\u0027keystone\u0027]:"},{"line_number":187,"context_line":"            default_value \u003d auth_opts._group._opts[opt][\u0027opt\u0027].default"},{"line_number":188,"context_line":"            if default_value !\u003d value !\u003d CONF[\u0027keystone\u0027][opt]:"},{"line_number":189,"context_line":"                LOG.warning(\"Please add a same option \u0027%s\u0027 to [keystone] \""},{"line_number":190,"context_line":"                            \"section in the config file if you still want to \""},{"line_number":191,"context_line":"                            \"use it when talking with Keystone.\", opt)"},{"line_number":192,"context_line":"                CONF.set_override(opt, value, group\u003d\u0027keystone\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_29d45ae9","line":191,"range":{"start_line":189,"start_character":29,"end_line":191,"end_character":62},"in_reply_to":"5f7c97a3_6a8b361d","updated":"2018-07-20 01:23:11.000000000","message":"sure, but actually the option is not deprecated, it is just a new copy to avoid abusing.","commit_id":"ffdf5fe6675cc60bc7282daeacd5fb0e228420dc"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"79b119b02baa0384d43d91c1b7dc6548fe4fdde2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"_KEYSTONE_SESSION_GROUP \u003d \"keystone_session\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":"loading.register_session_conf_options(cfg.CONF, _KEYSTONE_SESSION_GROUP)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def client():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a78b3266","line":33,"updated":"2018-06-07 12:06:49.000000000","message":"Why the need for a new config section?","commit_id":"0b068d00b48906dbdd58f95419a578a86f9b06f7"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"b799e875df2b1d611809125b97bd62adef0b6350","unresolved":false,"context_lines":[{"line_number":30,"context_line":"_KEYSTONE_SESSION_GROUP \u003d \"keystone_session\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":"loading.register_session_conf_options(cfg.CONF, _KEYSTONE_SESSION_GROUP)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def client():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0a3a2be6","line":33,"in_reply_to":"5f7c97a3_a78b3266","updated":"2018-06-07 13:06:05.000000000","message":"Registering in the same group (_base.AUTHTOKEN_GROUP) results in the cafile and other options to be added twice which raises an exception. The session options are now handled completely separately from the auth parameters in keystoneauth. The new session reflects the same behavior in Mistral.","commit_id":"0b068d00b48906dbdd58f95419a578a86f9b06f7"}]}