)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"95b93ea33584c063c1c35a2e418870cd36ae1626","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tshtilma \u003ctomer.shtilman@nokia.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-20 10:53:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generate default execution id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When execution id is not sent by the client, the api"},{"line_number":10,"context_line":"will generate source execution id"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f7c97a3_5d6e862c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":29},"updated":"2018-06-21 12:16:57.000000000","message":"I\u0027d say: Generate execution id in API if not set by client","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"95b93ea33584c063c1c35a2e418870cd36ae1626","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Generate default execution id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When execution id is not sent by the client, the api"},{"line_number":10,"context_line":"will generate source execution id"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae1ff327b5cb1af857d53ca53782d9fb30eefc27"},{"line_number":13,"context_line":"Closes-Bug: #1774164"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f7c97a3_5d4766a4","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":21},"updated":"2018-06-21 12:16:57.000000000","message":"We already have a source execution id that is a different parameter. So I think \u0027source\u0027 should be changed to \u0027a random\u0027.","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"8cb5d91fd06b0e07d534bf4c366372916b4f3ca5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Generate default execution id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When execution id is not sent by the client, the api"},{"line_number":10,"context_line":"will generate source execution id"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae1ff327b5cb1af857d53ca53782d9fb30eefc27"},{"line_number":13,"context_line":"Closes-Bug: #1774164"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5f7c97a3_56bae40a","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":21},"in_reply_to":"5f7c97a3_5d4766a4","updated":"2018-06-21 14:50:20.000000000","message":"This also confused me initially :)","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"}],"mistral/api/controllers/v2/execution.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"55c778b4d647ab00f53c10ea8a480c9955fb4408","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        source_exec_dict \u003d None"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2d63c1b3","line":235,"updated":"2018-06-05 10:12:25.000000000","message":"Please add a log message of the generated source_execution_id. This will help troubleshooting and debugging.","commit_id":"46f3bce638869be1c41532f7342558cb260f83c0"},{"author":{"_account_id":16358,"name":"Tomer Shtilman","email":"tomer.shtilman@nokia.com","username":"tshtilma"},"change_message_id":"1646b188abab93a4bae238abbd0c1c3cdf3b45fa","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        source_exec_dict \u003d None"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0874b39b","line":235,"in_reply_to":"5f7c97a3_2d63c1b3","updated":"2018-06-18 12:05:40.000000000","message":"Done","commit_id":"46f3bce638869be1c41532f7342558cb260f83c0"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"914f9122d6c7f92b17ae84c57b0ebd2c86132f5f","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        exec_id \u003d exec_dict.get(\u0027id\u0027)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":"            LOG.info(\"Generated source execution id  [source_execution_id\u003d%s]\", source_execution_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_681687f4","line":233,"updated":"2018-06-05 11:02:11.000000000","message":"You should generate id for the exec_id.\nThe source_execution_id is used for creation of execution based on existing one.\nNow you broke this feature.","commit_id":"21c9b975025594aff8eb5feafda6361631bb98b5"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"914f9122d6c7f92b17ae84c57b0ebd2c86132f5f","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":"            LOG.info(\"Generated source execution id  [source_execution_id\u003d%s]\", source_execution_id)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_28088fd7","line":234,"updated":"2018-06-05 11:02:11.000000000","message":"Remove the brackets","commit_id":"21c9b975025594aff8eb5feafda6361631bb98b5"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"914f9122d6c7f92b17ae84c57b0ebd2c86132f5f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":"            LOG.info(\"Generated source execution id  [source_execution_id\u003d%s]\", source_execution_id)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        source_exec_dict \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a8f33fe7","line":235,"updated":"2018-06-05 11:02:11.000000000","message":"Add spaces","commit_id":"21c9b975025594aff8eb5feafda6361631bb98b5"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"914f9122d6c7f92b17ae84c57b0ebd2c86132f5f","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not(source_execution_id):"},{"line_number":235,"context_line":"            source_execution_id\u003duuidutils.generate_uuid();"},{"line_number":236,"context_line":"            LOG.info(\"Generated source execution id  [source_execution_id\u003d%s]\", source_execution_id)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        source_exec_dict \u003d None"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_881f6308","line":236,"updated":"2018-06-05 11:02:11.000000000","message":"First of all you should use debug level.\nBut I am not sure about logging. How can this information be useful to the user?","commit_id":"21c9b975025594aff8eb5feafda6361631bb98b5"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"32ac15366d28e9430c5878360f9c34763f81287f","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        source_exec_dict \u003d None"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        if wf_ex:"},{"line_number":242,"context_line":"            return resources.Execution.from_db_model(wf_ex)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d644101c","line":239,"updated":"2018-06-18 09:53:31.000000000","message":"I would put these in the \"else\" of \"if not exec_id:\"","commit_id":"c7ed3baac28742786700b2b8c35c09c041544014"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"1183a44bdb2a04ff0973b257b048cc23c77478d0","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d _load_deferred_output_field(None)"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_4bb83b74","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":53},"updated":"2018-06-19 07:57:46.000000000","message":"Why do we need this line? Can you please explain?","commit_id":"91e5cf111dd5e80fb856e5d9a152d504286ab5e0"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"af9a53d863f025982d8e891938f3354f8832e9a7","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d _load_deferred_output_field(None)"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_948bb9be","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":53},"in_reply_to":"5f7c97a3_0b1d6376","updated":"2018-06-20 08:07:24.000000000","message":"I\u0027d just do:\n\nwf_ex \u003d None","commit_id":"91e5cf111dd5e80fb856e5d9a152d504286ab5e0"},{"author":{"_account_id":16358,"name":"Tomer Shtilman","email":"tomer.shtilman@nokia.com","username":"tshtilma"},"change_message_id":"a5d369fe245b172a2e0d0ab233d2ca649bf9ba8e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d _load_deferred_output_field(None)"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_0b1d6376","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":53},"in_reply_to":"5f7c97a3_4bb83b74","updated":"2018-06-19 08:00:26.000000000","message":"this is what returned from _get_workflow_execution when nothing is found, when i moved the _get_workflow_execution to the else, i had to initialize the wf_ex to what used to be returned from _get_workflow_execution , tests were failing","commit_id":"91e5cf111dd5e80fb856e5d9a152d504286ab5e0"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"0afba4000ca63deb81f7c801c9cbbd35b4b43947","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d None"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_8f863fba","line":236,"updated":"2018-06-20 09:28:24.000000000","message":"I would also move lines 242-243 to here as well","commit_id":"3d1de08ae581486542fc028414ac8f3cc04279fe"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"71f1408ccf833bacaad6a077f41ff6ca365c4ebb","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d None"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_b1fd5e09","line":233,"updated":"2018-06-24 05:25:23.000000000","message":"I don\u0027t like this log. Because I don\u0027t understand how it helps.","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"},{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"7ccd503aeeba5f3ad84efae07ce2d29231ba2372","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d None"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_d187ba60","line":233,"in_reply_to":"5f7c97a3_b1fd5e09","updated":"2018-06-24 06:15:45.000000000","message":"Hi Vitali,\n\nI requested to have this log in a previous review because I do find it helpful.\nWe run Mistral in a distributed system with several API processes.\nWe have ELK that we use in order to search the logs and in case troubleshooting is needed, this log can help us correlate which API process (and on which host) initiated the workflow execution.","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"e08ce8ff52ac860552fb0774ca59f855ebecee24","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d None"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_51c16a7f","line":233,"in_reply_to":"5f7c97a3_d187ba60","updated":"2018-06-24 06:48:08.000000000","message":"Hi Moshe,\nMaybe following code will be better for your case to logging all of execution ids:\nif not exec_id:\n  exec_id \u003d uuidutils.generate_uuid()\n  wf_ex \u003d None\nelse:\n  wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)\n  if wf_ex:\n    return resources.Execution.from_db_model(wf_ex)\n\nLOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)","commit_id":"7b428b27b27a72a67e69a4f928cbdf386ee000fe"},{"author":{"_account_id":18955,"name":"dharmendra","email":"dharmendra.kushwaha@gmail.com","username":"dharmendra"},"change_message_id":"95cca4bdf516fdedeb30de74a6474b8a19650519","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        exec_id \u003d exec_dict.get(\u0027id\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            wf_ex \u003d None"},{"line_number":235,"context_line":"        else:"},{"line_number":236,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_964a9380","line":233,"range":{"start_line":232,"start_character":12,"end_line":233,"end_character":69},"updated":"2018-06-25 02:17:08.000000000","message":"Just a query:\nShouldn\u0027t we update exec_dict also with this new id?","commit_id":"9243f88076952b2e5d48d757924ccd44fd65b9cb"},{"author":{"_account_id":7700,"name":"Nikolay Mahotkin","email":"nikolay.makhotkin@gmail.com","username":"nmakhotkin"},"change_message_id":"2ae595e99c9deaa9f76c7b91a04fac9bbc0fe5eb","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            exec_dict.update({\u0027id\u0027:exec_id})"},{"line_number":235,"context_line":"            wf_ex \u003d None"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":238,"context_line":"            if wf_ex:"},{"line_number":239,"context_line":"                return resources.Execution.from_db_model(wf_ex)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        source_execution_id \u003d exec_dict.get(\u0027source_execution_id\u0027)"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_2a79cc2d","line":239,"range":{"start_line":237,"start_character":12,"end_line":239,"end_character":63},"updated":"2018-06-25 07:13:12.000000000","message":"IMO here should be an original comment about returning the object if it exists. Otherwise it is confusing: everyone would ask question \"why POST request just returning the value and not giving error?\"","commit_id":"dc93d990db01234864686f9ca936eed9f4c3211e"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"ef3b05207cdedb79159a190cfc02a5c7eaefc944","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            result_exec_dict.get(\u0027workflow_id\u0027,"},{"line_number":265,"context_line":"                                 result_exec_dict.get(\u0027workflow_name\u0027)),"},{"line_number":266,"context_line":"            result_exec_dict.get(\u0027workflow_namespace\u0027, \u0027\u0027),"},{"line_number":267,"context_line":"            exec_id,"},{"line_number":268,"context_line":"            result_exec_dict.get(\u0027input\u0027),"},{"line_number":269,"context_line":"            description\u003dresult_exec_dict.get(\u0027description\u0027, \u0027\u0027),"},{"line_number":270,"context_line":"            **result_exec_dict.get(\u0027params\u0027, {})"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f7c97a3_2ae22c02","line":267,"range":{"start_line":267,"start_character":12,"end_line":267,"end_character":19},"updated":"2018-06-25 07:24:41.000000000","message":"we should probably update this to result_exec_dict[\u0027id\u0027] for consistence","commit_id":"dc93d990db01234864686f9ca936eed9f4c3211e"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6489149603f65e272abc9934615c035ebd146768","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            exec_dict.update({\u0027id\u0027: exec_id})"},{"line_number":235,"context_line":"            wf_ex \u003d None"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            # If ID is present we need to check if such execution exists."}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_90e61216","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":45},"updated":"2018-06-25 09:58:13.000000000","message":"I think this needs to happen after the if statement to use the possible value found in line 229.","commit_id":"6a44ebe4688568c0128609042b32b34172e6f5bb"},{"author":{"_account_id":16358,"name":"Tomer Shtilman","email":"tomer.shtilman@nokia.com","username":"tshtilma"},"change_message_id":"643b7e0c32ae46e23d986f17e503265176f85335","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        if not exec_id:"},{"line_number":232,"context_line":"            exec_id \u003d uuidutils.generate_uuid()"},{"line_number":233,"context_line":"            LOG.debug(\"Generated execution id [exec_id\u003d%s]\", exec_id)"},{"line_number":234,"context_line":"            exec_dict.update({\u0027id\u0027: exec_id})"},{"line_number":235,"context_line":"            wf_ex \u003d None"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            # If ID is present we need to check if such execution exists."}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_162bdaea","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":45},"in_reply_to":"5f7c97a3_90e61216","updated":"2018-06-25 11:55:45.000000000","message":"dont think so , if we generate a new one then we update the dict , otherwise there is no need to update, nothing was changed","commit_id":"6a44ebe4688568c0128609042b32b34172e6f5bb"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"6489149603f65e272abc9934615c035ebd146768","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            # If ID is present we need to check if such execution exists."},{"line_number":238,"context_line":"            # If yes, the method just returns the object. If not, the ID"},{"line_number":239,"context_line":"            # will be used to create a new execution."},{"line_number":240,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":241,"context_line":"            if wf_ex:"},{"line_number":242,"context_line":"                return resources.Execution.from_db_model(wf_ex)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_10d3e239","line":240,"range":{"start_line":240,"start_character":44,"end_line":240,"end_character":51},"updated":"2018-06-25 09:58:13.000000000","message":"If we get here, exec_id is never used if the execution doesn\u0027t exist.","commit_id":"6a44ebe4688568c0128609042b32b34172e6f5bb"},{"author":{"_account_id":16358,"name":"Tomer Shtilman","email":"tomer.shtilman@nokia.com","username":"tshtilma"},"change_message_id":"643b7e0c32ae46e23d986f17e503265176f85335","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            # If ID is present we need to check if such execution exists."},{"line_number":238,"context_line":"            # If yes, the method just returns the object. If not, the ID"},{"line_number":239,"context_line":"            # will be used to create a new execution."},{"line_number":240,"context_line":"            wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)"},{"line_number":241,"context_line":"            if wf_ex:"},{"line_number":242,"context_line":"                return resources.Execution.from_db_model(wf_ex)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_f65ade7f","line":240,"range":{"start_line":240,"start_character":44,"end_line":240,"end_character":51},"in_reply_to":"5f7c97a3_10d3e239","updated":"2018-06-25 11:55:45.000000000","message":"the original code was \n if exec_id:\n    wf_ex \u003d _get_workflow_execution(exec_id, must_exist\u003dFalse)\nits stays the same, we added a condition for generating id. not sure i understand the comment.","commit_id":"6a44ebe4688568c0128609042b32b34172e6f5bb"}]}
