)]}'
{"mistral/engine/workflows.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"8bf00a7d13b857ceffedec1a9e16139903199daf","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            \u0027runtime_context\u0027: {"},{"line_number":316,"context_line":"                \u0027index\u0027: params.get(\u0027index\u0027, 0)"},{"line_number":317,"context_line":"            },"},{"line_number":318,"context_line":"            \u0027trust_id\u0027: params.get(\u0027trust_id\u0027),"},{"line_number":319,"context_line":"        })"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        self.wf_ex.input \u003d input_dict or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_847a8b21","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":22},"updated":"2018-09-04 13:24:11.000000000","message":"I couldn\u0027t find where this field was added in this patch","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"18a4992d37e150c7e49f2740b641d81cf28ffdbf","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            \u0027runtime_context\u0027: {"},{"line_number":316,"context_line":"                \u0027index\u0027: params.get(\u0027index\u0027, 0)"},{"line_number":317,"context_line":"            },"},{"line_number":318,"context_line":"            \u0027trust_id\u0027: params.get(\u0027trust_id\u0027),"},{"line_number":319,"context_line":"        })"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        self.wf_ex.input \u003d input_dict or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_dd511b32","line":318,"range":{"start_line":318,"start_character":12,"end_line":318,"end_character":22},"in_reply_to":"3f79a3b5_847a8b21","updated":"2018-09-05 12:11:26.000000000","message":"It\u0027s already in the context.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"}],"mistral/executors/default_executor.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"8bf00a7d13b857ceffedec1a9e16139903199daf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        execution_context)"},{"line_number":115,"context_line":"                    if not action_ctx.trust_id:"},{"line_number":116,"context_line":"                        trust \u003d {}"},{"line_number":117,"context_line":"                        security.add_trust_id(trust)"},{"line_number":118,"context_line":"                        action_ctx.trust_id \u003d trust.get(\u0027trust_id\u0027)"},{"line_number":119,"context_line":"                    result \u003d action.run(action_ctx)"},{"line_number":120,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_e1aca6a0","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":52},"updated":"2018-09-04 13:24:11.000000000","message":"how is this trust cleaned up?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"b83a9fbf932ed00eb319dfcc38f16dae118c982e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        execution_context)"},{"line_number":115,"context_line":"                    if not action_ctx.trust_id:"},{"line_number":116,"context_line":"                        trust \u003d {}"},{"line_number":117,"context_line":"                        security.add_trust_id(trust)"},{"line_number":118,"context_line":"                        action_ctx.trust_id \u003d trust.get(\u0027trust_id\u0027)"},{"line_number":119,"context_line":"                    result \u003d action.run(action_ctx)"},{"line_number":120,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_8feb6adb","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":52},"in_reply_to":"3f79a3b5_5d3bcbe8","updated":"2018-09-05 12:35:29.000000000","message":"It must be added to the finally block.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"18a4992d37e150c7e49f2740b641d81cf28ffdbf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        execution_context)"},{"line_number":115,"context_line":"                    if not action_ctx.trust_id:"},{"line_number":116,"context_line":"                        trust \u003d {}"},{"line_number":117,"context_line":"                        security.add_trust_id(trust)"},{"line_number":118,"context_line":"                        action_ctx.trust_id \u003d trust.get(\u0027trust_id\u0027)"},{"line_number":119,"context_line":"                    result \u003d action.run(action_ctx)"},{"line_number":120,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_5d3bcbe8","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":52},"in_reply_to":"3f79a3b5_e1aca6a0","updated":"2018-09-05 12:11:26.000000000","message":"It isn\u0027t. This was specifically added for the case of calling an action directly, outside of a workflow. Any ideas for how cleanup should be handled?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"8bf00a7d13b857ceffedec1a9e16139903199daf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise AssertionError(\u0027context is mandatory\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if context.trust_id:"},{"line_number":69,"context_line":"        kwargs[\u0027project_name\u0027] \u003d None"},{"line_number":70,"context_line":"        kwargs[\u0027project_domain_name\u0027] \u003d None"},{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_04a0bbf3","line":71,"range":{"start_line":69,"start_character":8,"end_line":71,"end_character":35},"updated":"2018-09-04 13:24:11.000000000","message":"mistral/utils/openstack/keystone.py L122 has additional keys set, don\u0027t we need those here?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"18a4992d37e150c7e49f2740b641d81cf28ffdbf","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise AssertionError(\u0027context is mandatory\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if context.trust_id:"},{"line_number":69,"context_line":"        kwargs[\u0027project_name\u0027] \u003d None"},{"line_number":70,"context_line":"        kwargs[\u0027project_domain_name\u0027] \u003d None"},{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_5d142b4d","line":71,"range":{"start_line":69,"start_character":8,"end_line":71,"end_character":35},"in_reply_to":"3f79a3b5_04a0bbf3","updated":"2018-09-05 12:11:26.000000000","message":"This part is specifically to support trusts. These specific fields must be set to None for the trust to work.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"d7e5ae99acf2ff2d8c83994e72f6157fa41a4992","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_275c997b","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"updated":"2018-09-06 18:25:52.000000000","message":"I missed this part so far. As I read, this would require Mistral to be configured with admin credentials for all executions running with a trust. This could be a serious break. This type of code is usually guarded by some CONF.pecan.auth_enabled condition.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"872323bbea36bd8067480908666eaa4c374ffc20","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_259fa7b4","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_275c997b","updated":"2018-09-07 07:43:43.000000000","message":"Seems reasonable, yes.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"9494206a7bb94cf39eb3747a33616b9bee202fa9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_fc148143","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_275c997b","updated":"2018-09-12 18:58:46.000000000","message":"This code wouldn\u0027t be called unless you have auth enabled anyway.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a159abcd7a09c1f605fc432b1f95aaa240c5bd60","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_272a87e6","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_4bb3174f","updated":"2018-09-18 04:35:49.000000000","message":"The big difference is that the original code uses almost exclusively the context parameters. Therefore, Mistral can run OS actions without having been configured at all.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"6e1c7a6cad0076bc3518545301c72962d136d506","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_4bb3174f","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_d9318c0c","updated":"2018-09-17 20:34:06.000000000","message":"Not really... I was actually thinking of a different part of the code. I\u0027m not so sure that it is guarded, but no more so than the else: clause was before (which was the default code here)","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ff232069fe9585d37b48edf8db10832b75846e13","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_d9318c0c","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_fc148143","updated":"2018-09-13 05:05:55.000000000","message":"Brad, you mean line 65? Is it a guard for this code snippet?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a159abcd7a09c1f605fc432b1f95aaa240c5bd60","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        kwargs[\u0027project_id\u0027] \u003d None"},{"line_number":72,"context_line":"        kwargs[\u0027trust_id\u0027] \u003d context.trust_id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        auth \u003d loading.load_auth_from_conf_options("},{"line_number":75,"context_line":"            CONF,"},{"line_number":76,"context_line":"            \u0027keystone_authtoken\u0027,"},{"line_number":77,"context_line":"            **kwargs"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session \u003d loading.load_session_from_conf_options("},{"line_number":80,"context_line":"            CONF,"},{"line_number":81,"context_line":"            \u0027keystone\u0027,"},{"line_number":82,"context_line":"            auth\u003dauth"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        project_endpoint \u003d get_endpoint_for_project(**kwargs)"},{"line_number":86,"context_line":"        endpoint \u003d format_url("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_87d27bfc","line":83,"range":{"start_line":74,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"3f79a3b5_fc148143","updated":"2018-09-18 04:35:49.000000000","message":"With the target* parameters, the execution get to this point any time. The creation of this trust should be guarded by checks for admin credentials. If those aren\u0027t present, the trust should be used as is.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"}],"mistral/workflow/data_flow.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"8bf00a7d13b857ceffedec1a9e16139903199daf","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if CONF.pecan.auth_enable:"},{"line_number":295,"context_line":"        exec_ctx \u003d auth_ctx.ctx()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not exec_ctx.trust_id:"},{"line_number":298,"context_line":"            trust \u003d security.create_trust()"},{"line_number":299,"context_line":"            exec_ctx.trust_id \u003d trust.id"},{"line_number":300,"context_line":"            exec_ctx.is_trust_scoped \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_444d5339","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":33},"updated":"2018-09-04 13:24:11.000000000","message":"can you please explain why all executions are made trust scoped if they aren\u0027t started with a trust?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"18a4992d37e150c7e49f2740b641d81cf28ffdbf","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if CONF.pecan.auth_enable:"},{"line_number":295,"context_line":"        exec_ctx \u003d auth_ctx.ctx()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not exec_ctx.trust_id:"},{"line_number":298,"context_line":"            trust \u003d security.create_trust()"},{"line_number":299,"context_line":"            exec_ctx.trust_id \u003d trust.id"},{"line_number":300,"context_line":"            exec_ctx.is_trust_scoped \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_bd7bffbc","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":33},"in_reply_to":"3f79a3b5_444d5339","updated":"2018-09-05 12:11:26.000000000","message":"The idea is to use trusts by default. Is there a problem with that?","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"b83a9fbf932ed00eb319dfcc38f16dae118c982e","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if CONF.pecan.auth_enable:"},{"line_number":295,"context_line":"        exec_ctx \u003d auth_ctx.ctx()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not exec_ctx.trust_id:"},{"line_number":298,"context_line":"            trust \u003d security.create_trust()"},{"line_number":299,"context_line":"            exec_ctx.trust_id \u003d trust.id"},{"line_number":300,"context_line":"            exec_ctx.is_trust_scoped \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_ef79be2e","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":33},"in_reply_to":"3f79a3b5_bd7bffbc","updated":"2018-09-05 12:35:29.000000000","message":"Yes, because in Keystone V2 there is no trust, so this would break that backward compatibility path. Otherwise, I don\u0027t know the possible performance effect of creating a new trust for everything but it would be good if we considered this aspect too.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"},{"author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"change_message_id":"8332760c2f0b83e48b86d591fe79779d3086f240","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    if CONF.pecan.auth_enable:"},{"line_number":295,"context_line":"        exec_ctx \u003d auth_ctx.ctx()"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        if not exec_ctx.trust_id:"},{"line_number":298,"context_line":"            trust \u003d security.create_trust()"},{"line_number":299,"context_line":"            exec_ctx.trust_id \u003d trust.id"},{"line_number":300,"context_line":"            exec_ctx.is_trust_scoped \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_65670d27","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":33},"in_reply_to":"3f79a3b5_ef79be2e","updated":"2018-09-05 14:18:28.000000000","message":"We can\u0027t be expected to support Keystone v2 in master in perpetuity. If Keystone v2 is necessary, one can run \u003c\u003d Rocky. Otherwise, one must use Keystone v3.","commit_id":"9cf2773065b10a4618e3b7caeb05998b592480cd"}]}
