)]}'
{"mistral/api/controllers/v2/workflow.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"17b72eac9daa2eff0d9ce879f23c72f4c2a67942","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                \"Scope must be one of the following: %s; actual: \""},{"line_number":122,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":123,"context_line":"            )"},{"line_number":124,"context_line":"        elif scope \u003d\u003d \u0027public\u0027:"},{"line_number":125,"context_line":"            acl.enforce(\u0027workflows:publicize\u0027, context.ctx())"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        LOG.debug(\"Update workflow(s) [definition\u003d%s]\", definition)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_94dc19e2","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":31},"updated":"2018-07-03 06:01:50.000000000","message":"I think it\u0027s also worth adding a check that the state wasn\u0027t already \"public\". I can imagine a situation as a legitimate when a workflow was already made \"public\" on purpose by admin and then this check doesn\u0027t make sense at all. By the way, I think admin should always have a permission to make a resource public.","commit_id":"ae0fc861ea8cc8ea56fd050ae8fa0acfc0b17d84"},{"author":{"_account_id":28101,"name":"Pierre Gaxatte","email":"pierre.gaxatte@corp.ovh.com","username":"pgaxatte"},"change_message_id":"8af02edca9a43c6372427ead8836031c292a57eb","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                \"Scope must be one of the following: %s; actual: \""},{"line_number":122,"context_line":"                \"%s\" % (resources.SCOPE_TYPES.values, scope)"},{"line_number":123,"context_line":"            )"},{"line_number":124,"context_line":"        elif scope \u003d\u003d \u0027public\u0027:"},{"line_number":125,"context_line":"            acl.enforce(\u0027workflows:publicize\u0027, context.ctx())"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        LOG.debug(\"Update workflow(s) [definition\u003d%s]\", definition)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_726f0c60","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":31},"in_reply_to":"5f7c97a3_94dc19e2","updated":"2018-07-04 13:26:01.000000000","message":"Yes that makes sense, so check previous state and bypass ACL if admin.","commit_id":"ae0fc861ea8cc8ea56fd050ae8fa0acfc0b17d84"}]}