)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d05562cf29f869a613a9447bbe5e878ebe6f4c76","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Data context is always empty in a log"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Override __str__ and __repr__ methods for DataFlow class."},{"line_number":10,"context_line":"* Don\u0027t publish a data context as a task result."},{"line_number":11,"context_line":"  Because it\u0027s insecure and it can be cut by"},{"line_number":12,"context_line":"  \"execution_field_size_limit_kb\" for a big workflow."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_c3f93ec6","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":58},"updated":"2018-07-30 09:21:33.000000000","message":"I don\u0027t remember such a class :)","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"}],"mistral/expressions/jinja_expression.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d05562cf29f869a613a9447bbe5e878ebe6f4c76","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"                raise e"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            msg \u003d \"Can not evaluate Jinja expression [expression\u003d{exp}, \" \\"},{"line_number":151,"context_line":"                  \"error\u003d{err}{context}]\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            # NOTE(mcdoker18): We don\u0027t want to publish a data context as a"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a3bc42db","line":150,"range":{"start_line":150,"start_character":74,"end_line":150,"end_character":75},"updated":"2018-07-30 09:21:33.000000000","message":"Minor thing: it\u0027s recommended to avoid back slashes for breaking lines.","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d05562cf29f869a613a9447bbe5e878ebe6f4c76","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                  \"error\u003d{err}{context}]\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            # NOTE(mcdoker18): We don\u0027t want to publish a data context as a"},{"line_number":154,"context_line":"            # task result. Because it\u0027s not insecure and it can be cut by"},{"line_number":155,"context_line":"            # \"execution_field_size_limit_kb\" for a big workflow."},{"line_number":156,"context_line":"            LOG.error(msg.format("},{"line_number":157,"context_line":"                exp\u003dexpression, err\u003de,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c395be3f","line":154,"range":{"start_line":154,"start_character":35,"end_line":154,"end_character":52},"updated":"2018-07-30 09:21:33.000000000","message":"\"it\u0027s not insecure\" Is it a typo?","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"773f031fac003df071c67f140791b3cc94b14c43","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            msg \u003d \"Can not evaluate Jinja expression [expression\u003d{exp}, \" \\"},{"line_number":151,"context_line":"                  \"error\u003d{err}{context}]\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            # NOTE(mcdoker18): We don\u0027t want to publish a data context as a"},{"line_number":154,"context_line":"            # task result. Because it\u0027s not insecure and it can be cut by"},{"line_number":155,"context_line":"            # \"execution_field_size_limit_kb\" for a big workflow."},{"line_number":156,"context_line":"            LOG.error(msg.format("},{"line_number":157,"context_line":"                exp\u003dexpression, err\u003de,"},{"line_number":158,"context_line":"                context\u003d\u0027, context\u003d{}\u0027.format(data_context))"},{"line_number":159,"context_line":"            )"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            raise exc.JinjaEvaluationException("},{"line_number":162,"context_line":"                msg.format(exp\u003dexpression, err\u003de, context\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_dd227fb7","line":159,"range":{"start_line":153,"start_character":0,"end_line":159,"end_character":13},"updated":"2018-07-30 07:56:38.000000000","message":"It\u0027s insecure to log stuff that may contain private data. Let\u0027s leave the data out of the logs. Here and in the log above too.","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"},{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"58f1a5aacda33ee6384f3108f26a6b8d136e175e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            msg \u003d \"Can not evaluate Jinja expression [expression\u003d{exp}, \" \\"},{"line_number":151,"context_line":"                  \"error\u003d{err}{context}]\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"            # NOTE(mcdoker18): We don\u0027t want to publish a data context as a"},{"line_number":154,"context_line":"            # task result. Because it\u0027s not insecure and it can be cut by"},{"line_number":155,"context_line":"            # \"execution_field_size_limit_kb\" for a big workflow."},{"line_number":156,"context_line":"            LOG.error(msg.format("},{"line_number":157,"context_line":"                exp\u003dexpression, err\u003de,"},{"line_number":158,"context_line":"                context\u003d\u0027, context\u003d{}\u0027.format(data_context))"},{"line_number":159,"context_line":"            )"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            raise exc.JinjaEvaluationException("},{"line_number":162,"context_line":"                msg.format(exp\u003dexpression, err\u003de, context\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d80fedd1","line":159,"range":{"start_line":153,"start_character":0,"end_line":159,"end_character":13},"in_reply_to":"5f7c97a3_dd227fb7","updated":"2018-07-30 08:18:25.000000000","message":"I don\u0027t agree. We already log a workflow output and input, a action input and result and so on.\nIf you have yaql expression, context and error message then you can fix a problem in your yaql expression easily.\nIf you don\u0027t want to log your private data, we or a user should encrypt them but not forbid other parameters.","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d05562cf29f869a613a9447bbe5e878ebe6f4c76","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            )"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            raise exc.JinjaEvaluationException("},{"line_number":162,"context_line":"                msg.format(exp\u003dexpression, err\u003de, context\u003d\u0027\u0027)"},{"line_number":163,"context_line":"            )"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_039e5654","line":162,"range":{"start_line":162,"start_character":50,"end_line":162,"end_character":60},"updated":"2018-07-30 09:21:33.000000000","message":"Not sure I understand the entire idea. You added a log where we log all information. But you exclude it from the exception message. What\u0027s the difference? Both will get into the log anyway. What am I missing?","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"}],"mistral/expressions/yaql_expression.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"773f031fac003df071c67f140791b3cc94b14c43","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            msg \u003d \"Can not evaluate YAQL expression [expression\u003d{exp}, \" \\"},{"line_number":112,"context_line":"                  \"error\u003d{err}{context}]\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            # NOTE(mcdoker18): We don\u0027t want to publish a data context as a"},{"line_number":115,"context_line":"            # task result. Because it\u0027s insecure and it can be cut by"},{"line_number":116,"context_line":"            # \"execution_field_size_limit_kb\" for a big workflow."},{"line_number":117,"context_line":"            LOG.error(msg.format("},{"line_number":118,"context_line":"                exp\u003dexpression, err\u003de,"},{"line_number":119,"context_line":"                context\u003d\u0027, context\u003d{}\u0027.format(data_context))"},{"line_number":120,"context_line":"            )"},{"line_number":121,"context_line":"            raise exc.YaqlEvaluationException("},{"line_number":122,"context_line":"                msg.format(exp\u003dexpression, err\u003de, context\u003d\u0027\u0027)"},{"line_number":123,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7d156b4b","line":120,"range":{"start_line":114,"start_character":11,"end_line":120,"end_character":13},"updated":"2018-07-30 07:56:38.000000000","message":"Same as the jinja comment.","commit_id":"13f35d3d2c096401a41e1b5f5e3794634ccf8d4a"}],"mistral/tests/unit/engine/test_error_handling.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"d05562cf29f869a613a9447bbe5e878ebe6f4c76","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.assertIsNotNone(state_info)"},{"line_number":442,"context_line":"        self.assertGreater(state_info.find(\u0027error\u003d\u0027), 0)"},{"line_number":443,"context_line":"        self.assertLess(state_info.find(\u0027error\u003d\u0027), state_info.find(\u0027data\u003d\u0027))"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def test_error_message_format_invalid_on_task_run(self):"},{"line_number":446,"context_line":"        wf_text \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_43de8e0f","side":"PARENT","line":443,"range":{"start_line":443,"start_character":8,"end_line":443,"end_character":76},"updated":"2018-07-30 09:21:33.000000000","message":"My guts are against it. If we think about users who want to understand what happened with their failed workflow, the only thing they have is the number of execution objects. They don\u0027t see logs.","commit_id":"b01d6c6642b01461851aee5ac7709185c478e320"}]}
