)]}'
{"mistral/actions/std_actions.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"a8cf002e68daee28f1db019878ed00174fd0b70d","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def run(self, context):"},{"line_number":397,"context_line":"        def raise_exc(parent_exc\u003dNone):"},{"line_number":398,"context_line":"            # We suppress the error messages in favor of more generic ones"},{"line_number":399,"context_line":"            message \u003d (\"Failed to execute ssh cmd \""},{"line_number":400,"context_line":"                       \"\u0027%s\u0027 on %s\" % (self.cmd, self.host))"},{"line_number":401,"context_line":"            if parent_exc:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3cf2c09b","line":398,"updated":"2018-09-03 12:18:20.000000000","message":"I understand this comment, but outside of the context of this patch it is hard to see how something is suppressed.","commit_id":"ef5bca8cb93a16e069d138d33bf7482759f7b01f"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"a8cf002e68daee28f1db019878ed00174fd0b70d","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            # We suppress the error messages in favor of more generic ones"},{"line_number":399,"context_line":"            message \u003d (\"Failed to execute ssh cmd \""},{"line_number":400,"context_line":"                       \"\u0027%s\u0027 on %s\" % (self.cmd, self.host))"},{"line_number":401,"context_line":"            if parent_exc:"},{"line_number":402,"context_line":"                LOG.error(message + \" Exception: %s\" % str(parent_exc))"},{"line_number":403,"context_line":"            raise exc.ActionException(message)"},{"line_number":404,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1c2d84fc","line":401,"updated":"2018-09-03 12:18:20.000000000","message":"I would add the the above comment here. Something about only logging the error here as it can include more information than should be shared publicly.","commit_id":"ef5bca8cb93a16e069d138d33bf7482759f7b01f"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"c731bf4b0236b7b34299c48fa417e62b9aa87808","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        def raise_exc(parent_exc\u003dNone):"},{"line_number":398,"context_line":"            message \u003d (\"Failed to execute ssh cmd \""},{"line_number":399,"context_line":"                       \"\u0027%s\u0027 on %s\" % (self.cmd, self.host))"},{"line_number":400,"context_line":"            # We suppress the actual parrent error messages in favor of"},{"line_number":401,"context_line":"            # more generic ones as we might be leaking information to the CLI"},{"line_number":402,"context_line":"            if parent_exc:"},{"line_number":403,"context_line":"                # The full error message needs to be logged regardless"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3cccd532","line":400,"range":{"start_line":400,"start_character":37,"end_line":400,"end_character":44},"updated":"2018-09-05 09:02:25.000000000","message":"parent","commit_id":"2329b163d07bd3e82fd6041e5ab80946b88f6af6"}]}
