)]}'
{"mistral/engine/workflows.py":[{"author":{"_account_id":27008,"name":"Vitalii Solodilov","email":"Mcdkr@yandex.ru","username":"mcdoker18"},"change_message_id":"b1fa7ba891717d12dc01faf7763756f1b4991e58","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        )"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        LOG.debug(\"Workflow completed [id\u003d%s]\", self.wf_ex.id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # NOTE(rakhmerov): Once we know that the workflow has completed,"},{"line_number":417,"context_line":"        # we need to expire all the objects in the DB session to make sure"},{"line_number":418,"context_line":"        # to read the most relevant data from the DB (that\u0027s already been"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9e678fb8","line":415,"updated":"2018-09-12 09:10:20.000000000","message":"I guess we should move the expide_all call behind\n\n         if incomplete_tasks_count \u003e 0:\n            return incomplete_tasks_count","commit_id":"66e507edb82e1525c7c54ecfde1b690afc4788c2"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"ac98628c0f079d8d7a168c0aee5fe79ec061660e","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        )"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        LOG.debug(\"Workflow completed [id\u003d%s]\", self.wf_ex.id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # NOTE(rakhmerov): Once we know that the workflow has completed,"},{"line_number":417,"context_line":"        # we need to expire all the objects in the DB session to make sure"},{"line_number":418,"context_line":"        # to read the most relevant data from the DB (that\u0027s already been"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fe37a3fd","line":415,"in_reply_to":"3f79a3b5_9e678fb8","updated":"2018-09-12 09:41:07.000000000","message":"Vitalii, no. We need to expire session objects only when we executed the query that gave us the answer whether the workflow completed or not. Only after that it makes sense to do. The query itself bypasses the session cache.","commit_id":"66e507edb82e1525c7c54ecfde1b690afc4788c2"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"2fa0f1e968f7f9edb4a66883b64d53607995f3b3","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        )"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        LOG.debug(\"Workflow completed [id\u003d%s]\", self.wf_ex.id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        # NOTE(rakhmerov): Once we know that the workflow has completed,"},{"line_number":417,"context_line":"        # we need to expire all the objects in the DB session to make sure"},{"line_number":418,"context_line":"        # to read the most relevant data from the DB (that\u0027s already been"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5978318e","line":415,"in_reply_to":"3f79a3b5_fe37a3fd","updated":"2018-09-12 09:49:14.000000000","message":"Vitalii, I apologize. You\u0027re right. I just misplaced this snippet.","commit_id":"66e507edb82e1525c7c54ecfde1b690afc4788c2"}]}
