)]}'
{"mistral/config.py":[{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3cb2bc5a3265bb4c83e493c1ed21a300b637e948","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        help\u003d_(\u0027Enables input data conversion for YAQL expressions. If set \u0027"},{"line_number":567,"context_line":"               \u0027to True then YAQL will convert mutable data structures \u0027"},{"line_number":568,"context_line":"               \u0027(lists, dicts, sets) into their immutable versions. That \u0027"},{"line_number":569,"context_line":"               \u0027will allow to work with some constructs that require hashable \u0027"},{"line_number":570,"context_line":"               \u0027types even if elements are not hashable. For example, it will \u0027"},{"line_number":571,"context_line":"               \u0027be possible to put dicts into a set. Although it conflicts \u0027"},{"line_number":572,"context_line":"               \u0027with the base principles of such collections (e.g. we cannot \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_a7ada39c","line":569,"range":{"start_line":569,"start_character":27,"end_line":569,"end_character":29},"updated":"2019-04-01 10:52:40.000000000","message":"suggestion: \"them to\"","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3cb2bc5a3265bb4c83e493c1ed21a300b637e948","unresolved":false,"context_lines":[{"line_number":571,"context_line":"               \u0027be possible to put dicts into a set. Although it conflicts \u0027"},{"line_number":572,"context_line":"               \u0027with the base principles of such collections (e.g. we cannot \u0027"},{"line_number":573,"context_line":"               \u0027put a non-hashable type into a set just because otherwise it \u0027"},{"line_number":574,"context_line":"               \u0027will not work correctly) YAQL library itself allows this, so \u0027"},{"line_number":575,"context_line":"               \u0027that it seems very much like we can have sets of dicts or a \u0027"},{"line_number":576,"context_line":"               \u0027similar structure. \u0027"},{"line_number":577,"context_line":"               \u0027Disabling input data conversion may give significant \u0027"},{"line_number":578,"context_line":"               \u0027performance boost in case if input data for an expression is \u0027"},{"line_number":579,"context_line":"               \u0027large.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_878187fe","line":576,"range":{"start_line":574,"start_character":73,"end_line":576,"end_character":34},"updated":"2019-04-01 10:52:40.000000000","message":"not sure this bit is needed?","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3cb2bc5a3265bb4c83e493c1ed21a300b637e948","unresolved":false,"context_lines":[{"line_number":575,"context_line":"               \u0027that it seems very much like we can have sets of dicts or a \u0027"},{"line_number":576,"context_line":"               \u0027similar structure. \u0027"},{"line_number":577,"context_line":"               \u0027Disabling input data conversion may give significant \u0027"},{"line_number":578,"context_line":"               \u0027performance boost in case if input data for an expression is \u0027"},{"line_number":579,"context_line":"               \u0027large.\u0027)"},{"line_number":580,"context_line":"    ),"},{"line_number":581,"context_line":"    cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c7878f12","line":578,"range":{"start_line":578,"start_character":16,"end_line":578,"end_character":55},"updated":"2019-04-01 10:52:40.000000000","message":"suggestion \"performance boost if the input data\"","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"}],"mistral/utils/expression_utils.py":[{"author":{"_account_id":9029,"name":"Moshe Elisha","email":"moshe.elisha@nokia.com","username":"MosheElisha"},"change_message_id":"dadf224601cd832d5141116a3f6bf68b9ad45176","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    new_ctx \u003d ROOT_YAQL_CONTEXT.create_child_context()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    if cfg.CONF.yaql.convert_input_data:"},{"line_number":54,"context_line":"        new_ctx[\u0027$\u0027] \u003d yaql_utils.convert_input_data(data_context)"},{"line_number":55,"context_line":"    else:"},{"line_number":56,"context_line":"        new_ctx[\u0027$\u0027] \u003d data_context"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_a8b287e3","line":53,"updated":"2019-03-28 10:29:38.000000000","message":"Soft: IMO a \"short if\" will be nicer here as you can easily see that \"new_ctx[\u0027$\u0027]\" is always assigned with a value.","commit_id":"3543366b6c078d5bf2185af4f89df8858598ba29"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"3cb2bc5a3265bb4c83e493c1ed21a300b637e948","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    new_ctx[\u0027$\u0027] \u003d ("},{"line_number":54,"context_line":"        data_context if not cfg.CONF.yaql.convert_input_data"},{"line_number":55,"context_line":"        else yaql_utils.convert_input_data(data_context)"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if isinstance(data_context, dict):"},{"line_number":59,"context_line":"        new_ctx[\u0027__env\u0027] \u003d data_context.get(\u0027__env\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_67ca5b6f","line":56,"updated":"2019-04-01 10:52:40.000000000","message":"I this this is substantially harder to read than a regular if statement.","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"},{"author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"change_message_id":"4627f04d84963db47445c1741a8f36e2382092a2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    new_ctx[\u0027$\u0027] \u003d ("},{"line_number":54,"context_line":"        data_context if not cfg.CONF.yaql.convert_input_data"},{"line_number":55,"context_line":"        else yaql_utils.convert_input_data(data_context)"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if isinstance(data_context, dict):"},{"line_number":59,"context_line":"        new_ctx[\u0027__env\u0027] \u003d data_context.get(\u0027__env\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_c98550d1","line":56,"in_reply_to":"5fc1f717_33b32750","updated":"2019-04-02 08:30:17.000000000","message":"Yeah, I seen that. I would only ever use the ternary style if statement if it fit on one line - not 4.\n\nBut sure, just leave it as you wish","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"4345e1a2297a393d9aae59815d07db3c5598e535","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    new_ctx[\u0027$\u0027] \u003d ("},{"line_number":54,"context_line":"        data_context if not cfg.CONF.yaql.convert_input_data"},{"line_number":55,"context_line":"        else yaql_utils.convert_input_data(data_context)"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if isinstance(data_context, dict):"},{"line_number":59,"context_line":"        new_ctx[\u0027__env\u0027] \u003d data_context.get(\u0027__env\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_33b32750","line":56,"in_reply_to":"5fc1f717_67ca5b6f","updated":"2019-04-02 04:53:17.000000000","message":"There was another comment that conflicts with yours :) So let\u0027s please leave it as is for now.","commit_id":"a92aa716e09d5d1aa0fcd6d7c9ac94e3734d476c"}]}
