)]}'
{"mistral/db/sqlalchemy/migration/alembic_migrations/versions/033_add_next_tasks_to_task_execution.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"3bf2641fcbe82fdaebb5b84cd1a0bc15b039d9c0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.add_column("},{"line_number":36,"context_line":"        \u0027task_executions_v2\u0027,"},{"line_number":37,"context_line":"        sa.Column(\u0027next_tasks\u0027, st.JsonEncoded(), nullable\u003dTrue)"},{"line_number":38,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_59c4665f","line":37,"range":{"start_line":37,"start_character":32,"end_line":37,"end_character":48},"updated":"2019-06-10 09:02:22.000000000","message":"should this be st.JsonListType() to match the class definition?","commit_id":"0f5853611ee270056c41d171ffd96a4d523afe4e"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"db7c4c6c432b6133a8bff301bfbcc782bebb342c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.add_column("},{"line_number":36,"context_line":"        \u0027task_executions_v2\u0027,"},{"line_number":37,"context_line":"        sa.Column(\u0027next_tasks\u0027, st.JsonEncoded(), nullable\u003dTrue)"},{"line_number":38,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_d985b6d0","line":37,"range":{"start_line":37,"start_character":32,"end_line":37,"end_character":48},"in_reply_to":"9fb8cfa7_59c4665f","updated":"2019-06-10 09:17:27.000000000","message":"Yes! Done.","commit_id":"0f5853611ee270056c41d171ffd96a4d523afe4e"}],"mistral/workflow/base.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"3bf2641fcbe82fdaebb5b84cd1a0bc15b039d9c0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            mistral.workflow.commands.WorkflowCommand)."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if self._is_completed():"},{"line_number":132,"context_line":"            return []"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return self._find_next_commands(task_ex)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_3975f232","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":32},"updated":"2019-06-10 09:02:22.000000000","message":"can you please shed some light on why the paused state is not applied any more?","commit_id":"0f5853611ee270056c41d171ffd96a4d523afe4e"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"db7c4c6c432b6133a8bff301bfbcc782bebb342c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            mistral.workflow.commands.WorkflowCommand)."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if self._is_completed():"},{"line_number":132,"context_line":"            return []"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        return self._find_next_commands(task_ex)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_f963da40","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":32},"in_reply_to":"9fb8cfa7_3975f232","updated":"2019-06-10 09:17:27.000000000","message":"Yes. This is because now we have to store next_tasks in any case, regardless of whether the workflow is paused or not. Previously we would always recalculate it in the place where it\u0027s needed (e.g. when checking a \"join\") but with this patch we don\u0027t do this anymore.","commit_id":"0f5853611ee270056c41d171ffd96a4d523afe4e"}],"mistral/workflow/direct_workflow.py":[{"author":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"change_message_id":"5b9bfd4dd1a49ace116798ba96f2008e94496e03","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        #         fields\u003d(\u0027id\u0027, \u0027name\u0027, \u0027state\u0027),"},{"line_number":66,"context_line":"        #         name\u003d{\u0027in\u0027: names}"},{"line_number":67,"context_line":"        #     )"},{"line_number":68,"context_line":"        # } if names else {}  # don\u0027t perform a db request if \u0027names\u0027 are empty"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        induced_state, _, _ \u003d self._get_induced_join_state("},{"line_number":71,"context_line":"            self.wf_spec.get_tasks()[t_ex_candidate.name],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_392c12ab","line":68,"updated":"2019-06-10 09:47:09.000000000","message":"this should be removed imo :)","commit_id":"a7d392224242a0b09b1cc131fdf6ef6d7f7abb4c"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"c03c538cd05f740c391e16c15713fede6ce0f657","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        #         fields\u003d(\u0027id\u0027, \u0027name\u0027, \u0027state\u0027),"},{"line_number":66,"context_line":"        #         name\u003d{\u0027in\u0027: names}"},{"line_number":67,"context_line":"        #     )"},{"line_number":68,"context_line":"        # } if names else {}  # don\u0027t perform a db request if \u0027names\u0027 are empty"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        induced_state, _, _ \u003d self._get_induced_join_state("},{"line_number":71,"context_line":"            self.wf_spec.get_tasks()[t_ex_candidate.name],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_748cd17e","line":68,"in_reply_to":"9fb8cfa7_347df97e","updated":"2019-06-10 09:53:36.000000000","message":"Ooopps..","commit_id":"a7d392224242a0b09b1cc131fdf6ef6d7f7abb4c"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f52346b9ae521167fae13e99b2ead08f9b2954e6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        #         fields\u003d(\u0027id\u0027, \u0027name\u0027, \u0027state\u0027),"},{"line_number":66,"context_line":"        #         name\u003d{\u0027in\u0027: names}"},{"line_number":67,"context_line":"        #     )"},{"line_number":68,"context_line":"        # } if names else {}  # don\u0027t perform a db request if \u0027names\u0027 are empty"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        induced_state, _, _ \u003d self._get_induced_join_state("},{"line_number":71,"context_line":"            self.wf_spec.get_tasks()[t_ex_candidate.name],"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_347df97e","line":68,"in_reply_to":"9fb8cfa7_392c12ab","updated":"2019-06-10 09:49:42.000000000","message":"This code\u0027s removed with https://review.opendev.org/#/c/663856/, so it should be merged first","commit_id":"a7d392224242a0b09b1cc131fdf6ef6d7f7abb4c"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"79886c87f92c9418343e4198465f544fab90fb48","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.wf_spec.get_tasks()[t_ex_candidate.name],"},{"line_number":67,"context_line":"            t_ex_candidate,"},{"line_number":68,"context_line":"            t_spec,"},{"line_number":69,"context_line":"            {}"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return induced_state \u003d\u003d states.RUNNING"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_d4cedd2b","line":69,"updated":"2019-06-10 10:37:17.000000000","message":"Actaually we need t_execs_cache here. First, if you don\u0027t need it then why you create it on #63? Second, if you don\u0027t provide the cache here, it will be regenerated on #523 again.","commit_id":"93cd3362ac1d1b6f94c3bb3b8f68c1c864dabbc5"}]}