)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"01c8c36d6517db67597c05584fb158ce5eb0f9f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"932334d5_ba60abbf","updated":"2025-05-09 08:10:09.000000000","message":"@avanzaghi.osf@axellink.fr hello, please abandon this, outdate + not finished.","commit_id":"061ef3dd746e4ade5467477b1a19f576e2321e8e"}],"mistral/engine/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8bbfd483005901abef7398cbce32dc979911dc26","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                continue"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            t_name \u003d c.task_spec.get_name()"},{"line_number":279,"context_line":"            if self._is_conditional_transition(t_name):"},{"line_number":280,"context_line":"                event \u003d c.triggered_by[0][\u0027event\u0027] if c.triggered_by else None"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                self.task_ex.next_tasks.append((t_name, event))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3ceb8e13","line":279,"range":{"start_line":279,"start_character":20,"end_line":279,"end_character":46},"updated":"2019-06-11 03:44:34.000000000","message":"No-no, we shouldn\u0027t know about any transitions here in this class. It\u0027s too generic.","commit_id":"aca3e42248b102d59a96edb09486c63c24405100"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"8bbfd483005901abef7398cbce32dc979911dc26","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        self.task_ex.finished_at \u003d time"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def _is_conditional_transition(self, name):"},{"line_number":449,"context_line":"        if self.wf_spec.get_type() !\u003d \u0027direct\u0027:"},{"line_number":450,"context_line":"            return True"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        if self.task_ex.state \u003d\u003d states.ERROR:"},{"line_number":453,"context_line":"            for t_name, cond, _ in self.wf_spec.get_on_error_clause("},{"line_number":454,"context_line":"                    self.task_ex.name):"},{"line_number":455,"context_line":"                if cond and t_name \u003d\u003d name:"},{"line_number":456,"context_line":"                    return True"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if self.task_ex.state \u003d\u003d states.SUCCESS:"},{"line_number":459,"context_line":"            for t_name, cond, _ in self.wf_spec.get_on_success_clause("},{"line_number":460,"context_line":"                    self.task_ex.name):"},{"line_number":461,"context_line":"                if cond and t_name \u003d\u003d name:"},{"line_number":462,"context_line":"                    return True"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        for t_name, cond, _ in self.wf_spec.get_on_complete_clause("},{"line_number":465,"context_line":"                self.task_ex.name):"},{"line_number":466,"context_line":"            if cond and t_name \u003d\u003d name:"},{"line_number":467,"context_line":"                return True"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"        return False"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"class RegularTask(Task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7cb6e640","line":469,"range":{"start_line":449,"start_character":8,"end_line":469,"end_character":20},"updated":"2019-06-11 03:44:34.000000000","message":"Aaah.. All these things like \"direct\", the term \"conditional transition\", get_on_xxx_clause() should not be here. This class has no idea what type of workflow we\u0027re dealing with.\n\nI\u0027m ok with the idea of the patch itself, but please let\u0027s propose a better architecture.","commit_id":"aca3e42248b102d59a96edb09486c63c24405100"}]}
