)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a25bc437bea7a843810daa9d3c6cbc57f25c7af2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now it is possible to execute tasks in dry-run mode, so instead of \u0027run\u0027"},{"line_number":10,"context_line":"action method \u0027test\u0027 will be executed. It could be configured"},{"line_number":11,"context_line":"for a single task or for a whole workflow in task-defaults section."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9b50bb40d2f1fc883f32406f4bc11f03a15f0a70"},{"line_number":14,"context_line":"Implements: blueprint mistral-dry-run"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_987e6ce1","line":11,"updated":"2019-12-25 05:45:42.000000000","message":"For this kind of big new features, please let\u0027s provide more details on how to use it. In the commit message and docs, of course. For now, adding docs is a bit problematic because the structure is not clear enough to understand where to put this info into. But I\u0027d suggest we still write docs, even if we don\u0027t have a link to it from anywhere else for now.","commit_id":"97ed8d17f83cde476805c3c2b978a6e29cedc55f"}],"mistral/engine/actions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a25bc437bea7a843810daa9d3c6cbc57f25c7af2","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    @profiler.trace(\u0027action-schedule\u0027, hide_args\u003dTrue)"},{"line_number":240,"context_line":"    def schedule(self, input_dict, target, index\u003d0, desc\u003d\u0027\u0027, safe_rerun\u003dFalse,"},{"line_number":241,"context_line":"                 dry_run\u003dFalse, timeout\u003dNone):"},{"line_number":242,"context_line":"        assert not self.action_ex"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        self.validate_input(input_dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_784cd0c8","line":241,"range":{"start_line":241,"start_character":17,"end_line":241,"end_character":24},"updated":"2019-12-25 05:45:42.000000000","message":"Instead of passing this parameter everywhere, I guess we could just put a flag into the workflow environment. This would give as the opportunity to configure dry-run per workflow execution, not per workflow definition. Configuring it within a workflow text I believe is pretty useless because the value of this feature should be the ability to run any workflow (even not specifically written for that) in dry run.","commit_id":"97ed8d17f83cde476805c3c2b978a6e29cedc55f"}],"mistral/lang/v2/tasks.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a25bc437bea7a843810daa9d3c6cbc57f25c7af2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            \"target\": types.NONEMPTY_STRING,"},{"line_number":81,"context_line":"            \"keep-result\": types.EXPRESSION_OR_BOOLEAN,"},{"line_number":82,"context_line":"            \"safe-rerun\": types.EXPRESSION_OR_BOOLEAN,"},{"line_number":83,"context_line":"            \"dry-run\": types.EXPRESSION_OR_BOOLEAN"},{"line_number":84,"context_line":"        },"},{"line_number":85,"context_line":"        \"additionalProperties\": False,"},{"line_number":86,"context_line":"        \"anyOf\": ["}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_98574c5b","line":83,"range":{"start_line":83,"start_character":12,"end_line":83,"end_character":50},"updated":"2019-12-25 05:45:42.000000000","message":"No-no, dry-run should not be part of the language schema.","commit_id":"97ed8d17f83cde476805c3c2b978a6e29cedc55f"}],"mistral/tests/unit/engine/test_dry_run.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"a25bc437bea7a843810daa9d3c6cbc57f25c7af2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            res: \u003c% task(task1).result %\u003e"},{"line_number":55,"context_line":"          tasks:"},{"line_number":56,"context_line":"            task1:"},{"line_number":57,"context_line":"              dry-run: true"},{"line_number":58,"context_line":"              action: std.echo output\u003d\"kek\""},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_d85dc47c","line":57,"range":{"start_line":57,"start_character":14,"end_line":57,"end_character":27},"updated":"2019-12-25 05:45:42.000000000","message":"In my opinion, the fact that we use dry-run mode should not change the workflow language in any way. We should be able to run same workflows in normal mode and in dry-run. So dry-run is rather a runtime feature, not a language thing.","commit_id":"97ed8d17f83cde476805c3c2b978a6e29cedc55f"}]}
