)]}'
{"mistral/lang/base.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bae9d7cb43eb7b363655ab06de8d7ac38f7d8a86","unresolved":false,"context_lines":[{"line_number":53,"context_line":"PARAMS_PTRN \u003d re.compile(r\"([-_\\w]+)\u003d(%s)\" % \"|\".join(ALL))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# {(base_spec_cls, polymorphic_value): spec_cls}"},{"line_number":56,"context_line":"_POL_CACHE \u003d {}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@profiler.trace(\u0027lang-base-instantiate-spec\u0027, hide_args\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5faad753_ba52fe39","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":10},"updated":"2019-09-16 08:58:09.000000000","message":"Could be renamed to _POLIMORPHIC_CLS_CACHE or something similar? _POL in my reading immediately purported to refer to policy.\nAs this is a fairly large piece of code, it may be useful to refactor it into its own function. If this is done, then cachetools.func.lru_cache or any of its brothers can be used to do the trick.\nWhat do you think?","commit_id":"9562a58150797e14a17fe0cf34478bd114404f47"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"aedb666a0626bd66b2a085062a94e3062021b726","unresolved":false,"context_lines":[{"line_number":53,"context_line":"PARAMS_PTRN \u003d re.compile(r\"([-_\\w]+)\u003d(%s)\" % \"|\".join(ALL))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# {(base_spec_cls, polymorphic_value): spec_cls}"},{"line_number":56,"context_line":"_POL_CACHE \u003d {}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@profiler.trace(\u0027lang-base-instantiate-spec\u0027, hide_args\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_550d8b35","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":10},"in_reply_to":"5faad753_ba52fe39","updated":"2019-09-17 07:11:36.000000000","message":"Agree on the naming, yes. It\u0027s a little bit of my sloppiness.. I think it doesn\u0027t make sense though to use any cache lib just because this cache is not going to grow, it will have entries whose number is equal to the number of spec classes. So it will be 20-25 entries that can always be in memory.","commit_id":"9562a58150797e14a17fe0cf34478bd114404f47"}]}