)]}'
{"mistral/services/action_execution_reporter.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a661d6bb8c04daa33f2c67e9622b114b32e9040e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def add_action_ex_id(action_ex_id):"},{"line_number":36,"context_line":"    global _enabled"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # With run-action there is no actions_ex_id assigned."},{"line_number":39,"context_line":"    if action_ex_id and _enabled:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1d17c748","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":19},"updated":"2019-11-15 16:19:05.000000000","message":"having a class, even if only a single instance is instantiated (similarly to CONF) helps prevent adding these statements. start() and stop() can still be global methods but IMHO encapsulating the state into a class would be beneficial.","commit_id":"0e758e16e1abdb2440e28d270457f7329b876708"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a661d6bb8c04daa33f2c67e9622b114b32e9040e","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def remove_action_ex_id(action_ex_id):"},{"line_number":46,"context_line":"    global _enabled"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    if action_ex_id and _enabled:"},{"line_number":49,"context_line":"        _running_actions.discard(action_ex_id)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ba3a39e3","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":33},"updated":"2019-11-15 16:19:05.000000000","message":"protection is unnecessary as nothing happens if the item is not member of the set. This was an oversight in the original code too.","commit_id":"0e758e16e1abdb2440e28d270457f7329b876708"}]}