)]}'
{"mistral/api/controllers/v2/types.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"#    You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#        http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Unless required by applicable law or agreed to in writing, software"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_6b9d3957","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":1},"updated":"2019-12-17 08:43:48.000000000","message":"please update the (c)","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    name \u003d \u0027uuid\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def validate(data):"},{"line_number":81,"context_line":"        value \u003d data"},{"line_number":82,"context_line":"        if data.startswith(filter_utils.ALL):"},{"line_number":83,"context_line":"            _, value \u003d data.split(\u0027:\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_ab99f11e","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":21},"updated":"2019-12-17 08:43:48.000000000","message":"is there some particular reason for renaming the parameter? I believe, it\u0027s better to adhere to the existing pattern.","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def validate(data):"},{"line_number":81,"context_line":"        value \u003d data"},{"line_number":82,"context_line":"        if data.startswith(filter_utils.ALL):"},{"line_number":83,"context_line":"            _, value \u003d data.split(\u0027:\u0027, 1)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not uuidutils.is_uuid_like(value):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_eb9b6976","line":82,"range":{"start_line":82,"start_character":10,"end_line":82,"end_character":45},"updated":"2019-12-17 08:43:48.000000000","message":"please use the utility function you implemented","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"}],"mistral/tests/unit/actions/test_types.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    uuid_type \u003d types.uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_uuid_type(self):"},{"line_number":27,"context_line":"        self.uuid_type.validate(self.base_id)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_uuid_with_filters(self):"},{"line_number":30,"context_line":"        for filter_type in filter_utils.ALL:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_4b6f1d60","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":45},"updated":"2019-12-17 08:43:48.000000000","message":"please create a failing case too","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":30755,"name":"ali","email":"ali.abdelal@nokia.com","username":"abdelal"},"change_message_id":"3a61f4f9fc3c838b7f566624d0b6a13308d6ed14","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    uuid_type \u003d types.uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_uuid_type(self):"},{"line_number":27,"context_line":"        self.uuid_type.validate(self.base_id)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_uuid_with_filters(self):"},{"line_number":30,"context_line":"        for filter_type in filter_utils.ALL:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_aeac8d36","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":45},"in_reply_to":"3fa7e38b_4b6f1d60","updated":"2019-12-18 10:59:58.000000000","message":"there is already test_uuid_type_with_invalid_prefix \n\nor do you mean something else?","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"efad034ca510f989f96077849c6a46ebcaf0e75c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    uuid_type \u003d types.uuid"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_uuid_type(self):"},{"line_number":27,"context_line":"        self.uuid_type.validate(self.base_id)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_uuid_with_filters(self):"},{"line_number":30,"context_line":"        for filter_type in filter_utils.ALL:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_cf8f8374","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":45},"in_reply_to":"3fa7e38b_aeac8d36","updated":"2019-12-18 11:14:44.000000000","message":"there should be a test where the uuid is not an uuid but some text. this is to ensure that the format is also checked.","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"}],"mistral/utils/filter_utils.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3695ef37ecf71e815b63841603bb43234722ad5f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"IN \u003d \u0027in:\u0027"},{"line_number":24,"context_line":"NOT_IN \u003d \u0027nin:\u0027"},{"line_number":25,"context_line":"HAS \u003d \u0027has:\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ALL_FILTERS \u003d (GREATER_THAN_EQUALS, GREATER_THAN,"},{"line_number":28,"context_line":"               LESS_THAN_EQUALS, HAS, NOT_EQUAL,"},{"line_number":29,"context_line":"               LESS_THAN, IN, EQUALS, NOT_IN)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_044dabc4","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":11},"updated":"2019-12-16 04:18:17.000000000","message":"Soft: According to the Python tradition, it can be called just ALL. But, IMO, it\u0027s not so critical.","commit_id":"8238c645e3e2a275c18efb19b9e42e44a87ac935"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"3695ef37ecf71e815b63841603bb43234722ad5f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d \u0027eq\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    return filter_type, value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_64c1fffd","line":90,"range":{"start_line":90,"start_character":22,"end_line":90,"end_character":26},"updated":"2019-12-16 04:18:17.000000000","message":"Replace with EQUALS","commit_id":"8238c645e3e2a275c18efb19b9e42e44a87ac935"},{"author":{"_account_id":30755,"name":"ali","email":"ali.abdelal@nokia.com","username":"abdelal"},"change_message_id":"6479941b2b9fef00e8e1702cbe21a61acad7d0ad","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d \u0027eq\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    return filter_type, value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1a33c2f9","line":90,"range":{"start_line":90,"start_character":22,"end_line":90,"end_character":26},"in_reply_to":"3fa7e38b_3a031e0f","updated":"2019-12-16 07:54:02.000000000","message":"we need to check for the filter + \":\" not just here but also in the types, also removing \":\" is much easier than adding it to all filters, and then we would need to add it in the above \"if\" for all of them.","commit_id":"8238c645e3e2a275c18efb19b9e42e44a87ac935"},{"author":{"_account_id":30755,"name":"ali","email":"ali.abdelal@nokia.com","username":"abdelal"},"change_message_id":"220bc3e1bae87ee2cd49357243132078158dde0a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d \u0027eq\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    return filter_type, value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7f142851","line":90,"range":{"start_line":90,"start_character":22,"end_line":90,"end_character":26},"in_reply_to":"3fa7e38b_64c1fffd","updated":"2019-12-16 07:44:13.000000000","message":"\"EQUALS\"\u003d \"eq:\" not \"eq\"","commit_id":"8238c645e3e2a275c18efb19b9e42e44a87ac935"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"84a01d102693f9230dc32db2e7b0fded6e0d95da","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d \u0027eq\u0027"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    return filter_type, value"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3a031e0f","line":90,"range":{"start_line":90,"start_character":22,"end_line":90,"end_character":26},"in_reply_to":"3fa7e38b_7f142851","updated":"2019-12-16 07:50:21.000000000","message":"Ok, understood. But since we introduced a constant for \"eq\" let\u0027s use it here anyway. The idea is to not rely on raw string values as much as possible, it will improve flexibility and make it easier to refactor code.\n\nfilter_type \u003d EQUALS.split(\u0027:\u0027, 1)\n\nOr perhaps it would be even better to not include a colon (\":\") into the constant values. We know that it\u0027s supposed to be included anyway.","commit_id":"8238c645e3e2a275c18efb19b9e42e44a87ac935"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"EQUALS \u003d \u0027eq:\u0027"},{"line_number":18,"context_line":"NOT_EQUAL \u003d \u0027neq:\u0027"},{"line_number":19,"context_line":"LESS_THAN \u003d \u0027lt:\u0027"},{"line_number":20,"context_line":"LESS_THAN_EQUALS \u003d \u0027lte:\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_cbb54def","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":14},"updated":"2019-12-17 08:43:48.000000000","message":"values should be without the colon","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    return _filter"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"def _extract_filter_type_and_value(data):"},{"line_number":76,"context_line":"    \"\"\"Extract filter type and its value from the data."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    :param data: REST parameter value from which filter type and"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_2bc42160","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":34},"updated":"2019-12-17 08:43:48.000000000","message":"would be better made a public method","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        filter_type, value \u003d data.split(\u0027:\u0027, 1)"},{"line_number":85,"context_line":"        value \u003d six.text_type(value)"},{"line_number":86,"context_line":"        if data.startswith((IN, NOT_IN)):"},{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d EQUALS.replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_4b8abdbc","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":41},"updated":"2019-12-17 08:43:48.000000000","message":"please add test for this branch too","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"bc84ee12bcd471910e50788b430b871603ee3629","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            value \u003d list(value.split(\",\"))"},{"line_number":88,"context_line":"    else:"},{"line_number":89,"context_line":"        value \u003d data"},{"line_number":90,"context_line":"        filter_type \u003d EQUALS.replace(\u0027:\u0027, \u0027\u0027)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    return filter_type, value"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_6bca1970","line":90,"range":{"start_line":90,"start_character":22,"end_line":90,"end_character":45},"updated":"2019-12-17 08:43:48.000000000","message":"this is weird :)","commit_id":"9af29540e876a267528c26aae6fa91534a10fd48"}]}