)]}'
{"mistral/api/app.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"4d4b0ebd02163cc9ca45bfd7f155b7a011aa3e77","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"eventlet.monkey_patch()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"import oslo_middleware.cors as cors_middleware"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_98fbcc79","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"updated":"2019-12-25 04:56:45.000000000","message":"Why do we need monkey_patch here? Why w/o any parameters?","commit_id":"f067fd459bfdea02d5634542f71f236239f2304f"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"d2965937230a84dc786c112b089722904d45bb3e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"#    limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"eventlet.monkey_patch()"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"import oslo_middleware.cors as cors_middleware"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_93040d16","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":23},"in_reply_to":"3fa7e38b_98fbcc79","updated":"2019-12-25 07:55:07.000000000","message":"without monkey patch we get eventlet exception since etcd uses blocking methods. I use without parameters because the deafult is fine","commit_id":"f067fd459bfdea02d5634542f71f236239f2304f"}],"mistral/event_engine/event_engine_server.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"4d4b0ebd02163cc9ca45bfd7f155b7a011aa3e77","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, event_engine):"},{"line_number":38,"context_line":"        super(EventEngineServer, self).__init__(\u0027event-engine_group\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._event_engine \u003d event_engine"},{"line_number":41,"context_line":"        self._rpc_server \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b8fec867","line":38,"range":{"start_line":38,"start_character":54,"end_line":38,"end_character":55},"updated":"2019-12-25 04:56:45.000000000","message":"Why did you change this? Now it doesn\u0027t look consistent with one dash and one underscore.","commit_id":"f067fd459bfdea02d5634542f71f236239f2304f"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"d2965937230a84dc786c112b089722904d45bb3e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, event_engine):"},{"line_number":38,"context_line":"        super(EventEngineServer, self).__init__(\u0027event-engine_group\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self._event_engine \u003d event_engine"},{"line_number":41,"context_line":"        self._rpc_server \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_530e9533","line":38,"range":{"start_line":38,"start_character":54,"end_line":38,"end_character":55},"in_reply_to":"3fa7e38b_b8fec867","updated":"2019-12-25 07:55:07.000000000","message":"this must be consistent with the LAUNCH_OPTIONS parameter in launch.py in the cmd module otherwise this service wont be identified","commit_id":"f067fd459bfdea02d5634542f71f236239f2304f"}],"mistral/service/coordination.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"4d4b0ebd02163cc9ca45bfd7f155b7a011aa3e77","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_concurrency import lockutils"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_service import threadgroup"},{"line_number":21,"context_line":"import tenacity"},{"line_number":22,"context_line":"import tooz.coordination"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_38ead89f","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":36},"updated":"2019-12-25 04:56:45.000000000","message":"There\u0027s a lot of not so trivial changes in this module. Can you please provide brief info in the commit message what exactly this patch fixes? 3-4 simple phrases.","commit_id":"541aabbfe8a7afd876adcfb209d18aafdef2d5f6"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"d2965937230a84dc786c112b089722904d45bb3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_concurrency import lockutils"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_service import threadgroup"},{"line_number":21,"context_line":"import tenacity"},{"line_number":22,"context_line":"import tooz.coordination"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_73095127","side":"PARENT","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":36},"in_reply_to":"3fa7e38b_38ead89f","updated":"2019-12-25 07:55:07.000000000","message":"ok","commit_id":"541aabbfe8a7afd876adcfb209d18aafdef2d5f6"}]}