)]}'
{"mistral/api/controllers/v2/sub_executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 - Nokia Networks."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ce465e7f","line":1,"updated":"2020-01-21 05:12:41.000000000","message":"Notice that all names of the controller modules are singular. Please also make this one sub_execution.py.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def get_task_sub_executions_list(task_ex_id, filters, cur_depth):"},{"line_number":30,"context_line":"    task_sub_executions \u003d []"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    with db_api.transaction():"},{"line_number":33,"context_line":"        task_ex \u003d db_api.get_task_execution(task_ex_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8e406661","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":23},"updated":"2020-01-21 05:12:41.000000000","message":"soft: could be shortened to execs. This is a local variable within a narrow scope (less than a page) so a shorter name is totally ok here. It\u0027s up to you though if you wanna fix it or not. It\u0027s a soft comment.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    with db_api.transaction():"},{"line_number":33,"context_line":"        task_ex \u003d db_api.get_task_execution(task_ex_id)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        if filters[\u0027errors_only\u0027] and task_ex.state !\u003d states.ERROR:"},{"line_number":36,"context_line":"            return []"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        child_wf_executions \u003d task_ex.workflow_executions"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ae43e26a","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":32},"updated":"2020-01-21 05:12:41.000000000","message":"Not a problem of this patch but just a note for further considerations: we need to stop using hardcoded strings completely and switch to constants. At some point I\u0027d like to make total refactoring across the code and fix it.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\"Return workflow execution report."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        :param id: The ID of the workflow execution or task execution"},{"line_number":105,"context_line":"         to get the sub-executions of."},{"line_number":106,"context_line":"        :param errors_only: Optional. If True, only error paths of the"},{"line_number":107,"context_line":"            execution tree are returned ."},{"line_number":108,"context_line":"        :param max_depth: Optional. Limits the depth of recursion while"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4e5a6e51","line":105,"updated":"2020-01-21 05:12:41.000000000","message":"Wrong indent, please make it 4 chars from the beginning of the previous line.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":"        origin \u003d \u0027execution\u0027 if request.path.startswith(\u0027/v2/executions\u0027) \\"},{"line_number":115,"context_line":"            else \u0027task\u0027"},{"line_number":116,"context_line":"        LOG.info("},{"line_number":117,"context_line":"            \"Fetching sub executions of %s [id\u003d%s]\","},{"line_number":118,"context_line":"            origin,"},{"line_number":119,"context_line":"            id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2e4ff28c","line":116,"updated":"2020-01-21 05:12:41.000000000","message":"Please separate LOG.info() with blank lines because it\u0027s not related with the enclosing code lines.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"}],"mistral/tests/unit/api/v2/test_sub_executions.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(TestSubExecutionsController, self).setUp()"},{"line_number":46,"context_line":"        wf_service.create_workflows(WF_TEXT)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sub_executions_wf_id(self):"},{"line_number":49,"context_line":"        wf_ex \u003d self.engine.start_workflow(\u0027main_wf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ee2ebaa8","line":46,"updated":"2020-01-21 05:12:41.000000000","message":"Put a blank line after super()","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self._assert_single_item(main_wf_ex_list, workflow_name\u003d\u0027main_wf\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def test_sub_executions_task_id(self):"},{"line_number":109,"context_line":"    wf_ex \u003d self.engine.start_workflow(\u0027main_wf\u0027)"},{"line_number":110,"context_line":"    self.await_workflow_error(wf_ex.id)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8e35c6f8","line":108,"range":{"start_line":108,"start_character":4,"end_line":108,"end_character":31},"updated":"2020-01-21 05:12:41.000000000","message":"Seems like this method has the wrong ident and hence doesn\u0027t belong to the test case class.","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    self._assert_single_item(main_task_ex_list, workflow_name\u003d\u0027action_wf\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def test_sub_executions_with_include_output(self):"},{"line_number":139,"context_line":"    wf_ex \u003d self.engine.start_workflow(\u0027main_wf\u0027)"},{"line_number":140,"context_line":"    self.await_workflow_error(wf_ex.id)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ae38c2ec","line":138,"range":{"start_line":138,"start_character":4,"end_line":138,"end_character":43},"updated":"2020-01-21 05:12:41.000000000","message":"same here","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"05ec5634f48ef8f75cc747479485b5834a6693b7","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    self.assertEqual(200, resp.status_int)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    main_wf \u003d self._assert_single_item(resp.json[\u0027executions\u0027],"},{"line_number":155,"context_line":"                                       workflow_name\u003d\u0027main_wf\u0027"},{"line_number":156,"context_line":"                                       )"},{"line_number":157,"context_line":"    self.assertIsNone(main_wf.get(\u0027output\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0e29d69a","line":156,"range":{"start_line":154,"start_character":4,"end_line":156,"end_character":40},"updated":"2020-01-21 05:12:41.000000000","message":"Please find all multiline calls and format them as described at https://docs.openstack.org/mistral/latest/contributor/coding_guidelines.html#id15","commit_id":"bbe93aafd8d4c73f21250f2ea10be8c826ff9b40"}]}