)]}'
{"mistral/tests/unit/engine/test_direct_workflow.py":[{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0363d30e3521fcb4c42f9a03ccbe70a0a9b50a43","unresolved":false,"context_lines":[{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        self.await_workflow_success(wf_ex.id)"},{"line_number":1142,"context_line":""},{"line_number":1143,"context_line":"    def test_indirectly_affected_task_search(self):"},{"line_number":1144,"context_line":"        wf_text \u003d \"\"\"---"},{"line_number":1145,"context_line":"        version: \u00272.0\u0027"},{"line_number":1146,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_9437e9ff","line":1143,"range":{"start_line":1143,"start_character":8,"end_line":1143,"end_character":44},"updated":"2020-03-05 05:03:39.000000000","message":"Honestly, I don\u0027t understand the idea of this test. The first thing that bothers me is that it\u0027s named after an internal method that can change any time and in general can be removed later if we are able to come up with a different solution for \"join\". If it was a direct test for the method \"find_indirectly_affected_task\" then it would be OK, I would understand that. But here you mention the name of the method and the test body, in fact, has nothing to do with it. Of course, I understand the relationship exists, but it\u0027s really not obvious at all.\n\nAlso, I don\u0027t see it\u0027s related to \"join, whereas it should be because this algorigthm is not needed w/o join.\n\nMy suggestion is to rewrite the test so that it:\n\n* Uses \"join\" explicitly\n* Shows a situation when \"join\" doesn\u0027t work properly w/o a proper fix","commit_id":"32f5edb70193aa02c78b9951793b5521638ed483"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"0363d30e3521fcb4c42f9a03ccbe70a0a9b50a43","unresolved":false,"context_lines":[{"line_number":1158,"context_line":"            branch2-3_merge:"},{"line_number":1159,"context_line":"              action: std.noop"},{"line_number":1160,"context_line":"              on-success: branch1-23_merge"},{"line_number":1161,"context_line":"            branch1-23_merge:"},{"line_number":1162,"context_line":"              action: std.noop"},{"line_number":1163,"context_line":"        \"\"\""},{"line_number":1164,"context_line":""},{"line_number":1165,"context_line":"        wf_service.create_workflows(wf_text)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_744d8d98","line":1162,"range":{"start_line":1161,"start_character":12,"end_line":1162,"end_character":30},"updated":"2020-03-05 05:03:39.000000000","message":"Is it supposed to be \"join\"?","commit_id":"32f5edb70193aa02c78b9951793b5521638ed483"}]}