)]}'
{"mistral/tests/unit/engine/test_disabled_yaql_conversion.py":[{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"93958600f127ab4eca799bad5ead725a71b238f7","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        wf_service.create_workflows(wf_text)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # Start workflow."},{"line_number":43,"context_line":"        wf_ex \u003d self.engine.start_workflow(\u0027wf\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.await_workflow_success(wf_ex.id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_d688f3c4","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":25},"updated":"2020-02-12 07:41:56.000000000","message":"nit: I think this comment is redundant the method speaks for itself","commit_id":"dfdda87a3107cfe946ac4e44eb8aab0b555f34a7"}],"mistral/tests/unit/expressions/test_yaql_expression.py":[{"author":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"change_message_id":"a74367dd7954aae0f8e7a5b4cad904c54e788b28","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def test_set_of_dicts(self):"},{"line_number":330,"context_line":"        # This test makes sense only if YAQL expression output conversion"},{"line_number":331,"context_line":"        # is enabled."},{"line_number":332,"context_line":"        self.override_config(\u0027convert_output_data\u0027, True, \u0027yaql\u0027)"},{"line_number":333,"context_line":"        self.override_config(\u0027convert_sets_to_lists\u0027, True, \u0027yaql\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        def _restore_engine(old_engine):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_dd96bda0","line":332,"updated":"2020-02-13 09:28:26.000000000","message":"I think it is redundant, your defaut value is now True","commit_id":"8b4edf93b4e3a4e11c5ed72399bbac347c6d3f5a"},{"author":{"_account_id":8731,"name":"Renat Akhmerov","email":"renat.akhmerov@gmail.com","username":"rakhmerov"},"change_message_id":"5d53de2284f4930696adea21ac3d97d8bd2d9883","unresolved":false,"context_lines":[{"line_number":329,"context_line":"    def test_set_of_dicts(self):"},{"line_number":330,"context_line":"        # This test makes sense only if YAQL expression output conversion"},{"line_number":331,"context_line":"        # is enabled."},{"line_number":332,"context_line":"        self.override_config(\u0027convert_output_data\u0027, True, \u0027yaql\u0027)"},{"line_number":333,"context_line":"        self.override_config(\u0027convert_sets_to_lists\u0027, True, \u0027yaql\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        def _restore_engine(old_engine):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_a8a94178","line":332,"in_reply_to":"3fa7e38b_dd96bda0","updated":"2020-02-13 10:30:45.000000000","message":"The default value may change and the test won\u0027t know about it :) That\u0027s why it\u0027s better to decouple it from the default values and set what this test really expects. In case if the default value changes and the test still works, it can even hide the bug in the code.","commit_id":"8b4edf93b4e3a4e11c5ed72399bbac347c6d3f5a"}]}