)]}'
{"mistral/config.py":[{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"e49d2f1f6bd1ecb9a4155d53cda16a0f480e19a3","unresolved":false,"context_lines":[{"line_number":679,"context_line":""},{"line_number":680,"context_line":"auth_endpoint_definition \u003d ["},{"line_number":681,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027, default\u003d\u0027admin\u0027,"},{"line_number":682,"context_line":"               help\u003d\u0027Interface to define authentication endpoint.\u0027),"},{"line_number":683,"context_line":"    cfg.StrOpt(\u0027region_name\u0027, default\u003dNone,"},{"line_number":684,"context_line":"               help\u003d\u0027Region name to define authentication endpoint.\u0027)"},{"line_number":685,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9d0fd089","line":682,"updated":"2020-02-14 10:13:41.000000000","message":"Endpoint type in Identity service catalog to use for communication with the OpenStack Keystone service.","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"e49d2f1f6bd1ecb9a4155d53cda16a0f480e19a3","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    cfg.StrOpt(\u0027endpoint_type\u0027, default\u003d\u0027admin\u0027,"},{"line_number":682,"context_line":"               help\u003d\u0027Interface to define authentication endpoint.\u0027),"},{"line_number":683,"context_line":"    cfg.StrOpt(\u0027region_name\u0027, default\u003dNone,"},{"line_number":684,"context_line":"               help\u003d\u0027Region name to define authentication endpoint.\u0027)"},{"line_number":685,"context_line":"]"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5d05d866","line":684,"updated":"2020-02-14 10:13:41.000000000","message":"Region in Identity service catalog to use for communication with the OpenStack Keystone service","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"0364cc479b4fc5f6ca8ecae27f343baa221b4d0e","unresolved":false,"context_lines":[{"line_number":679,"context_line":""},{"line_number":680,"context_line":"auth_endpoint_definition \u003d ["},{"line_number":681,"context_line":"    cfg.StrOpt(\u0027interface\u0027, default\u003d\u0027admin\u0027,"},{"line_number":682,"context_line":"               help\u003d\u0027Region in Identity service catalog to use for \u0027"},{"line_number":683,"context_line":"                    \u0027communication with the OpenStack Keystone service.\u0027)"},{"line_number":684,"context_line":"]"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_2d77553d","line":683,"range":{"start_line":682,"start_character":21,"end_line":683,"end_character":71},"updated":"2020-02-25 13:53:59.000000000","message":"The doc is not for this option, I guess. But other than that, do we include this to ensure that it is always present even if deprecated in KS?","commit_id":"60511fc6ee5f874ddb90de1cc98b5ff5646e06cf"}],"mistral/utils/openstack/keystone.py":[{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"eb91460ba1825a8e453fa4b77ce3450b5fe872d3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        sess \u003d loading.load_session_from_conf_options("},{"line_number":135,"context_line":"            CONF,"},{"line_number":136,"context_line":"            \u0027keystone\u0027,"},{"line_number":137,"context_line":"            auth\u003dauth"},{"line_number":138,"context_line":"        )"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e58b8d13","line":136,"updated":"2020-02-19 08:53:22.000000000","message":"As mentioned in the Ie3ab512b0ab42c0f97b3099e0787f4edee08ddce :\n[keystone_authtoken] group is used for keystonemiddleware to validating\ntoken.\nThe new [keystone] group is used for keystoneauth to initialization\nthe keystone session.\n\nSo by this logic for the keystoneclient below used by the Mistral to validate trust tokens should use config from the [keystone] section.","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"},{"author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"change_message_id":"bd96088e37203058e384e661bf9fc1ff328d4525","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        sess \u003d loading.load_session_from_conf_options("},{"line_number":135,"context_line":"            CONF,"},{"line_number":136,"context_line":"            \u0027keystone\u0027,"},{"line_number":137,"context_line":"            auth\u003dauth"},{"line_number":138,"context_line":"        )"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c042f80e","line":136,"in_reply_to":"3fa7e38b_4557012a","updated":"2020-02-19 15:23:59.000000000","message":"I\u0027m not sure if `interface` option from the [keystone_authtoken] could be used here. It\u0027s marked as deprecated: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/adapter.py#L45\n\nAnd keystoneclient doesn\u0027t support valid_interfaces list option.","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"f0264b584c09cf5d3b8abace6c913d0007a20489","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        sess \u003d loading.load_session_from_conf_options("},{"line_number":135,"context_line":"            CONF,"},{"line_number":136,"context_line":"            \u0027keystone\u0027,"},{"line_number":137,"context_line":"            auth\u003dauth"},{"line_number":138,"context_line":"        )"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4b4060a4","line":136,"in_reply_to":"3fa7e38b_c042f80e","updated":"2020-02-20 07:02:01.000000000","message":"I\u0027d still rather avoid adding redundant config options. Can you please check how the valid_interfaces could/should be used in this case? Or we can, I guess safely, bet on using the existing interface option too. It has been deprecated for 3 years and I highly doubt it will go away any soon.","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"},{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"a6446f77e0f214e7a500345606aa96237d067d0d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        sess \u003d loading.load_session_from_conf_options("},{"line_number":135,"context_line":"            CONF,"},{"line_number":136,"context_line":"            \u0027keystone\u0027,"},{"line_number":137,"context_line":"            auth\u003dauth"},{"line_number":138,"context_line":"        )"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4557012a","line":136,"in_reply_to":"3fa7e38b_e58b8d13","updated":"2020-02-19 09:17:32.000000000","message":"Unfortunately keystone_authtoken contains pretty much all parameters possible, including some that pertain to the session. In fact, this is not even the session but the client\u0027s parameters. Maybe the original intent was a little overengineered in the end.\nAs the keystone_authtoken is a quasi standard group, I believe it is best to use the value from there. E.g. what do we actually do with the values set there if we add them to the keystone group?","commit_id":"f91a9421687408fa1aa916ab626a21827525a433"}]}