)]}'
{"id":"openstack%2Fmistral~873023","triplet_id":"openstack%2Fmistral~master~I03f675903583603be7b68807f4c127d66888434f","project":"openstack/mistral","branch":"master","topic":"fix-mistral-spec-action-definition-upstream","attention_set":{},"removed_from_attention_set":{"28356":{"account":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"last_update":"2023-02-09 12:00:32.000000000","reason":"\u003cGERRIT_ACCOUNT_28356\u003e replied on the change","reason_account":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"}}},"hashtags":[],"change_id":"I03f675903583603be7b68807f4c127d66888434f","subject":"Fix issue when spec_dict is None","status":"ABANDONED","created":"2023-02-07 20:11:13.000000000","updated":"2023-02-09 12:00:44.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9e425f0411971aea0eeb1fabf6276814ac9b0e35","_number":873023,"virtual_id_number":873023,"owner":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},{"tag":"autogenerated:zuul:check","value":1,"date":"2023-02-08 02:03:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"all":[{"value":2,"date":"2023-02-09 11:39:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-02-07 22:22:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-02-09 11:39:30.000000000","updated_by":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"reviewer":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"state":"REVIEWER"}],"messages":[{"id":"8e9f3cdc00a297dfc17e9cea1936ffcdc553fe48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-07 20:11:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3db4d06e3f5a273d7bf61e97d2cdc34ed020910e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-07 20:12:15.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2629828c554ddbd4f310b4163126cb6805a4a39b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-07 20:13:16.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"e107999addc14ad46d3ac227084b980d4587b933","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-07 22:22:11.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/6cb6d186f3264922a25c48eaff667040\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6f5d5eba9b75402fb4e64a27493c6f1a : SUCCESS in 4m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2e64ec215ded476cacd27ae07006c4d2 : SUCCESS in 10m 25s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/467aa49bdf9c4eed93eb53d4207b3250 : SUCCESS in 8m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5971e681787c4e3a934c678f68ba0cdc : SUCCESS in 7m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bfaad76abadd4b6ab8fa84e3a00bb2e1 : SUCCESS in 11m 23s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/a377568c99ca4a4f9a2642b9f3b5765c : SUCCESS in 45m 53s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/295d0b97fcf9414dad0a2586fc0203d7 : SUCCESS in 36m 09s\n- mistral-devstack-non-apache-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1d26bcf5b0114669bf4ac6cafb8b09b5 : SUCCESS in 47m 35s\n- mistral-devstack-non-apache https://zuul.opendev.org/t/openstack/build/e564f274bb61432fbd4ab752493969a0 : SUCCESS in 31m 43s\n- mistral-devstack-kombu https://zuul.opendev.org/t/openstack/build/d06c7e2c6bdc4aeb89d78ba31f96b192 : SUCCESS in 34m 17s\n- mistral-tox-unit-mysql https://zuul.opendev.org/t/openstack/build/3f93366abcbd4840b6291480d4ea7782 : FAILURE in 33m 42s\n- mistral-tox-unit-postgresql https://zuul.opendev.org/t/openstack/build/361de21cb9a14b5cb77e4dee7712a8cf : SUCCESS in 30m 41s\n- mistral-rally-task https://zuul.opendev.org/t/openstack/build/6d5405998142452aae7ea5504b967e50 : TIMED_OUT in 2h 03m 08s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"07a20b54339e3dca79a114979d6221a3add6d19c","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-07 23:39:50.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"73acd35bc73b9c3201955e8fe57a54412b51b6d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-02-08 02:03:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1cda8323379b459a9a8de2af90a57a67\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f9f88656ffb740c79c60c01b13f5c628 : SUCCESS in 4m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0945bcf90f16422987a8813fcc305f1e : SUCCESS in 8m 43s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/6c82556576704a6387e257c6d2945e58 : SUCCESS in 8m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/837645133b244de1ad561ab5a82a98b9 : SUCCESS in 7m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7354a94b912c40a783d9fb15317ae9d4 : SUCCESS in 9m 57s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/1835183c4c60437db79af99a8a8cdb86 : SUCCESS in 26m 29s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/86d9b830cdae4e38bb81baa5e848ca63 : SUCCESS in 50m 37s\n- mistral-devstack-non-apache-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6f925eb9c4474cd2b9e732020dcd3bd7 : SUCCESS in 32m 44s\n- mistral-devstack-non-apache https://zuul.opendev.org/t/openstack/build/696bc50ef90d468b98dfb04b4dbfdef8 : SUCCESS in 51m 59s\n- mistral-devstack-kombu https://zuul.opendev.org/t/openstack/build/1e88a8759f4c488abd4511dada9319b8 : SUCCESS in 25m 57s\n- mistral-tox-unit-mysql https://zuul.opendev.org/t/openstack/build/ed0fd26ff74f4f27bd5d711d9cfbd34f : SUCCESS in 34m 02s\n- mistral-tox-unit-postgresql https://zuul.opendev.org/t/openstack/build/8afaebdaf5fd4821817207b9aa47ecb5 : SUCCESS in 37m 17s\n- mistral-rally-task https://zuul.opendev.org/t/openstack/build/77efd7f294e24d499c6766469bb598d2 : TIMED_OUT in 2h 03m 50s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4273e9c77542783826e9ccac522cafca29165833","author":{"_account_id":29124,"name":"Oleg Ovcharuk","email":"vgvoleg@gmail.com","username":"vgvoleg"},"date":"2023-02-09 11:39:30.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"18fa2465a6b9859e910d15eb310677f44c6c4e8c","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-09 12:00:32.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"9e425f0411971aea0eeb1fabf6276814ac9b0e35","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"date":"2023-02-09 12:00:44.000000000","message":"Abandoned\n\nWould not work","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8ca56384eaee85f926d2b85d842865340979d760","revisions":{"692601b66222cd2a93627f2130c0acc81d993952":{"kind":"REWORK","_number":1,"created":"2023-02-07 20:11:13.000000000","uploader":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"ref":"refs/changes/23/873023/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/23/873023/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/23/873023/1"}}},"commit":{"parents":[{"commit":"7c35734300d5d700928ebdf2315e392004121f39","subject":"Merge mistral tasks data to execution context","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/7c35734300d5d700928ebdf2315e392004121f39"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:08:00.000000000","tz":-180},"committer":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:11:09.000000000","tz":-180},"subject":"Fix issue when spec_dict is None","message":"Fix issue when spec_dict is None\n\nWhen migrating from older version of Mistral, the ``spec_dict`` is set as\n``Null`` in the database. This causes an error when checking if ``version``\nattribute is in the dictionary. To address such situations without needing\nto destroy and recreate the DB, we propose to amend the code to handle\nsuch situations, and use the default version when there is no ``spec_dict``.\n\nChange-Id: I03f675903583603be7b68807f4c127d66888434f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/692601b66222cd2a93627f2130c0acc81d993952"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/692601b66222cd2a93627f2130c0acc81d993952"}]},"branch":"refs/heads/master"},"5d380b16bf5900805bf297eddd467bdf7468e964":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-02-07 20:12:15.000000000","uploader":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"ref":"refs/changes/23/873023/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/23/873023/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/23/873023/2"}}},"commit":{"parents":[{"commit":"7c35734300d5d700928ebdf2315e392004121f39","subject":"Merge mistral tasks data to execution context","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/7c35734300d5d700928ebdf2315e392004121f39"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:08:00.000000000","tz":-180},"committer":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:11:33.000000000","tz":-180},"subject":"Fix issue when spec_dict is None","message":"Fix issue when spec_dict is None\n\nWhen migrating from older version of Mistral, the ``spec_dict`` is set as\n``Null`` in the database. This causes an error when checking if ``version``\nattribute is in the dictionary. To address such situations without needing\nto destroy and recreate the DB, we propose to amend the code to handle\nsuch situations, and use the default version when there is no ``spec_dict``.\n\nWithout this patch, one would see the following error:\n```\nServer-side error: \"argument of type \u0027NoneType\u0027 is not\niterable\". Detail:\n\nTraceback (most recent call last):\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/wsmeext/pecan.py\",\nline 82, in callfunction\n    result \u003d f(self, *args, **kwargs)\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/api/controllers/v2/action.py\",\nline 310, in get_all\n    action_descriptors \u003d rest_utils.rest_retry_on_db_error(\n[...]\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/actions/adhoc.py\",\nline 104, in __init__\n    self._spec \u003d spec_parser.get_action_spec(action_def.spec)\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/lang/parser.py\",\nline 97, in get_action_spec\n    if _get_spec_version(spec_dict) \u003d\u003d V2_0:\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/lang/parser.py\",\nline 64, in _get_spec_version\n    if \u0027version\u0027 in spec_dict:\n\nTypeError: argument of type \u0027NoneType\u0027 is not iterable\n```\n\nChange-Id: I03f675903583603be7b68807f4c127d66888434f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/5d380b16bf5900805bf297eddd467bdf7468e964"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/5d380b16bf5900805bf297eddd467bdf7468e964"}]},"branch":"refs/heads/master"},"8ca56384eaee85f926d2b85d842865340979d760":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-02-07 20:13:16.000000000","uploader":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"ref":"refs/changes/23/873023/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/23/873023/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/23/873023/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/23/873023/3"}}},"commit":{"parents":[{"commit":"7c35734300d5d700928ebdf2315e392004121f39","subject":"Merge mistral tasks data to execution context","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/7c35734300d5d700928ebdf2315e392004121f39"}]}],"author":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:08:00.000000000","tz":-180},"committer":{"name":"Rafael Weingärtner","email":"rafael@apache.org","date":"2023-02-07 20:12:36.000000000","tz":-180},"subject":"Fix issue when spec_dict is None","message":"Fix issue when spec_dict is None\n\nWhen migrating from older version of Mistral, the ``spec_dict`` is\nset as ``Null`` in the database. This causes an error when checking\nif ``version`` attribute is in the dictionary. To address such\nsituations without needing to destroy and recreate the DB, we\npropose to amend the code to handle such situations, and use the\ndefault version when there is no ``spec_dict``.\n\nWithout this patch, one would see the following error:\n```\nServer-side error: \"argument of type \u0027NoneType\u0027 is not\niterable\". Detail:\n\nTraceback (most recent call last):\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/wsmeext/pecan.py\",\nline 82, in callfunction\n    result \u003d f(self, *args, **kwargs)\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/api/controllers/v2/action.py\",\nline 310, in get_all\n    action_descriptors \u003d rest_utils.rest_retry_on_db_error(\n[...]\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/actions/adhoc.py\",\nline 104, in __init__\n    self._spec \u003d spec_parser.get_action_spec(action_def.spec)\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/lang/parser.py\",\nline 97, in get_action_spec\n    if _get_spec_version(spec_dict) \u003d\u003d V2_0:\n\n  File\n\"/var/lib/kolla/venv/lib/python3.10/site-packages/mistral/lang/parser.py\",\nline 64, in _get_spec_version\n    if \u0027version\u0027 in spec_dict:\n\nTypeError: argument of type \u0027NoneType\u0027 is not iterable\n```\n\nChange-Id: I03f675903583603be7b68807f4c127d66888434f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/8ca56384eaee85f926d2b85d842865340979d760"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/8ca56384eaee85f926d2b85d842865340979d760"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}