)]}'
{"id":"openstack%2Fmistral~962133","triplet_id":"openstack%2Fmistral~stable%2F2025.2~I51f4128dd023846a4406cd1b414a56d741035483","project":"openstack/mistral","branch":"stable/2025.2","hashtags":[],"change_id":"I51f4128dd023846a4406cd1b414a56d741035483","subject":"Do not call setup_db from engine","status":"MERGED","created":"2025-09-23 19:43:08.000000000","updated":"2025-09-24 21:39:41.000000000","submitted":"2025-09-24 21:38:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"962133","cherry_pick_of_change":962032,"cherry_pick_of_patch_set":2,"meta_rev_id":"d69d6ee2f6c1f8ca0bde9abf68c8d69bd7e120ea","_number":962133,"virtual_id_number":962133,"owner":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-09-24 21:38:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-09-24 20:43:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-09-24 20:43:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-23 20:02:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b25ed7b9ac50d9424c37823ae692f898fb0b099a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2025-09-23 19:43:08.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ad42c4f0e8c7e8a9aedca7bbdccb8c212e52ab90","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-23 20:02:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/eef538f8197743ada09cf89dc9268609\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e18cf4204de4486eb84a8b5b7a7e5aad : SUCCESS in 2m 35s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/76de32b47a0c4d48ba3a41e068694a66 : SUCCESS in 10m 16s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/24672ac77d834956ba56ae51ba2fbafe : SUCCESS in 12m 01s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/9facc20ace974f64a3ccb742b8016a8a : SUCCESS in 11m 51s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a091725dd4c48e0b126f7eda90f2e68 : SUCCESS in 7m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d311ba086eab4abc89264c7eada1963c : SUCCESS in 16m 18s (non-voting)\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/d479285220094def831582c7152e70bd : SUCCESS in 17m 29s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/58a81cdadeb041dd912e6807a9e6a44b : SUCCESS in 18m 25s","accounts_in_message":[],"_revision_number":1},{"id":"30ec81b71c1f751cc8308e32eaebbdf42dc0a738","author":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"date":"2025-09-24 20:43:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d21c0d9f667ea5aa6ea3f56d7f61addd87a0aaea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-24 20:44:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d09cd263e1eef1289686283fb630399c64782c08","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-24 21:38:57.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e5ba8e56e24b4e2195576b99a1611a69\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/10a1cc31530b4c9aa22e1dcfba8616ea : SUCCESS in 3m 09s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a94941bcad3c4878bdec2b3f7d9a3de4 : SUCCESS in 11m 26s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/dd931c7b01fd49d69fb0cd45d14c2f85 : SUCCESS in 10m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/74c28081423b4f2481757ec482c92a78 : SUCCESS in 8m 15s\n- mistral-devstack https://zuul.opendev.org/t/openstack/build/8d72784992e74d50b094aa1c2a3bae83 : SUCCESS in 18m 02s\n- mistral-devstack-tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/814a86a556464da9a102d6c4428da849 : SUCCESS in 40m 51s","accounts_in_message":[],"_revision_number":1},{"id":"b41a9fdb33bc49e93cbc52702d9a9f313ead5592","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-24 21:38:57.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"d69d6ee2f6c1f8ca0bde9abf68c8d69bd7e120ea","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-24 21:39:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0bd2287c91e541399be282a7ce711ae7\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ede62faa36648718d5f299a7fdcf938 : SUCCESS in 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f05fb9f9ce851ffab86aeede037e7daf30bd3281","revisions":{"f05fb9f9ce851ffab86aeede037e7daf30bd3281":{"kind":"REWORK","_number":1,"created":"2025-09-23 19:43:08.000000000","uploader":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"},"ref":"refs/changes/33/962133/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/mistral","ref":"refs/changes/33/962133/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/mistral refs/changes/33/962133/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/mistral refs/changes/33/962133/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/mistral refs/changes/33/962133/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/mistral refs/changes/33/962133/1"}}},"commit":{"parents":[{"commit":"ce191efdf9f1e80e1d3181f880fbc33c38716f39","subject":"Update TOX_CONSTRAINTS_FILE for stable/2025.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/ce191efdf9f1e80e1d3181f880fbc33c38716f39"}]}],"author":{"name":"Arnaud M","email":"arnaud.morin@gmail.com","date":"2025-09-22 20:32:09.000000000","tz":120},"committer":{"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","date":"2025-09-23 19:43:08.000000000","tz":0},"subject":"Do not call setup_db from engine","message":"Do not call setup_db from engine\n\nCalling setup_db is creating the db structure if missing (because it\u0027s\ncalling models.Workbook.metadata.create_all after).\n\nThis is not what we want since we want the operator to manage the\ncreation of the db using mistral-db-manage like any other regular\nopenstack service.\n\nI suspect that this call was mostly useful for tests.\nThis is a real issue in production because it create the DB structure\nwithout using the correct alembic migration path (and thus,\nalembic_version table is missing).\n\nChange-Id: I51f4128dd023846a4406cd1b414a56d741035483\nSigned-off-by: Arnaud M \u003carnaud.morin@gmail.com\u003e\n(cherry picked from commit 8be59adc3810e8a68c94b6c63998eef7fb769830)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/f05fb9f9ce851ffab86aeede037e7daf30bd3281"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/mistral/commit/f05fb9f9ce851ffab86aeede037e7daf30bd3281"}]},"branch":"refs/heads/stable/2025.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11583,"name":"Arnaud Morin","email":"arnaud.morin@gmail.com","username":"arnaudmorin"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}