)]}'
{"monagent/collector/checks/check.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"711b32c9e0531b43680afae672649019395314b4","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        \"\"\""},{"line_number":425,"context_line":"        if prettyprint:"},{"line_number":426,"context_line":"            metrics\u003dself.aggregator.flush()"},{"line_number":427,"context_line":"            for meas in metrics:"},{"line_number":428,"context_line":"                print \" Timestamp:  \", meas.timestamp"},{"line_number":429,"context_line":"                print \" Name:       \", meas.name"},{"line_number":430,"context_line":"                print \" Value:      \", meas.value"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_62e94319","line":427,"updated":"2014-07-28 16:44:49.000000000","message":"In general, I\u0027m not in favor of acronyms like this. What is meas? Is it short for measurement? That doesn\u0027t seem to be correct. Doesn\u0027t seem to be short of metric either. In this case it seems like you are iterating over metrics, so \"metric\" seems to make a lot of sense.","commit_id":"5d361a2f71ed3cd9978f47856fa3d70efe79dc14"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            except Exception:"},{"line_number":260,"context_line":"                pass"},{"line_number":261,"context_line":"            if prettyprint:"},{"line_number":262,"context_line":"                print \"Metrics:\", metrics"},{"line_number":263,"context_line":"        return metrics"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_59d88d24","line":262,"updated":"2014-08-05 18:26:37.000000000","message":"In Python3 there is no more print statement. Please use print as method (http://legacy.python.org/dev/peps/pep-3105/). I proposed https://review.openstack.org/#/c/110126/ to enable the H233 check to enforce the usage of the print method.","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        \"\"\""},{"line_number":425,"context_line":"        if prettyprint:"},{"line_number":426,"context_line":"            metrics \u003d self.aggregator.flush()"},{"line_number":427,"context_line":"            for metric in metrics:"},{"line_number":428,"context_line":"                print \" Timestamp:  \", metric.timestamp"},{"line_number":429,"context_line":"                print \" Name:       \", metric.name"},{"line_number":430,"context_line":"                print \" Value:      \", metric.value"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_79dd5113","line":427,"updated":"2014-08-05 18:26:37.000000000","message":"Same like in line 262 for all print statements.","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"}],"monagent/collector/daemon.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"711b32c9e0531b43680afae672649019395314b4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                        print \"Metrics: \""},{"line_number":274,"context_line":"                        check.get_metrics(prettyprint\u003dTrue)"},{"line_number":275,"context_line":"#                        print \"Events: \""},{"line_number":276,"context_line":"#                        print check.get_events()"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    elif \u0027configcheck\u0027 \u003d\u003d command or \u0027configtest\u0027 \u003d\u003d command:"},{"line_number":279,"context_line":"        osname \u003d get_os()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_42599f27","line":276,"updated":"2014-07-28 16:44:49.000000000","message":"Same comment as above.","commit_id":"5d361a2f71ed3cd9978f47856fa3d70efe79dc14"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            for check in checks[\u0027initialized_checks\u0027]:"},{"line_number":263,"context_line":"                if check.name \u003d\u003d check_name:"},{"line_number":264,"context_line":"                    check.run()"},{"line_number":265,"context_line":"                    print \"Metrics: \""},{"line_number":266,"context_line":"                    check.get_metrics(prettyprint\u003dTrue)"},{"line_number":267,"context_line":"#                    print \"Events: \""},{"line_number":268,"context_line":"#                    print check.get_events()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d9cbbd49","line":265,"updated":"2014-08-05 18:26:37.000000000","message":"Please use print(..).","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                    print \"Metrics: \""},{"line_number":266,"context_line":"                    check.get_metrics(prettyprint\u003dTrue)"},{"line_number":267,"context_line":"#                    print \"Events: \""},{"line_number":268,"context_line":"#                    print check.get_events()"},{"line_number":269,"context_line":"                    if len(args) \u003d\u003d 3 and args[2] \u003d\u003d \u0027check_rate\u0027:"},{"line_number":270,"context_line":"                        print \"Running 2nd iteration to capture rate metrics\""},{"line_number":271,"context_line":"                        time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_39d3d902","line":268,"updated":"2014-08-05 18:26:37.000000000","message":"Why do we want to keep commented lines?","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                        print \"Running 2nd iteration to capture rate metrics\""},{"line_number":271,"context_line":"                        time.sleep(1)"},{"line_number":272,"context_line":"                        check.run()"},{"line_number":273,"context_line":"                        print \"Metrics: \""},{"line_number":274,"context_line":"                        check.get_metrics(prettyprint\u003dTrue)"},{"line_number":275,"context_line":"#                        print \"Events: \""},{"line_number":276,"context_line":"#                        print check.get_events()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_19d615f3","line":273,"updated":"2014-08-05 18:26:37.000000000","message":"Please use print(..).","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"26bb013eb2eb475ce61c159cf2c901d548ca050d","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                        print \"Metrics: \""},{"line_number":274,"context_line":"                        check.get_metrics(prettyprint\u003dTrue)"},{"line_number":275,"context_line":"#                        print \"Events: \""},{"line_number":276,"context_line":"#                        print check.get_events()"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    elif \u0027configcheck\u0027 \u003d\u003d command or \u0027configtest\u0027 \u003d\u003d command:"},{"line_number":279,"context_line":"        osname \u003d get_os()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7904717d","line":276,"updated":"2014-08-05 18:26:37.000000000","message":"Why do we want to keep commented lines?","commit_id":"a7a568cfd7a25053b0d66d80806910a3aeace6da"}],"monagent/common/check_status.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"711b32c9e0531b43680afae672649019395314b4","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        elif self.transactions_flushed !\u003d self.transactions_received:"},{"line_number":579,"context_line":"            lines.append(\"[%s]: Transactions out of sync\\n             %s\" %"},{"line_number":580,"context_line":"                         (style(STATUS_WARNING, \u0027yellow\u0027),"},{"line_number":581,"context_line":"                         \"Likely contact interruption with monasca-api\"))"},{"line_number":582,"context_line":"        else:"},{"line_number":583,"context_line":"            lines.append(\"[%s]: Transactions up to date\" %"},{"line_number":584,"context_line":"                         style(STATUS_OK, \u0027green\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a2543bc6","line":581,"updated":"2014-07-28 16:44:49.000000000","message":"This comment also seems to be a bit obscure. I don\u0027t know what Likely contact interruption with monasca-api. Would something like \"The number of flushed transactions does not match the number of received.\"","commit_id":"5d361a2f71ed3cd9978f47856fa3d70efe79dc14"}]}