)]}'
{"monagent/collector/checks/check.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    [(timestamp, value, hostname, device_name)]"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            raise monagent.common.exceptions.CheckException(\"%s must be either gauge or counter, skipping sample at %s\" %"},{"line_number":155,"context_line":"                                 (metric, time.ctime(timestamp)))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if self.is_gauge(metric):"},{"line_number":158,"context_line":"            # store[metric][dimensions] \u003d (ts, val) - only 1 value allowed"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_0f5ad829","line":155,"updated":"2014-08-27 21:38:50.000000000","message":"155 needs more indentation to visually align with 154.","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                    [(timestamp, value, hostname, device_name)]"},{"line_number":153,"context_line":"        else:"},{"line_number":154,"context_line":"            raise monagent.common.exceptions.CheckException(\"%s must be either gauge or counter, skipping sample at %s\" %"},{"line_number":155,"context_line":"                                 (metric, time.ctime(timestamp)))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if self.is_gauge(metric):"},{"line_number":158,"context_line":"            # store[metric][dimensions] \u003d (ts, val) - only 1 value allowed"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_b6e76211","line":155,"in_reply_to":"1abeadc6_0f5ad829","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                instance_status \u003d monagent.common.check_status.InstanceStatus(i,"},{"line_number":503,"context_line":"                                                                             monagent.common.check_status.STATUS_ERROR,"},{"line_number":504,"context_line":"                                                                             error\u003de,"},{"line_number":505,"context_line":"                                                                             tb\u003dtraceback.format_exc())"},{"line_number":506,"context_line":"            instance_statuses.append(instance_status)"},{"line_number":507,"context_line":"        return instance_statuses"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_8f5c281b","line":505,"updated":"2014-08-27 21:38:50.000000000","message":"503, 504, and 505 each need  just one more space for visual indent.","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                instance_status \u003d monagent.common.check_status.InstanceStatus(i,"},{"line_number":503,"context_line":"                                                                             monagent.common.check_status.STATUS_ERROR,"},{"line_number":504,"context_line":"                                                                             error\u003de,"},{"line_number":505,"context_line":"                                                                             tb\u003dtraceback.format_exc())"},{"line_number":506,"context_line":"            instance_statuses.append(instance_status)"},{"line_number":507,"context_line":"        return instance_statuses"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_16c2d652","line":505,"in_reply_to":"1abeadc6_8f5c281b","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}],"monagent/collector/checks/system/unix.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                        key.split("},{"line_number":66,"context_line":"                                            \u0027.\u0027, 1)[1], timestamp, value, {"},{"line_number":67,"context_line":"                                            \u0027device\u0027: key.split("},{"line_number":68,"context_line":"                                                \u0027.\u0027, 1)[0]}) for key, value in stats.iteritems()]"},{"line_number":69,"context_line":"            return measurements"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_6c2c3aad","line":68,"updated":"2014-08-27 21:38:50.000000000","message":"These (64-68) might need to be re-aligned.  As it is now, line 65 would throw E126 for over-intended.","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                        key.split("},{"line_number":66,"context_line":"                                            \u0027.\u0027, 1)[1], timestamp, value, {"},{"line_number":67,"context_line":"                                            \u0027device\u0027: key.split("},{"line_number":68,"context_line":"                                                \u0027.\u0027, 1)[0]}) for key, value in stats.iteritems()]"},{"line_number":69,"context_line":"            return measurements"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_56f44e5a","line":68,"in_reply_to":"1abeadc6_6c2c3aad","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"f67051230bd30b4cc60a4b5686f24fced0b1ec91","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                                                timestamp,"},{"line_number":65,"context_line":"                                                                value,"},{"line_number":66,"context_line":"                                                                {\u0027device\u0027: key.split(\u0027.\u0027, 1)[0]})"},{"line_number":67,"context_line":"                                                                for key, value in stats.iteritems()]"},{"line_number":68,"context_line":"            return measurements"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_1c5cb518","line":67,"updated":"2014-08-28 14:47:21.000000000","message":"Line 67 should align with the bracket started on line 63, rather than the paren started later on line 63.  28 spaces from the beginning of the line seems to satisfy E127.","commit_id":"ecf6e5ac97f6f1e9c7c0f62a1984cf6cce11ff77"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"84e703fb3a80ac0f1d649a64884122cbb9850ce5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                                                timestamp,"},{"line_number":65,"context_line":"                                                                value,"},{"line_number":66,"context_line":"                                                                {\u0027device\u0027: key.split(\u0027.\u0027, 1)[0]})"},{"line_number":67,"context_line":"                                                                for key, value in stats.iteritems()]"},{"line_number":68,"context_line":"            return measurements"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_5cc2ade9","line":67,"in_reply_to":"1abeadc6_1c5cb518","updated":"2014-08-28 15:02:07.000000000","message":"Done","commit_id":"ecf6e5ac97f6f1e9c7c0f62a1984cf6cce11ff77"}],"monagent/collector/checks/utils.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# os.SEEK_END is defined in python 2.5"},{"line_number":7,"context_line":"SEEK_END \u003d 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"def median(vals):"},{"line_number":10,"context_line":"    vals \u003d sorted(vals)"},{"line_number":11,"context_line":"    if not vals:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_2f979491","line":8,"updated":"2014-08-27 21:38:50.000000000","message":"Need one more newline before \"def median(vals):\"","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# os.SEEK_END is defined in python 2.5"},{"line_number":7,"context_line":"SEEK_END \u003d 2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"def median(vals):"},{"line_number":10,"context_line":"    vals \u003d sorted(vals)"},{"line_number":11,"context_line":"    if not vals:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_769cea0e","line":8,"in_reply_to":"1abeadc6_2f979491","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}],"monagent/collector/checks_d/hdfs.py":[{"author":{"_account_id":1976,"name":"Jonathan Halterman","email":"jhalterman@hp.com","username":"jhalterman"},"change_message_id":"e490561688d3c3c168ff9609127c5f5ea91954bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"class HDFSCheck(AgentCheck):"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"\"\"Report on free space and space used in HDFS."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    \"\"\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    def check(self, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_23aeda2e","line":7,"updated":"2014-08-27 17:16:14.000000000","message":"These blank lines before the close of a function comment are really necessary for pep8?","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"53686f178c5f55484974a93895ade484192ab52e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"class HDFSCheck(AgentCheck):"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    \"\"\"Report on free space and space used in HDFS."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    \"\"\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    def check(self, instance):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_468da47b","line":7,"in_reply_to":"1abeadc6_23aeda2e","updated":"2014-08-27 17:21:14.000000000","message":"Yes, it is one of the hacking rules.  See http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}],"monagent/collector/checks_d/network.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _parse_solaris_netstat(self, netstat_output):"},{"line_number":257,"context_line":"        \"\"\"Return a mapping of network metrics by interface. For example:"},{"line_number":258,"context_line":" "},{"line_number":259,"context_line":"            { interface:"},{"line_number":260,"context_line":"                {\u0027bytes_out\u0027: 0,"},{"line_number":261,"context_line":"                  \u0027bytes_in\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_8cbef6ac","line":258,"updated":"2014-08-27 21:38:50.000000000","message":"There\u0027s a space character at the beginning of this line.","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _parse_solaris_netstat(self, netstat_output):"},{"line_number":257,"context_line":"        \"\"\"Return a mapping of network metrics by interface. For example:"},{"line_number":258,"context_line":" "},{"line_number":259,"context_line":"            { interface:"},{"line_number":260,"context_line":"                {\u0027bytes_out\u0027: 0,"},{"line_number":261,"context_line":"                  \u0027bytes_in\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_f67d5ab3","line":258,"in_reply_to":"1abeadc6_8cbef6ac","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}],"monagent/collector/daemon.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        watchdog \u003d None"},{"line_number":162,"context_line":"        if agentConfig.get(\"watchdog\", True):"},{"line_number":163,"context_line":"            watchdog \u003d monagent.common.util.Watchdog(check_freq * WATCHDOG_MULTIPLIER,"},{"line_number":164,"context_line":"                                max_mem_mb\u003dagentConfig.get(\u0027limit_memory_consumption\u0027, None))"},{"line_number":165,"context_line":"            watchdog.reset()"},{"line_number":166,"context_line":"        return watchdog"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_2cdc02e4","line":164,"updated":"2014-08-27 21:38:50.000000000","message":"This would through an E128 under-indented continuation line","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        watchdog \u003d None"},{"line_number":162,"context_line":"        if agentConfig.get(\"watchdog\", True):"},{"line_number":163,"context_line":"            watchdog \u003d monagent.common.util.Watchdog(check_freq * WATCHDOG_MULTIPLIER,"},{"line_number":164,"context_line":"                                max_mem_mb\u003dagentConfig.get(\u0027limit_memory_consumption\u0027, None))"},{"line_number":165,"context_line":"            watchdog.reset()"},{"line_number":166,"context_line":"        return watchdog"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a10b9e22","line":164,"in_reply_to":"1abeadc6_2cdc02e4","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}],"tests/test_system.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"ba5d1adf64fcdd3ce47b0bd78975b72b6f3320f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":8,"context_line":"logger \u003d logging.getLogger(__file__)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from monagent.collector.checks.system.unix import Disk, Cpu, Memory, IO"},{"line_number":11,"context_line":"from common import get_check"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_ef967c3d","line":10,"updated":"2014-08-27 21:38:50.000000000","message":"Does this violate H301?","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"24a586966e9ba839a607712e8e45dd3b210d8de8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":8,"context_line":"logger \u003d logging.getLogger(__file__)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from monagent.collector.checks.system.unix import Disk, Cpu, Memory, IO"},{"line_number":11,"context_line":"from common import get_check"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a1cc7ebc","line":10,"in_reply_to":"1abeadc6_ef967c3d","updated":"2014-08-28 14:34:15.000000000","message":"Done","commit_id":"7ab841116af718d216dbc7fee369b2d7f0ee6418"}]}