)]}'
{"monasca_agent/collector/checks/check.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"be18da2740ac60a3990a38e94ab19da92f52e837","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import yaml"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monasca_agent.common.util import get_hostname"},{"line_number":19,"context_line":"from monasca_agent.common.keystone import Keystone"},{"line_number":20,"context_line":"from monasca_agent.common.aggregator import MetricsAggregator"},{"line_number":21,"context_line":"import monasca_agent.common.config"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_85f52ace","line":18,"updated":"2015-01-20 15:02:41.000000000","message":"OpenStack is only going to allow modules to be imported, not objects from modules.","commit_id":"7d9b1342f03708e775b73b91c8c855b2df56579b"}],"monasca_agent/collector/checks/collector.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"be18da2740ac60a3990a38e94ab19da92f52e837","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        for check in self.initialized_checks_d:"},{"line_number":245,"context_line":"            check.stop()"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _set_dimensions(self, dimensions):"},{"line_number":248,"context_line":"        \"\"\"Method to append the default dimensions from the config file."},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":"        new_dimensions \u003d {\u0027hostname\u0027: get_hostname()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_65375e4e","line":247,"updated":"2015-01-20 15:02:41.000000000","message":"Is this duplicated code? There already exists a set_dimensions method in other modules. Can we unify the code?","commit_id":"7d9b1342f03708e775b73b91c8c855b2df56579b"}],"monasca_agent/collector/checks_d/http_check.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"a9f6d125ed6a5368b0e723a91fd91979ef838d1f","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        content \u003d \u0027\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        new_dimensions \u003d self._set_dimensions({\u0027url\u0027: addr})"},{"line_number":56,"context_line":"        if dimensions is not None:"},{"line_number":57,"context_line":"            new_dimensions.update(dimensions.copy())"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c77df21f","line":55,"updated":"2015-01-16 13:20:15.000000000","message":"Do we have a way to set the service and component for an http check? For example, if an http check is being done against the Nova API you would like to have service\u003dcompute, component\u003dnova-api.","commit_id":"458d4c0c2807f8b7c44fcd8037128e5981b92732"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"893e14461bb9f121a0a6c63bb47c96fa66437580","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        content \u003d \u0027\u0027"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        new_dimensions \u003d self._set_dimensions({\u0027url\u0027: addr})"},{"line_number":56,"context_line":"        if dimensions is not None:"},{"line_number":57,"context_line":"            new_dimensions.update(dimensions.copy())"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_9c87985a","line":55,"in_reply_to":"3a961159_c77df21f","updated":"2015-01-16 16:39:04.000000000","message":"Yes, that would be done by adding a service and component dimension to the http_check config file instance for the check.","commit_id":"458d4c0c2807f8b7c44fcd8037128e5981b92732"}],"monasca_agent/collector/checks_d/mysql.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"a9f6d125ed6a5368b0e723a91fd91979ef838d1f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        host, port, user, password, mysql_sock, defaults_file, dimensions, options \u003d self._get_config("},{"line_number":68,"context_line":"            instance)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        new_dimensions \u003d self._set_dimensions({\u0027component\u0027: \u0027mysql\u0027, \u0027service\u0027: \u0027mysql\u0027})"},{"line_number":71,"context_line":"        if dimensions is not None:"},{"line_number":72,"context_line":"            new_dimensions.update(dimensions.copy())"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_47d662f3","line":70,"updated":"2015-01-16 13:20:15.000000000","message":"How does this work if the mysql is running on a system where mysql is wholly owned by that service? For example, in our public cloud where Nova runs it\u0027s own insstance of mysql and it isn\u0027t shared with other services.\n\nThis same question occurs in other components, such as rabbitmq, but I\u0027m not repeated it there.","commit_id":"458d4c0c2807f8b7c44fcd8037128e5981b92732"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"893e14461bb9f121a0a6c63bb47c96fa66437580","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        host, port, user, password, mysql_sock, defaults_file, dimensions, options \u003d self._get_config("},{"line_number":68,"context_line":"            instance)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        new_dimensions \u003d self._set_dimensions({\u0027component\u0027: \u0027mysql\u0027, \u0027service\u0027: \u0027mysql\u0027})"},{"line_number":71,"context_line":"        if dimensions is not None:"},{"line_number":72,"context_line":"            new_dimensions.update(dimensions.copy())"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_b7ff0d00","line":70,"in_reply_to":"3a961159_47d662f3","updated":"2015-01-16 16:39:04.000000000","message":"If the machine is wholly owned by the service, then the service dimension would be set in the agent config file.  If no service dimension is set then we assume that the machine is not owned by a single service.\n\nSo the order of precedence for all dimensions (Service and Component included) is:\n1) Any dimension defined in an Agent plugin config file.\n2) Any dimension defined in the Agent config file.\n3) Any default dimension set in the plugin code itself.\n\n1 being the highest precedence and 3 being the lowest precedence.  So if a dimension is defined in more than one place, the dimension will be set to the value of the highest precedence above.  I hope that makes sense.  I will add this description of dimension handling to the Agent readme file and upload a new patchset.","commit_id":"458d4c0c2807f8b7c44fcd8037128e5981b92732"}],"monasca_agent/common/aggregator.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"be18da2740ac60a3990a38e94ab19da92f52e837","unresolved":false,"context_lines":[{"line_number":9,"context_line":"from monasca_agent.common.metrics import Histogram"},{"line_number":10,"context_line":"from monasca_agent.common.metrics import Measurement"},{"line_number":11,"context_line":"from monasca_agent.common.metrics import Rate"},{"line_number":12,"context_line":"from monasca_agent.common.metrics import Set"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"log \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_e5deeed9","line":12,"updated":"2015-01-20 15:02:41.000000000","message":"Again, it might be better to just import the module instead of objects as OpenStack standards require.","commit_id":"7d9b1342f03708e775b73b91c8c855b2df56579b"}]}