)]}'
{"agent.conf.template":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"7c8f4d66afcf01f6f9494a684b3a113c21ff4d05","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# System Metrics configuration                                               #"},{"line_number":83,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d #"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Enabled categories of system metrics to collect"},{"line_number":86,"context_line":"system_metrics: cpu,disk,io,load,memory"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"#   Disk and IO                                                                   #"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a930d6b_fad282fe","line":85,"updated":"2015-01-26 19:13:06.000000000","message":"I think it would be nice to include (and maintain) a list of possible system_metrics in a comment here, so that it\u0027s easy for the user to see what the choices are.  It could be something as simple as:\n# Available system_metrics: cpu, disk, io, load, memory","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"a0eb194460089fb9a20af815c1eb0ab186856e07","unresolved":false,"context_lines":[{"line_number":82,"context_line":"# System Metrics configuration                                               #"},{"line_number":83,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d #"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Enabled categories of system metrics to collect"},{"line_number":86,"context_line":"system_metrics: cpu,disk,io,load,memory"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"#   Disk and IO                                                                   #"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1a930d6b_44fe59af","line":85,"in_reply_to":"1a930d6b_fad282fe","updated":"2015-01-26 21:12:25.000000000","message":"Done","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"}],"monasca_agent/collector/daemon.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"96c61f739eb153b5caa430afdeb48bed0c5581dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"import checks.collector"},{"line_number":13,"context_line":"import jmxfetch"},{"line_number":14,"context_line":"import monasca_agent.common.check_status"},{"line_number":15,"context_line":"import monasca_agent.common.config as the_config"},{"line_number":16,"context_line":"import monasca_agent.common.daemon"},{"line_number":17,"context_line":"import monasca_agent.common.emitter"},{"line_number":18,"context_line":"import monasca_agent.common.util as util"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_c6e788aa","line":15,"updated":"2015-01-27 16:32:31.000000000","message":"Previously you imported as cfg, it is a bit nicer to stick with that.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"6d8744727be5f13079316db0edc2eb8d9b7fe0a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"import checks.collector"},{"line_number":13,"context_line":"import jmxfetch"},{"line_number":14,"context_line":"import monasca_agent.common.check_status"},{"line_number":15,"context_line":"import monasca_agent.common.config as the_config"},{"line_number":16,"context_line":"import monasca_agent.common.daemon"},{"line_number":17,"context_line":"import monasca_agent.common.emitter"},{"line_number":18,"context_line":"import monasca_agent.common.util as util"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_d94d7fc6","line":15,"in_reply_to":"1a930d6b_c6e788aa","updated":"2015-01-27 21:02:52.000000000","message":"Done","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"96c61f739eb153b5caa430afdeb48bed0c5581dc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        monasca_agent.common.check_status.CollectorStatus().persist()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        paths \u003d util.Paths()"},{"line_number":90,"context_line":"        # Start JMXFetch if needed"},{"line_number":91,"context_line":"        jmxfetch.JMXFetch.init(paths.get_confd_path(),"},{"line_number":92,"context_line":"                               config,"},{"line_number":93,"context_line":"                               the_config.DEFAULT_CHECK_FREQUENCY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_f1599c35","line":90,"updated":"2015-01-27 16:32:31.000000000","message":"Why was this added? JMXFetch.init happens below still. Also the comment implies it only is started if needed but there is no checking to see if it needed here.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"6d8744727be5f13079316db0edc2eb8d9b7fe0a9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        monasca_agent.common.check_status.CollectorStatus().persist()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        paths \u003d util.Paths()"},{"line_number":90,"context_line":"        # Start JMXFetch if needed"},{"line_number":91,"context_line":"        jmxfetch.JMXFetch.init(paths.get_confd_path(),"},{"line_number":92,"context_line":"                               config,"},{"line_number":93,"context_line":"                               the_config.DEFAULT_CHECK_FREQUENCY,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_596d0f04","line":90,"in_reply_to":"1a930d6b_f1599c35","updated":"2015-01-27 21:02:52.000000000","message":"Not sure how this got in there.  Probably a cut and paste error.  I\u0027ll remove it.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"96c61f739eb153b5caa430afdeb48bed0c5581dc","unresolved":false,"context_lines":[{"line_number":184,"context_line":"def main():"},{"line_number":185,"context_line":"    options, args \u003d util.get_parsed_args()"},{"line_number":186,"context_line":"    config \u003d the_config.Config()"},{"line_number":187,"context_line":"    agent_config \u003d config.get_config([\u0027Main\u0027, \u0027Api\u0027, \u0027Logging\u0027])"},{"line_number":188,"context_line":"    # todo autorestart isn\u0027t used remove"},{"line_number":189,"context_line":"    autorestart \u003d agent_config.get(\u0027autorestart\u0027, False)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_06b35098","line":187,"updated":"2015-01-27 16:32:31.000000000","message":"agent_config is a misleading name here, it implies the entire agent config rather than just a small subset.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"6d8744727be5f13079316db0edc2eb8d9b7fe0a9","unresolved":false,"context_lines":[{"line_number":184,"context_line":"def main():"},{"line_number":185,"context_line":"    options, args \u003d util.get_parsed_args()"},{"line_number":186,"context_line":"    config \u003d the_config.Config()"},{"line_number":187,"context_line":"    agent_config \u003d config.get_config([\u0027Main\u0027, \u0027Api\u0027, \u0027Logging\u0027])"},{"line_number":188,"context_line":"    # todo autorestart isn\u0027t used remove"},{"line_number":189,"context_line":"    autorestart \u003d agent_config.get(\u0027autorestart\u0027, False)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_84aabad2","line":187,"in_reply_to":"1a930d6b_06b35098","updated":"2015-01-27 21:02:52.000000000","message":"Changed it to collector_config.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"}],"monasca_agent/collector/jmxfetch.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"96c61f739eb153b5caa430afdeb48bed0c5581dc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    pid_file_path \u003d pid_file.get_path()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def init(cls, confd_path, agentConfig, default_check_frequency,"},{"line_number":58,"context_line":"             command\u003dNone, checks_list\u003dNone, reporter\u003dNone):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            command \u003d command or JMX_COLLECT_COMMAND"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_9185b85b","line":57,"updated":"2015-01-27 16:32:31.000000000","message":"In many places you have been standardizing to agent_config rather than agentConfig but you missed it here.","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"6d8744727be5f13079316db0edc2eb8d9b7fe0a9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    pid_file_path \u003d pid_file.get_path()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @classmethod"},{"line_number":57,"context_line":"    def init(cls, confd_path, agentConfig, default_check_frequency,"},{"line_number":58,"context_line":"             command\u003dNone, checks_list\u003dNone, reporter\u003dNone):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            command \u003d command or JMX_COLLECT_COMMAND"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_845d5aec","line":57,"in_reply_to":"1a930d6b_9185b85b","updated":"2015-01-27 21:02:52.000000000","message":"Done","commit_id":"7eab77f4e50de5128764ec5ebbcc0f5dd4613d22"}],"monasca_agent/common/check_status.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"7c8f4d66afcf01f6f9494a684b3a113c21ff4d05","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def _title_lines(cls):"},{"line_number":145,"context_line":"        name_line \u003d \"%s (v %s)\" % (cls.NAME, agent_config.get_version())"},{"line_number":146,"context_line":"        lines \u003d ["},{"line_number":147,"context_line":"            \"\u003d\" * len(name_line),"},{"line_number":148,"context_line":"            \"%s\" % name_line,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_b0581b8b","line":145,"updated":"2015-01-26 19:13:06.000000000","message":"Running \"monasca-collector info\" throws this error:\n\nTraceback (most recent call last):\n  File \"/usr/local/bin/monasca-collector\", line 10, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/usr/local/lib/python2.7/dist-packages/monasca_agent/collector/daemon.py\", line 239, in main\n    return agent.info(verbose\u003doptions.verbose)\n  File \"/usr/local/lib/python2.7/dist-packages/monasca_agent/collector/daemon.py\", line 71, in info\n    return monasca_agent.common.check_status.CollectorStatus.print_latest_status(verbose\u003dverbose)\n  File \"/usr/local/lib/python2.7/dist-packages/monasca_agent/common/check_status.py\", line 231, in print_latest_status\n    message \u003d cls._not_running_message()\n  File \"/usr/local/lib/python2.7/dist-packages/monasca_agent/common/check_status.py\", line 191, in _not_running_message\n    lines \u003d cls._title_lines() + [\n  File \"/usr/local/lib/python2.7/dist-packages/monasca_agent/common/check_status.py\", line 145, in _title_lines\n    name_line \u003d \"%s (v %s)\" % (cls.NAME, agent_config.get_version())\nNameError: global name \u0027agent_config\u0027 is not defined","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"a0eb194460089fb9a20af815c1eb0ab186856e07","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def _title_lines(cls):"},{"line_number":145,"context_line":"        name_line \u003d \"%s (v %s)\" % (cls.NAME, agent_config.get_version())"},{"line_number":146,"context_line":"        lines \u003d ["},{"line_number":147,"context_line":"            \"\u003d\" * len(name_line),"},{"line_number":148,"context_line":"            \"%s\" % name_line,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_8496813d","line":145,"in_reply_to":"1a930d6b_b0581b8b","updated":"2015-01-26 21:12:25.000000000","message":"Done","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"7c8f4d66afcf01f6f9494a684b3a113c21ff4d05","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            status_info[\u0027emitter\u0027].append(check_status)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        osname \u003d config.get_os()"},{"line_number":501,"context_line":"        "},{"line_number":502,"context_line":"        paths \u003d util.Paths()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            status_info[\u0027confd_path\u0027] \u003d paths.get_confd_path()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_da7066de","line":501,"updated":"2015-01-26 19:13:06.000000000","message":"There are some space characters on this blank line (PEP8 W293).","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"a0eb194460089fb9a20af815c1eb0ab186856e07","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            status_info[\u0027emitter\u0027].append(check_status)"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"        osname \u003d config.get_os()"},{"line_number":501,"context_line":"        "},{"line_number":502,"context_line":"        paths \u003d util.Paths()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            status_info[\u0027confd_path\u0027] \u003d paths.get_confd_path()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_c4ea49ab","line":501,"in_reply_to":"1a930d6b_da7066de","updated":"2015-01-26 21:12:25.000000000","message":"Done","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"}],"monasca_agent/forwarder/daemon.py":[{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"7c8f4d66afcf01f6f9494a684b3a113c21ff4d05","unresolved":false,"context_lines":[{"line_number":270,"context_line":"def init_forwarder(skip_ssl_validation\u003dFalse, use_simple_http_client\u003dFalse):"},{"line_number":271,"context_line":"    config \u003d cfg.Config()"},{"line_number":272,"context_line":"    agent_config \u003d config.get_config([\u0027Main\u0027, \u0027Api\u0027, \u0027Logging\u0027])"},{"line_number":273,"context_line":"    "},{"line_number":274,"context_line":"    port \u003d agent_config[\u0027listen_port\u0027]"},{"line_number":275,"context_line":"    if port is None:"},{"line_number":276,"context_line":"        port \u003d 17123"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_1d24a8c3","line":273,"updated":"2015-01-26 19:13:06.000000000","message":"Some extra space characters on this line.","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"a0eb194460089fb9a20af815c1eb0ab186856e07","unresolved":false,"context_lines":[{"line_number":270,"context_line":"def init_forwarder(skip_ssl_validation\u003dFalse, use_simple_http_client\u003dFalse):"},{"line_number":271,"context_line":"    config \u003d cfg.Config()"},{"line_number":272,"context_line":"    agent_config \u003d config.get_config([\u0027Main\u0027, \u0027Api\u0027, \u0027Logging\u0027])"},{"line_number":273,"context_line":"    "},{"line_number":274,"context_line":"    port \u003d agent_config[\u0027listen_port\u0027]"},{"line_number":275,"context_line":"    if port is None:"},{"line_number":276,"context_line":"        port \u003d 17123"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a930d6b_e4cbc550","line":273,"in_reply_to":"1a930d6b_1d24a8c3","updated":"2015-01-26 21:12:25.000000000","message":"Done","commit_id":"faf097ef066050fc2844b1cce20e289b68fcf081"}]}