)]}'
{"monasca_agent/common/keystone.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"d41ccf4104fde4710b688b1a0d446be500130b2a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        if not self._keystone_client:"},{"line_number":56,"context_line":"            self.get_token()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        return self._keystone_client.monasca_url"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def get_token(self):"},{"line_number":61,"context_line":"        \"\"\"Validate token is project scoped and return it if it is"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_70bb990e","line":58,"updated":"2015-02-20 22:37:34.000000000","message":"get_token() can return with _keystone_client still None. Need to check for that","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"d41ccf4104fde4710b688b1a0d446be500130b2a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                              \"Error was {}\".format(repr(exc)))"},{"line_number":73,"context_line":"                    return None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            self._token \u003d self._keystone_client.token"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return self._token"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_75038b0f","line":75,"updated":"2015-02-20 22:37:34.000000000","message":"The problem with this change is that the user will get a message that makes sense for the CLI, but not for the agent. It talks about --os-project-id for example","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"99a60173a6bbe67b5d4bc8e95b98f422c09e5908","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                              \"Error was {}\".format(repr(exc)))"},{"line_number":73,"context_line":"                    return None"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"            self._token \u003d self._keystone_client.token"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return self._token"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_7cdd3370","line":75,"in_reply_to":"ba7be1f8_75038b0f","updated":"2015-02-20 23:47:14.000000000","message":"Good point. I was doing it so the logic of which keystone combo is valid needs only to be maintained one place. Given that this is in a module meant to be used not just as a cli perhaps I should change the python-monascaclient to give a more generic error?","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"}],"monasca_agent/forwarder/api/mon.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"d41ccf4104fde4710b688b1a0d446be500130b2a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                \u0027token\u0027: token"},{"line_number":116,"context_line":"            }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            if self.url \u003d\u003d \u0027\u0027:"},{"line_number":119,"context_line":"                self.url \u003d self.keystone.get_monasca_url()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            return monascaclient.client.Client(self.api_version, self.url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d00fe5df","line":118,"updated":"2015-02-20 22:37:34.000000000","message":"Wouldn\u0027t this be better as\n if not self.url:\n\n?","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"}],"monasca_setup/main.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"d41ccf4104fde4710b688b1a0d446be500130b2a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    parser.add_argument(\u0027--project_id\u0027, help\u003d\"Keystone project id  for keystone authentication\", required\u003dFalse, default\u003d\u0027\u0027)"},{"line_number":63,"context_line":"    parser.add_argument(\u0027--ca_file\u0027, help\u003d\"Sets the path to the ca certs file if using certificates. \" +"},{"line_number":64,"context_line":"                                          \"Required only if insecure is set to False\", required\u003dFalse, default\u003d\u0027\u0027)"},{"line_number":65,"context_line":"    parser.add_argument(\u0027--check_frequency\u0027, help\u003d\"How often to run metric collection in seconds\", type\u003dint, default\u003d15)"},{"line_number":66,"context_line":"    parser.add_argument(\u0027--config_dir\u0027, help\u003d\"Configuration directory\", default\u003d\u0027/etc/monasca/agent\u0027)"},{"line_number":67,"context_line":"    parser.add_argument(\u0027--dimensions\u0027, help\u003d\"Additional dimensions to set for all metrics. A comma seperated list \" +"},{"line_number":68,"context_line":"                                             \"of name/value pairs, \u0027name:value,name2:value2\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_50585556","line":65,"updated":"2015-02-20 22:37:34.000000000","message":"I thought our default was 20 seconds?","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"99a60173a6bbe67b5d4bc8e95b98f422c09e5908","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    parser.add_argument(\u0027--project_id\u0027, help\u003d\"Keystone project id  for keystone authentication\", required\u003dFalse, default\u003d\u0027\u0027)"},{"line_number":63,"context_line":"    parser.add_argument(\u0027--ca_file\u0027, help\u003d\"Sets the path to the ca certs file if using certificates. \" +"},{"line_number":64,"context_line":"                                          \"Required only if insecure is set to False\", required\u003dFalse, default\u003d\u0027\u0027)"},{"line_number":65,"context_line":"    parser.add_argument(\u0027--check_frequency\u0027, help\u003d\"How often to run metric collection in seconds\", type\u003dint, default\u003d15)"},{"line_number":66,"context_line":"    parser.add_argument(\u0027--config_dir\u0027, help\u003d\"Configuration directory\", default\u003d\u0027/etc/monasca/agent\u0027)"},{"line_number":67,"context_line":"    parser.add_argument(\u0027--dimensions\u0027, help\u003d\"Additional dimensions to set for all metrics. A comma seperated list \" +"},{"line_number":68,"context_line":"                                             \"of name/value pairs, \u0027name:value,name2:value2\u0027\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3c42db10","line":65,"in_reply_to":"ba7be1f8_50585556","updated":"2015-02-20 23:47:14.000000000","message":"Nope, the default has always been 15 seconds. It just turns out that the collection was taking nearly 5 seconds to run. I fixed some of that a few weeks ago and so now the collection is much faster. Some of the other slow collection spots need fixing still there is an open case for it.","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"}],"packaging/monasca-agent.init.template":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"cce4bdabad2b2535b0b06a1007b530d04423a61c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    exit 0"},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"check_status() {{"},{"line_number":38,"context_line":"    # If the socket exists, we can use supervisorctl"},{"line_number":39,"context_line":"    if [ -e $SUPERVISOR_SOCK ]; then"},{"line_number":40,"context_line":"        # If we\u0027re using supervisor, check the number of processes"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_cc1324b6","line":37,"updated":"2015-02-19 16:37:05.000000000","message":"Are these added braces required?","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"6f4236ac7f16b23a900ca121adc9549d925c87d8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    exit 0"},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"check_status() {{"},{"line_number":38,"context_line":"    # If the socket exists, we can use supervisorctl"},{"line_number":39,"context_line":"    if [ -e $SUPERVISOR_SOCK ]; then"},{"line_number":40,"context_line":"        # If we\u0027re using supervisor, check the number of processes"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"da86d52c_828d757e","line":37,"in_reply_to":"da86d52c_cc1324b6","updated":"2015-02-19 16:43:45.000000000","message":"Yes, monasca-setup is using a python string formatting to make this file a template, the escape character for those templates is { so you need {{ when you want just { in the final file.","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"d41ccf4104fde4710b688b1a0d446be500130b2a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        else"},{"line_number":117,"context_line":"          echo \"Pid file $SUPERVISOR_PIDFILE not found, nothing to stop\""},{"line_number":118,"context_line":"        fi"},{"line_number":119,"context_line":"   "},{"line_number":120,"context_line":"        exit $?"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba7be1f8_30092132","line":119,"updated":"2015-02-20 22:37:34.000000000","message":"trailing whitespace","commit_id":"ea2fb9e0da14f410f97f73d30e001bc84c7312e3"}]}
