)]}'
{"monasca_agent/collector/checks/utils.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":6,"context_line":"class DiskBase(check.AgentCheck):"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def _get_re_exclusions(self, instance):"},{"line_number":9,"context_line":"        # Parse device blacklist regular expression"},{"line_number":10,"context_line":"        filter \u003d None"},{"line_number":11,"context_line":"        try:"},{"line_number":12,"context_line":"            filter_device_re \u003d instance.get(\u0027device_blacklist_re\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_5125515a","line":9,"updated":"2015-02-24 20:59:20.000000000","message":"Make this a pydoc, ie \"\"\"\"msg\"\"\"","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"class DiskBase(check.AgentCheck):"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def _get_re_exclusions(self, instance):"},{"line_number":9,"context_line":"        # Parse device blacklist regular expression"},{"line_number":10,"context_line":"        filter \u003d None"},{"line_number":11,"context_line":"        try:"},{"line_number":12,"context_line":"            filter_device_re \u003d instance.get(\u0027device_blacklist_re\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_40349949","line":9,"in_reply_to":"ba7be1f8_5125515a","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        return filter"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def _get_fs_exclusions(self, instance):"},{"line_number":21,"context_line":"        # parse comma separated file system types to ignore list"},{"line_number":22,"context_line":"        file_system_list \u003d []"},{"line_number":23,"context_line":"        try:"},{"line_number":24,"context_line":"            file_systems \u003d instance.get(\u0027ignore_filesystem_types\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b11f6d07","line":21,"updated":"2015-02-24 20:59:20.000000000","message":"pydoc again","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        return filter"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def _get_fs_exclusions(self, instance):"},{"line_number":21,"context_line":"        # parse comma separated file system types to ignore list"},{"line_number":22,"context_line":"        file_system_list \u003d []"},{"line_number":23,"context_line":"        try:"},{"line_number":24,"context_line":"            file_systems \u003d instance.get(\u0027ignore_filesystem_types\u0027, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_804131ab","line":21,"in_reply_to":"ba7be1f8_b11f6d07","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import base64"},{"line_number":2,"context_line":"import re"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"def add_basic_auth(request, username, password):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_29268d68","line":2,"updated":"2015-02-25 16:30:37.000000000","message":"Are you really using re? I don\u0027t see it anywhere below","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import base64"},{"line_number":2,"context_line":"import re"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"def add_basic_auth(request, username, password):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_9a6b351d","line":2,"in_reply_to":"ba7be1f8_29268d68","updated":"2015-02-25 17:48:48.000000000","message":"Removed","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_agent/collector/checks_d/cpu.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":19,"context_line":"        if system_metrics:"},{"line_number":20,"context_line":"            if \u0027cpu\u0027 not in system_metrics:"},{"line_number":21,"context_line":"                # Cpu metrics have been disabled in the agent config"},{"line_number":22,"context_line":"                log.debug(\u0027Cpu metrics have been disabled in the agent config file\u0027)"},{"line_number":23,"context_line":"                return"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_311a9dcc","line":21,"updated":"2015-02-24 20:59:20.000000000","message":"redundant","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":19,"context_line":"        if system_metrics:"},{"line_number":20,"context_line":"            if \u0027cpu\u0027 not in system_metrics:"},{"line_number":21,"context_line":"                # Cpu metrics have been disabled in the agent config"},{"line_number":22,"context_line":"                log.debug(\u0027Cpu metrics have been disabled in the agent config file\u0027)"},{"line_number":23,"context_line":"                return"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_e044adb8","line":21,"in_reply_to":"ba7be1f8_311a9dcc","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [self.gauge(key, value, dimensions) for key, value in data.iteritems()]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        log.debug(\u0027Collected {} cpu metrics\u0027.format(len(data)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_090c69ec","line":41,"updated":"2015-02-25 16:30:37.000000000","message":"Need to use {0} for the Python 2.6 compatibility","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        [self.gauge(key, value, dimensions) for key, value in data.iteritems()]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        log.debug(\u0027Collected {} cpu metrics\u0027.format(len(data)))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_3a8329cd","line":41,"in_reply_to":"ba7be1f8_090c69ec","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_agent/collector/checks_d/disk.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":20,"context_line":"        if system_metrics:"},{"line_number":21,"context_line":"            if \u0027disk\u0027 not in system_metrics:"},{"line_number":22,"context_line":"                # Disk metrics have been disabled in the agent config"},{"line_number":23,"context_line":"                log.debug(\u0027Disk metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_54253f5a","line":20,"updated":"2015-02-24 20:59:20.000000000","message":"Why check the system_metrics value here, in fact why have this at all. If the plugin config is not setup it won\u0027t run just like the other plugins. The same situation with the other system metrics.","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        \"\"\""},{"line_number":19,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":20,"context_line":"        if system_metrics:"},{"line_number":21,"context_line":"            if \u0027disk\u0027 not in system_metrics:"},{"line_number":22,"context_line":"                # Disk metrics have been disabled in the agent config"},{"line_number":23,"context_line":"                log.debug(\u0027Disk metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_201a45cc","line":20,"in_reply_to":"ba7be1f8_54253f5a","updated":"2015-02-24 22:27:21.000000000","message":"Removed","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":20,"context_line":"        if system_metrics:"},{"line_number":21,"context_line":"            if \u0027disk\u0027 not in system_metrics:"},{"line_number":22,"context_line":"                # Disk metrics have been disabled in the agent config"},{"line_number":23,"context_line":"                log.debug(\u0027Disk metrics have been disabled in the agent config file\u0027)"},{"line_number":24,"context_line":"                return"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_b16ccd36","line":22,"updated":"2015-02-24 20:59:20.000000000","message":"redundant","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":20,"context_line":"        if system_metrics:"},{"line_number":21,"context_line":"            if \u0027disk\u0027 not in system_metrics:"},{"line_number":22,"context_line":"                # Disk metrics have been disabled in the agent config"},{"line_number":23,"context_line":"                log.debug(\u0027Disk metrics have been disabled in the agent config file\u0027)"},{"line_number":24,"context_line":"                return"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_400bb97c","line":22,"in_reply_to":"ba7be1f8_b16ccd36","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                   dimensions\u003ddimensions)"},{"line_number":54,"context_line":"                        disk_count +\u003d 1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                    log.debug(\u0027Collected {} disk usage metrics for partition {}\u0027.format(disk_count, partition.mountpoint))"},{"line_number":57,"context_line":"                    disk_count \u003d 0"},{"line_number":58,"context_line":"                    if send_io_stats:"},{"line_number":59,"context_line":"                        disk_stats \u003d psutil.disk_io_counters(perdisk\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_49858105","line":56,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0} and {1}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                   dimensions\u003ddimensions)"},{"line_number":54,"context_line":"                        disk_count +\u003d 1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                    log.debug(\u0027Collected {} disk usage metrics for partition {}\u0027.format(disk_count, partition.mountpoint))"},{"line_number":57,"context_line":"                    disk_count \u003d 0"},{"line_number":58,"context_line":"                    if send_io_stats:"},{"line_number":59,"context_line":"                        disk_stats \u003d psutil.disk_io_counters(perdisk\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_9a75f5cc","line":56,"in_reply_to":"ba7be1f8_49858105","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                        self.rate(\"io.read_time_sec\", float(stats.read_time / 1000), device_name\u003ddevice_name, dimensions\u003ddimensions)"},{"line_number":66,"context_line":"                        self.rate(\"io.write_time_sec\", float(stats.write_time / 1000), device_name\u003ddevice_name, dimensions\u003ddimensions)"},{"line_number":67,"context_line":"    "},{"line_number":68,"context_line":"                        log.debug(\u0027Collected 6 disk I/O metrics for partition {}\u0027.format(partition.mountpoint))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_re_exclusions(self, instance):"},{"line_number":71,"context_line":"        \"\"\"Parse device blacklist regular expression\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_c9a7b1a5","line":68,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                        self.rate(\"io.read_time_sec\", float(stats.read_time / 1000), device_name\u003ddevice_name, dimensions\u003ddimensions)"},{"line_number":66,"context_line":"                        self.rate(\"io.write_time_sec\", float(stats.write_time / 1000), device_name\u003ddevice_name, dimensions\u003ddimensions)"},{"line_number":67,"context_line":"    "},{"line_number":68,"context_line":"                        log.debug(\u0027Collected 6 disk I/O metrics for partition {}\u0027.format(partition.mountpoint))"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _get_re_exclusions(self, instance):"},{"line_number":71,"context_line":"        \"\"\"Parse device blacklist regular expression\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_da7bedbb","line":68,"in_reply_to":"ba7be1f8_c9a7b1a5","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_agent/collector/checks_d/io.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        \"\"\""},{"line_number":18,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":19,"context_line":"        if system_metrics:"},{"line_number":20,"context_line":"            if \u0027io\u0027 not in system_metrics:"},{"line_number":21,"context_line":"                # IO metrics have been disabled in the agent config"},{"line_number":22,"context_line":"                log.debug(\u0027Disk IO metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d4f04f93","line":19,"updated":"2015-02-24 20:59:20.000000000","message":"Same comment as the other plugins.","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        \"\"\""},{"line_number":18,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":19,"context_line":"        if system_metrics:"},{"line_number":20,"context_line":"            if \u0027io\u0027 not in system_metrics:"},{"line_number":21,"context_line":"                # IO metrics have been disabled in the agent config"},{"line_number":22,"context_line":"                log.debug(\u0027Disk IO metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6010bda8","line":19,"in_reply_to":"ba7be1f8_d4f04f93","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        partitions \u003d psutil.disk_partitions()"},{"line_number":38,"context_line":"        disk_stats \u003d psutil.disk_io_counters(perdisk\u003dTrue)"},{"line_number":39,"context_line":"        for partition in partitions:"},{"line_number":40,"context_line":"            if partition.fstype not in fs_types_to_ignore \\"},{"line_number":41,"context_line":"                or (device_blacklist_re \\"},{"line_number":42,"context_line":"                and not device_blacklist_re.match(partition.device)):"},{"line_number":43,"context_line":"                    device_name \u003d self._get_device_name(partition.device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f4e0f397","line":40,"updated":"2015-02-24 20:59:20.000000000","message":"This is remarkably similar the disk metrics. Now that they are both using similar systems I think they should be combined into one plugin. Just add a config option to disable the io bits if needed. That way the common config like device blacklists is only setup once. Also I think you could move the DiskBase bits right into the class here.","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        partitions \u003d psutil.disk_partitions()"},{"line_number":38,"context_line":"        disk_stats \u003d psutil.disk_io_counters(perdisk\u003dTrue)"},{"line_number":39,"context_line":"        for partition in partitions:"},{"line_number":40,"context_line":"            if partition.fstype not in fs_types_to_ignore \\"},{"line_number":41,"context_line":"                or (device_blacklist_re \\"},{"line_number":42,"context_line":"                and not device_blacklist_re.match(partition.device)):"},{"line_number":43,"context_line":"                    device_name \u003d self._get_device_name(partition.device)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6087ddd7","line":40,"in_reply_to":"ba7be1f8_f4e0f397","updated":"2015-02-24 22:27:21.000000000","message":"You are correct.  Combined the 2 disk plugins.","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"}],"monasca_agent/collector/checks_d/load.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"59a785a246d890db3521ae10d91054ec16bdde59","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        \"\"\""},{"line_number":21,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":22,"context_line":"        if system_metrics:"},{"line_number":23,"context_line":"            if \u0027load\u0027 not in system_metrics:"},{"line_number":24,"context_line":"                # Load metrics have been disabled in the agent config"},{"line_number":25,"context_line":"                log.debug(\u0027Load metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_d4912ff2","line":22,"updated":"2015-02-24 20:59:20.000000000","message":"Same comment, system_metrics could be skipped.","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"5063e8a12c0fbdb23cfe192e2f51fadf5a4040b6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        \"\"\""},{"line_number":21,"context_line":"        system_metrics \u003d self.agent_config.get(\u0027system_metrics\u0027, None)"},{"line_number":22,"context_line":"        if system_metrics:"},{"line_number":23,"context_line":"            if \u0027load\u0027 not in system_metrics:"},{"line_number":24,"context_line":"                # Load metrics have been disabled in the agent config"},{"line_number":25,"context_line":"                log.debug(\u0027Load metrics have been disabled in the agent config file\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_806f712a","line":22,"in_reply_to":"ba7be1f8_d4912ff2","updated":"2015-02-24 22:27:21.000000000","message":"Done","commit_id":"0efa96e16ec8a32848bce0ae17478c30da0c9dbf"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                uptime \u003d loadAvrgProc.readlines()"},{"line_number":28,"context_line":"                loadAvrgProc.close()"},{"line_number":29,"context_line":"            except Exception:"},{"line_number":30,"context_line":"                log.exception(\u0027Cannot extract load\u0027)"},{"line_number":31,"context_line":"                return"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"            uptime \u003d uptime[0]  # readlines() provides a list but we want a string"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_893db92d","line":30,"updated":"2015-02-25 16:30:37.000000000","message":"Maybe add using /proc/loadavg?","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                uptime \u003d loadAvrgProc.readlines()"},{"line_number":28,"context_line":"                loadAvrgProc.close()"},{"line_number":29,"context_line":"            except Exception:"},{"line_number":30,"context_line":"                log.exception(\u0027Cannot extract load\u0027)"},{"line_number":31,"context_line":"                return"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"            uptime \u003d uptime[0]  # readlines() provides a list but we want a string"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_1a9ca50e","line":30,"in_reply_to":"ba7be1f8_893db92d","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                          stdout\u003dsp.PIPE,"},{"line_number":40,"context_line":"                                          close_fds\u003dTrue).communicate()[0]"},{"line_number":41,"context_line":"            except Exception:"},{"line_number":42,"context_line":"                log.exception(\u0027Cannot extract load\u0027)"},{"line_number":43,"context_line":"                return"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Split out the 3 load average values"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_4938213d","line":42,"updated":"2015-02-25 16:30:37.000000000","message":"Maybe add using uptime?","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                          stdout\u003dsp.PIPE,"},{"line_number":40,"context_line":"                                          close_fds\u003dTrue).communicate()[0]"},{"line_number":41,"context_line":"            except Exception:"},{"line_number":42,"context_line":"                log.exception(\u0027Cannot extract load\u0027)"},{"line_number":43,"context_line":"                return"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # Split out the 3 load average values"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5a70dddb","line":42,"in_reply_to":"ba7be1f8_4938213d","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_agent/collector/checks_d/memory.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":65,"context_line":"            count +\u003d1"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        log.debug(\u0027Collected {} memory metrics\u0027.format(count))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_a91fddb5","line":67,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                       dimensions\u003ddimensions)"},{"line_number":65,"context_line":"            count +\u003d1"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        log.debug(\u0027Collected {} memory metrics\u0027.format(count))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_953f86b3","line":67,"in_reply_to":"ba7be1f8_a91fddb5","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_agent/collector/checks_d/network.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        excluded_ifaces \u003d instance.get(\u0027excluded_interfaces\u0027, [])"},{"line_number":24,"context_line":"        if excluded_ifaces:"},{"line_number":25,"context_line":"            log.debug(\u0027Excluding network devices: {}\u0027.format(excluded_ifaces))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        exclude_re \u003d instance.get(\u0027excluded_interface_re\u0027, None)"},{"line_number":28,"context_line":"        if exclude_re:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_495d8178","line":25,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        excluded_ifaces \u003d instance.get(\u0027excluded_interfaces\u0027, [])"},{"line_number":24,"context_line":"        if excluded_ifaces:"},{"line_number":25,"context_line":"            log.debug(\u0027Excluding network devices: {}\u0027.format(excluded_ifaces))"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        exclude_re \u003d instance.get(\u0027excluded_interface_re\u0027, None)"},{"line_number":28,"context_line":"        if exclude_re:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_5a153d47","line":25,"in_reply_to":"ba7be1f8_495d8178","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                self.rate(\u0027net.in_packets_dropped_sec\u0027, nic.dropin, device_name\u003dnic_name, dimensions\u003ddimensions)"},{"line_number":46,"context_line":"                self.rate(\u0027net.out_packets_dropped_sec\u0027, nic.dropout, device_name\u003dnic_name, dimensions\u003ddimensions)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"                log.debug(\u0027Collected 8 network metrics for device {}\u0027.format(nic_name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_a9927df3","line":48,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                self.rate(\u0027net.in_packets_dropped_sec\u0027, nic.dropin, device_name\u003dnic_name, dimensions\u003ddimensions)"},{"line_number":46,"context_line":"                self.rate(\u0027net.out_packets_dropped_sec\u0027, nic.dropout, device_name\u003dnic_name, dimensions\u003ddimensions)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"                log.debug(\u0027Collected 8 network metrics for device {}\u0027.format(nic_name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_7a0f6137","line":48,"in_reply_to":"ba7be1f8_a9927df3","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}],"monasca_setup/detection/plugins/system.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                with open(os.path.join(self.template_dir, \u0027conf.d/\u0027 + metric + \u0027.yaml\u0027), \u0027r\u0027) as metric_template:"},{"line_number":32,"context_line":"                    default_config \u003d yaml.load(metric_template.read())"},{"line_number":33,"context_line":"                config[metric] \u003d default_config"},{"line_number":34,"context_line":"                log.info(\u0027\\tConfigured {}\u0027.format(metric))"},{"line_number":35,"context_line":"            except (OSError, IOError):"},{"line_number":36,"context_line":"                log.info(\u0027\\tUnable to configure {}\u0027.format(metric))"},{"line_number":37,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_7416984d","line":34,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                with open(os.path.join(self.template_dir, \u0027conf.d/\u0027 + metric + \u0027.yaml\u0027), \u0027r\u0027) as metric_template:"},{"line_number":32,"context_line":"                    default_config \u003d yaml.load(metric_template.read())"},{"line_number":33,"context_line":"                config[metric] \u003d default_config"},{"line_number":34,"context_line":"                log.info(\u0027\\tConfigured {}\u0027.format(metric))"},{"line_number":35,"context_line":"            except (OSError, IOError):"},{"line_number":36,"context_line":"                log.info(\u0027\\tUnable to configure {}\u0027.format(metric))"},{"line_number":37,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_753db2c3","line":34,"in_reply_to":"ba7be1f8_7416984d","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eccc9fd28d1d7de1cfa7a0c74d3f2acb993bc365","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                config[metric] \u003d default_config"},{"line_number":34,"context_line":"                log.info(\u0027\\tConfigured {}\u0027.format(metric))"},{"line_number":35,"context_line":"            except (OSError, IOError):"},{"line_number":36,"context_line":"                log.info(\u0027\\tUnable to configure {}\u0027.format(metric))"},{"line_number":37,"context_line":"                continue"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return config"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_d4174443","line":36,"updated":"2015-02-25 16:30:37.000000000","message":"Use {0}","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"da625957a7ad7101f55911387ee093b03a3d2d1a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                config[metric] \u003d default_config"},{"line_number":34,"context_line":"                log.info(\u0027\\tConfigured {}\u0027.format(metric))"},{"line_number":35,"context_line":"            except (OSError, IOError):"},{"line_number":36,"context_line":"                log.info(\u0027\\tUnable to configure {}\u0027.format(metric))"},{"line_number":37,"context_line":"                continue"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        return config"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_953866d4","line":36,"in_reply_to":"ba7be1f8_d4174443","updated":"2015-02-25 17:48:48.000000000","message":"Done","commit_id":"e4368d638e8944e273f26ca3dcaa7900239cbc44"}]}
