)]}'
{"README.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":373,"context_line":"| cpu.stolen_perc | | Percentage of stolen CPU time, i.e. the time spent in other OS contexts when running in a virtualized environment |"},{"line_number":374,"context_line":"| cpu.system_perc | | Percentage of time the CPU is used at the system level |"},{"line_number":375,"context_line":"| cpu.user_perc  | | Percentage of time the CPU is used at the user level |"},{"line_number":376,"context_line":"| cpu.total_logical_cores  | | Total number of logical cores available for an entire node (Includes hyper threading) |"},{"line_number":377,"context_line":"| disk.inode_used_perc | device, mount_point | The percentage of inodes that are used on a device |"},{"line_number":378,"context_line":"| disk.space_used_perc | device, mount_point | The percentage of disk space that is being used on a device |"},{"line_number":379,"context_line":"| disk.total_space_mb | | The total amount of disk space aggregated across all the disks on a particular node |"}],"source_content_type":"text/x-gfm","patch_set":6,"id":"da9b358b_b2541c21","line":376,"updated":"2015-04-01 03:51:05.000000000","message":"Should it say this is optional?","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"| cpu.total_logical_cores  | | Total number of logical cores available for an entire node (Includes hyper threading) |"},{"line_number":377,"context_line":"| disk.inode_used_perc | device, mount_point | The percentage of inodes that are used on a device |"},{"line_number":378,"context_line":"| disk.space_used_perc | device, mount_point | The percentage of disk space that is being used on a device |"},{"line_number":379,"context_line":"| disk.total_space_mb | | The total amount of disk space aggregated across all the disks on a particular node |"},{"line_number":380,"context_line":"| disk.total_space_used_mb | | The total amount of used disk space aggregated across all the disks on a particular node |"},{"line_number":381,"context_line":"| io.read_kbytes_sec | device | Kbytes/sec read by an io device"},{"line_number":382,"context_line":"| io.read_req_sec | device   | Number of read requests/sec to an io device"}],"source_content_type":"text/x-gfm","patch_set":6,"id":"da9b358b_723574f5","line":379,"updated":"2015-04-01 03:51:05.000000000","message":"Should it say these two are optional?","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":377,"context_line":"| disk.inode_used_perc | device, mount_point | The percentage of inodes that are used on a device |"},{"line_number":378,"context_line":"| disk.space_used_perc | device, mount_point | The percentage of disk space that is being used on a device |"},{"line_number":379,"context_line":"| disk.total_space_mb | | The total amount of disk space aggregated across all the disks on a particular node |"},{"line_number":380,"context_line":"| disk.total_space_used_mb | | The total amount of used disk space aggregated across all the disks on a particular node |"},{"line_number":381,"context_line":"| io.read_kbytes_sec | device | Kbytes/sec read by an io device"},{"line_number":382,"context_line":"| io.read_req_sec | device   | Number of read requests/sec to an io device"},{"line_number":383,"context_line":"| io.read_time_sec | device   | Amount of read time/sec to an io device"}],"source_content_type":"text/x-gfm","patch_set":6,"id":"da9b358b_f25aa44f","line":380,"updated":"2015-04-01 03:51:05.000000000","message":"This is actually disk.total_used_space_mb","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"}],"conf.d/cpu.yaml":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      # Send additional cpu rollup system metrics (Default \u003d False)"},{"line_number":7,"context_line":"      # These metrics include the following metrics aggregated across all cpus:"},{"line_number":8,"context_line":"      # cpu.total_logical_cores"},{"line_number":9,"context_line":"      send_rollup_stats: True"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da9b358b_f208642f","line":9,"updated":"2015-04-01 03:51:05.000000000","message":"Should the default be on or off?","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"45c51d53a99c7fe0925e2574bfac3458eae3f11d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      # Send additional cpu rollup system metrics (Default \u003d False)"},{"line_number":7,"context_line":"      # These metrics include the following metrics aggregated across all cpus:"},{"line_number":8,"context_line":"      # cpu.total_logical_cores"},{"line_number":9,"context_line":"      send_rollup_stats: True"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"baa041b7_a6b452d1","line":9,"in_reply_to":"da9b358b_f208642f","updated":"2015-04-01 14:15:21.000000000","message":"Good catch, I think it should default to off.","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"}],"conf.d/disk.yaml":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"74945348649b44b23243589e313241812f19198d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da9b358b_296e7195","line":14,"updated":"2015-03-31 17:49:18.000000000","message":"disk.total_used_mb is just disk.used_mb right? Why the total in the name? It seems to me that this is one we could send even when send_rollup_stats is false as it does have some use for capacity planning.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"ca85f7fdaa5d5ec23a576985c0d71fe7aa6c69db","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da9b358b_c916e5a6","line":14,"in_reply_to":"da9b358b_296e7195","updated":"2015-03-31 18:05:50.000000000","message":"I use total in the names to signify that this is a rolled up statistic, not just specific to a certain disk or partition.  David, Roland and I discussed the names and thought this made sense.  I\u0027m not sure that total_used_mb would be useful without the total_mb which would be needed to compute the % utilized.  So probably best to make them both optional.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"507adac7f63fa1b0cc5b11cd9cb54e9f820c24a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da9b358b_c4f24c6f","line":14,"in_reply_to":"da9b358b_c916e5a6","updated":"2015-03-31 18:30:21.000000000","message":"Whoops I missed that it is the combination of multiple partitions, in that case total does make sense in the name.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da9b358b_9219188b","line":14,"updated":"2015-04-01 03:51:05.000000000","message":"These are actually  disk.total_space_mb and disk.total_used_space_mb","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0add31dcd6b253d9c132cd00499469c4ad8fcf1e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"},{"line_number":18,"context_line":"      # running constantly churning linux containers) whose metrics aren\u0027t"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da9b358b_721c5477","line":15,"updated":"2015-04-01 03:51:05.000000000","message":"Should the default be on?","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"45c51d53a99c7fe0925e2574bfac3458eae3f11d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      # Send additional disk rollup system metrics (Default \u003d False)"},{"line_number":13,"context_line":"      # These metrics include the following metrics aggregated across all disks:"},{"line_number":14,"context_line":"      # disk.total_mb and disk.total_used_mb"},{"line_number":15,"context_line":"      send_rollup_stats: True"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"      # Some infrastructures have many constantly changing virtual devices (e.g. folks"},{"line_number":18,"context_line":"      # running constantly churning linux containers) whose metrics aren\u0027t"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"baa041b7_66c76a46","line":15,"in_reply_to":"da9b358b_721c5477","updated":"2015-04-01 14:15:21.000000000","message":"Also should default to off","commit_id":"80f0d4efc87dff983dfb53ad38b3aef7a4219f24"}],"monasca_agent/collector/checks_d/cpu.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"74945348649b44b23243589e313241812f19198d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                                              cpu_stats.steal,"},{"line_number":26,"context_line":"                                              dimensions)"},{"line_number":27,"context_line":"        cpu_count \u003d psutil.cpu_count(logical\u003dTrue)"},{"line_number":28,"context_line":"        self.gauge(\u0027cpu.total_logical_cores\u0027, cpu_count, dimensions)"},{"line_number":29,"context_line":"        num_of_metrics +\u003d 1"},{"line_number":30,"context_line":"        log.debug(\u0027Collected {0} cpu metrics\u0027.format(num_of_metrics))"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_a9272163","line":28,"updated":"2015-03-31 17:49:18.000000000","message":"This should be optional like with the disk rollup stats.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"ca85f7fdaa5d5ec23a576985c0d71fe7aa6c69db","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                                              cpu_stats.steal,"},{"line_number":26,"context_line":"                                              dimensions)"},{"line_number":27,"context_line":"        cpu_count \u003d psutil.cpu_count(logical\u003dTrue)"},{"line_number":28,"context_line":"        self.gauge(\u0027cpu.total_logical_cores\u0027, cpu_count, dimensions)"},{"line_number":29,"context_line":"        num_of_metrics +\u003d 1"},{"line_number":30,"context_line":"        log.debug(\u0027Collected {0} cpu metrics\u0027.format(num_of_metrics))"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_6928f9e2","line":28,"in_reply_to":"da9b358b_a9272163","updated":"2015-03-31 18:05:50.000000000","message":"I will add the code and config to make it optional.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"}],"monasca_agent/collector/checks_d/disk.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4d9f30635879259911dc302988358b494ca9c55e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        dimensions \u003d self._set_dimensions(None, instance)"},{"line_number":20,"context_line":"        rollup_dimensions \u003d dimensions.copy()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        if instance is not None:"},{"line_number":23,"context_line":"            use_mount \u003d instance.get(\"use_mount\", True)"},{"line_number":24,"context_line":"            send_io_stats \u003d instance.get(\"send_io_stats\", True)"},{"line_number":25,"context_line":"            send_rollup_stats \u003d  instance.get(\"send_rollup_stats\", False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_3e6fc993","line":22,"updated":"2015-03-31 17:24:10.000000000","message":"If instance is None, then none of the variables are set and the below code will thrown an exception when it tries to use them","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"},{"author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"change_message_id":"ca85f7fdaa5d5ec23a576985c0d71fe7aa6c69db","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        dimensions \u003d self._set_dimensions(None, instance)"},{"line_number":20,"context_line":"        rollup_dimensions \u003d dimensions.copy()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        if instance is not None:"},{"line_number":23,"context_line":"            use_mount \u003d instance.get(\"use_mount\", True)"},{"line_number":24,"context_line":"            send_io_stats \u003d instance.get(\"send_io_stats\", True)"},{"line_number":25,"context_line":"            send_rollup_stats \u003d  instance.get(\"send_rollup_stats\", False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9b358b_a95ba186","line":22,"in_reply_to":"da9b358b_3e6fc993","updated":"2015-03-31 18:05:50.000000000","message":"You are right.  I shouldn\u0027t have removed the else.  I was thinking it wasn\u0027t needed because of the defaults in the instance.get() calls.","commit_id":"30d39b197f2ea74cbc2458172057b03d1d58ec4b"}]}