)]}'
{"id":"openstack%2Fmonasca-agent~166350","triplet_id":"openstack%2Fmonasca-agent~master~I031fff5f2cd2b4b62dfec0f5e1e5c86df4c76f52","project":"openstack/monasca-agent","branch":"master","topic":"feature/update-default-fs-ignore-list","hashtags":[],"change_id":"I031fff5f2cd2b4b62dfec0f5e1e5c86df4c76f52","subject":"Update default filesystems ignored by disk check","status":"MERGED","created":"2015-03-20 19:09:34.000000000","updated":"2015-03-23 15:19:12.000000000","submitted":"2015-03-23 15:19:11.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04f7b1db3c6260e15a851e0c470b04d8f0dc6d0d","_number":166350,"virtual_id_number":166350,"owner":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-03-23 15:19:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},{"value":0,"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},{"value":0,"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},{"value":0,"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},{"value":0,"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"recommended":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-03-23 15:09:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},{"value":1,"date":"2015-03-20 21:09:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},{"value":1,"date":"2015-03-20 21:02:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},{"value":0,"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},{"value":2,"date":"2015-03-23 15:17:51.000000000","_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},{"value":0,"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},{"value":0,"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},{"value":0,"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},{"value":1,"date":"2015-03-23 15:17:51.000000000","_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},{"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-20 21:02:29.000000000","updated_by":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"reviewer":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"state":"REVIEWER"},{"updated":"2015-03-20 21:09:04.000000000","updated_by":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"reviewer":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"state":"REVIEWER"},{"updated":"2015-03-23 15:09:37.000000000","updated_by":{"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},"reviewer":{"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},"state":"REVIEWER"},{"updated":"2015-03-23 15:17:51.000000000","updated_by":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"reviewer":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"state":"REVIEWER"},{"updated":"2015-03-23 15:19:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4c13931de4fd884e0ef14a444e3ed09f53a42e45","author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"date":"2015-03-20 19:09:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8327f8ac9198eff8498640141fcb7300fd521948","author":{"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},"date":"2015-03-20 19:14:02.000000000","message":"Patch Set 1: Code-Review+1\n\nI tested this on testcluster2, node4 and it works","accounts_in_message":[],"_revision_number":1},{"id":"9479c1e84f6967ebb8365aee801d9bdb5f2ec591","author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"date":"2015-03-20 19:21:25.000000000","message":"Patch Set 1: Code-Review-1\n\nI like the addition of the other types but why did you remove tmpfs and devtmpfs?","accounts_in_message":[],"_revision_number":1},{"id":"a7e1c74bf3c7ccbd3f50c21e1312d467aa202137","author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"date":"2015-03-20 20:30:54.000000000","message":"Patch Set 1:\n\nYou can get meaningful metrics from tmpfs and, to a lesser extent, devtmpfs.  I used to work at a place that used tmpfs heavily, and it absolutely needed to be monitored for disk space and inode usage.  The filesystems I specified in this patch, at least in my testing, didn\u0027t return disk space, inode, or performance metrics at all.","accounts_in_message":[],"_revision_number":1},{"id":"99b8f9c01313b33031704b19c1e4406213538a13","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-20 20:43:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-monasca-agent-pep8 http://logs.openstack.org/50/166350/1/check/gate-monasca-agent-pep8/62940a8/ : SUCCESS in 1m 05s\n- gate-monasca-agent-python27 http://logs.openstack.org/50/166350/1/check/gate-monasca-agent-python27/14a7d85/ : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":1},{"id":"4323866758e19a7a9b847ddcbcb42c9f5a3b93b4","author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"date":"2015-03-20 20:44:10.000000000","message":"Patch Set 1:\n\nI agree in some situations you can get meaningful data from tmpfs but in the default configuration built by monasca-setup I still vote it should be disabled. With devtmpfs the usefulness is even less common so it definitely should be disabled.","accounts_in_message":[],"_revision_number":1},{"id":"58f5ed08cf14883e28a9cf86ce6a604632f998d5","author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"date":"2015-03-20 21:00:05.000000000","message":"Patch Set 1:\n\nVery well.  The next patch set contains those, plus a few more that produce no space/inode/io metrics.","accounts_in_message":[],"_revision_number":1},{"id":"3856a8a9f99faf7344f41e4feb40769cb876580a","author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"date":"2015-03-20 21:00:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8e3b361842320d489a56116b07e6e0cc5169ae1c","author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"date":"2015-03-20 21:02:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ef2c0165fa5f56fd77789d43d896687522bea724","author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"date":"2015-03-20 21:09:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"12c8966f6acb5b38443a6b2f82ce08167d532a3f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-20 21:40:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-monasca-agent-pep8 http://logs.openstack.org/50/166350/2/check/gate-monasca-agent-pep8/3173d44/ : SUCCESS in 54s\n- gate-monasca-agent-python27 http://logs.openstack.org/50/166350/2/check/gate-monasca-agent-python27/3f8ec11/ : SUCCESS in 57s","accounts_in_message":[],"_revision_number":2},{"id":"06736bccc72a95c1c91aa67186e8d0b16d672af7","author":{"_account_id":13348,"name":"Allan Greentree","email":"agreentree@suse.com","username":"greental"},"date":"2015-03-23 15:09:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ca2ba470cb389c842ff90d66d868b49a61fda9e3","author":{"_account_id":12108,"name":"Gary Hessler","email":"gary.hessler@hp.com","username":"garyh"},"date":"2015-03-23 15:17:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a4e61f9ea26076d756448a365e1533337328d35a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-23 15:17:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"ec6ab4203d352ce181734f9923fcc8412e3bf10b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-23 15:19:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-monasca-agent-pep8 http://logs.openstack.org/50/166350/2/gate/gate-monasca-agent-pep8/be3c6f4/ : SUCCESS in 54s\n- gate-monasca-agent-python27 http://logs.openstack.org/50/166350/2/gate/gate-monasca-agent-python27/696619b/ : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2},{"id":"dd1fb6183ba160dcedaa0f2ab9ff145d23468a7c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-23 15:19:11.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1f6b67c79a4501e3d5489ae81de6f6f0b74027a3","revisions":{"82df138ef6efeb7bba04d3fea00832175a12b431":{"kind":"REWORK","_number":1,"created":"2015-03-20 19:09:34.000000000","uploader":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"ref":"refs/changes/50/166350/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/50/166350/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/1"}}},"commit":{"parents":[{"commit":"9233bd557d51d2163caee7ad56ba49ae5556fe6f","subject":"Fixing issue with disk metrics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/9233bd557d51d2163caee7ad56ba49ae5556fe6f"}]}],"author":{"name":"David Schroeder","email":"david.schroeder@hp.com","date":"2015-03-20 18:33:56.000000000","tz":-360},"committer":{"name":"David Schroeder","email":"david.schroeder@hp.com","date":"2015-03-20 18:33:56.000000000","tz":-360},"subject":"Update default filesystems ignored by disk check","message":"Update default filesystems ignored by disk check\n\nThere are several filesystem times that it makes sense to ignore.\nUpdate the default ignore list to include these.\n\nChange-Id: I031fff5f2cd2b4b62dfec0f5e1e5c86df4c76f52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/82df138ef6efeb7bba04d3fea00832175a12b431"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/82df138ef6efeb7bba04d3fea00832175a12b431"}]},"branch":"refs/heads/master"},"1f6b67c79a4501e3d5489ae81de6f6f0b74027a3":{"kind":"REWORK","_number":2,"created":"2015-03-20 21:00:17.000000000","uploader":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"ref":"refs/changes/50/166350/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/50/166350/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/50/166350/2"}}},"commit":{"parents":[{"commit":"9233bd557d51d2163caee7ad56ba49ae5556fe6f","subject":"Fixing issue with disk metrics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/9233bd557d51d2163caee7ad56ba49ae5556fe6f"}]}],"author":{"name":"David Schroeder","email":"david.schroeder@hp.com","date":"2015-03-20 18:33:56.000000000","tz":-360},"committer":{"name":"David Schroeder","email":"david.schroeder@hp.com","date":"2015-03-20 20:57:53.000000000","tz":-360},"subject":"Update default filesystems ignored by disk check","message":"Update default filesystems ignored by disk check\n\nThere are several filesystem times that it makes sense to ignore.\nUpdate the default ignore list to include these.\n\nChange-Id: I031fff5f2cd2b4b62dfec0f5e1e5c86df4c76f52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/1f6b67c79a4501e3d5489ae81de6f6f0b74027a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/1f6b67c79a4501e3d5489ae81de6f6f0b74027a3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}