)]}'
{"monasca_setup/detection/plugins/swift.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"27e55da87d9b6c9ba7a0d2987e55faad5d0e0996","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def get_command(command, attribute):"},{"line_number":15,"context_line":"    return \u0027%s --%s\u0027 % (command, attribute)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def get_instances(command, attributes):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_7e30d101","line":15,"updated":"2015-04-02 22:52:00.000000000","message":"In our new code we have been trying to stick with python string formatting, ie\nreturn \u0027{0} --{1}\u0027.format(command, attribute)","commit_id":"a87d2d97bbd3932146305b8896e492812ac68f3c"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"5e2aa3cef8391c5b81519a8d1bcf337b1bce8a5b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def get_command(command, attribute):"},{"line_number":15,"context_line":"    return \u0027%s --%s\u0027 % (command, attribute)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def get_instances(command, attributes):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_1fac1c9f","line":15,"in_reply_to":"baa041b7_7e30d101","updated":"2015-04-03 04:34:00.000000000","message":"Thank you for introducing to .format construct. wasn\u0027t aware of.","commit_id":"a87d2d97bbd3932146305b8896e492812ac68f3c"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"27e55da87d9b6c9ba7a0d2987e55faad5d0e0996","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for attribute in attributes:"},{"line_number":24,"context_line":"        cmd \u003d dict()"},{"line_number":25,"context_line":"        cmd[\u0027name\u0027] \u003d \u0027%s.%s\u0027 % (\u0027swift\u0027, attribute)"},{"line_number":26,"context_line":"        cmd[\u0027check_command\u0027] \u003d get_command(command, attribute)"},{"line_number":27,"context_line":"        cmd[\u0027check_interval\u0027] \u003d 60"},{"line_number":28,"context_line":"        cmd[\u0027dimensions\u0027] \u003d {\u0027service\u0027: \u0027swift\u0027}"},{"line_number":29,"context_line":"        instances.append(cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_7e07b11c","line":26,"updated":"2015-04-02 22:52:00.000000000","message":"Given the simplicity of the get_command method is there really any need for it rather than just\n\u0027{0} --{1}\u0027.format(command, attribute)","commit_id":"a87d2d97bbd3932146305b8896e492812ac68f3c"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"5e2aa3cef8391c5b81519a8d1bcf337b1bce8a5b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    for attribute in attributes:"},{"line_number":24,"context_line":"        cmd \u003d dict()"},{"line_number":25,"context_line":"        cmd[\u0027name\u0027] \u003d \u0027%s.%s\u0027 % (\u0027swift\u0027, attribute)"},{"line_number":26,"context_line":"        cmd[\u0027check_command\u0027] \u003d get_command(command, attribute)"},{"line_number":27,"context_line":"        cmd[\u0027check_interval\u0027] \u003d 60"},{"line_number":28,"context_line":"        cmd[\u0027dimensions\u0027] \u003d {\u0027service\u0027: \u0027swift\u0027}"},{"line_number":29,"context_line":"        instances.append(cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_ffae1897","line":26,"in_reply_to":"baa041b7_7e07b11c","updated":"2015-04-03 04:34:00.000000000","message":"Agree.","commit_id":"a87d2d97bbd3932146305b8896e492812ac68f3c"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"498eabeeeb68aea2469f3db19a7969ee93e39589","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import monasca_setup.detection"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"DIAG_COMMAND \u003d \u0027/usr/local/bin/diagnostics\u0027"},{"line_number":6,"context_line":"CHECKER_COMMAND \u003d \u0027/usr/local/bin/swift-checker\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"diag_attributes \u003d [\u0027check_mounts\u0027, \u0027disk_monitoring\u0027, \u0027file_ownership\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_4af89249","line":5,"updated":"2015-04-03 15:50:06.000000000","message":"This is a pretty ambiguous name for this script. Any chance that we can make this more descriptive? For example \"swift-diagnostics\".","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"409a2829c843a99b28ede09feac558aa96a6c9f5","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import monasca_setup.detection"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"DIAG_COMMAND \u003d \u0027/usr/local/bin/diagnostics\u0027"},{"line_number":6,"context_line":"CHECKER_COMMAND \u003d \u0027/usr/local/bin/swift-checker\u0027"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"diag_attributes \u003d [\u0027check_mounts\u0027, \u0027disk_monitoring\u0027, \u0027file_ownership\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_007937f6","line":5,"in_reply_to":"baa041b7_4af89249","updated":"2015-04-05 03:16:32.000000000","message":"The script used is of another package swift-diags. So the contents of that package needs to change and nothing to do with monasca-agent. SO its upto that package authors to change name and we are using that here.","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"498eabeeeb68aea2469f3db19a7969ee93e39589","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        cmd[\u0027name\u0027] \u003d \u0027{0}.{1}\u0027.format(\u0027swift\u0027, attribute)"},{"line_number":22,"context_line":"        cmd[\u0027check_command\u0027] \u003d \u0027{0} --{1}\u0027.format(command, attribute)"},{"line_number":23,"context_line":"        cmd[\u0027check_interval\u0027] \u003d 60"},{"line_number":24,"context_line":"        cmd[\u0027dimensions\u0027] \u003d {\u0027service\u0027: \u0027swift\u0027}"},{"line_number":25,"context_line":"        instances.append(cmd)"},{"line_number":26,"context_line":"    return instances"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_4aee52b5","line":24,"updated":"2015-04-03 15:50:06.000000000","message":"The convention that we\u0027ve been reporting for the service is \"object-storage\", not \"swift\".\n\nTo identity the specify component within a service we\u0027ve been using the convention \"componet\".\n\nI\u0027m not as familary with swift, but for nova we report service\u003d\"comptue\" and then component\u003d\"nova-api\", ...","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"409a2829c843a99b28ede09feac558aa96a6c9f5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        cmd[\u0027name\u0027] \u003d \u0027{0}.{1}\u0027.format(\u0027swift\u0027, attribute)"},{"line_number":22,"context_line":"        cmd[\u0027check_command\u0027] \u003d \u0027{0} --{1}\u0027.format(command, attribute)"},{"line_number":23,"context_line":"        cmd[\u0027check_interval\u0027] \u003d 60"},{"line_number":24,"context_line":"        cmd[\u0027dimensions\u0027] \u003d {\u0027service\u0027: \u0027swift\u0027}"},{"line_number":25,"context_line":"        instances.append(cmd)"},{"line_number":26,"context_line":"    return instances"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_e073f313","line":24,"in_reply_to":"baa041b7_4aee52b5","updated":"2015-04-05 03:16:32.000000000","message":"Personally feel swift is a better mnemonic than object-storage, since it straightforward defines the component. Moreover, this convention was there earlier too. I just segregated it into individual metrics.","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"498eabeeeb68aea2469f3db19a7969ee93e39589","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        config \u003d super(Swift, self).build_config()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/usr/local/bin/diagnostics\u0027) and \\"},{"line_number":67,"context_line":"                os.path.exists(\u0027/usr/local/bin/swift-checker\u0027):"},{"line_number":68,"context_line":"            config[\u0027nagios_wrapper\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":69,"context_line":"                                        \u0027instances\u0027: get_config_instances(),"},{"line_number":70,"context_line":"                                        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_6a4a36c7","line":67,"updated":"2015-04-03 15:50:06.000000000","message":"Might want to use DIAG_COMMAND and CHECKER_COMMAND declared up above.","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"409a2829c843a99b28ede09feac558aa96a6c9f5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        config \u003d super(Swift, self).build_config()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if os.path.exists(\u0027/usr/local/bin/diagnostics\u0027) and \\"},{"line_number":67,"context_line":"                os.path.exists(\u0027/usr/local/bin/swift-checker\u0027):"},{"line_number":68,"context_line":"            config[\u0027nagios_wrapper\u0027] \u003d {\u0027init_config\u0027: None,"},{"line_number":69,"context_line":"                                        \u0027instances\u0027: get_config_instances(),"},{"line_number":70,"context_line":"                                        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_406f3f2b","line":67,"in_reply_to":"baa041b7_6a4a36c7","updated":"2015-04-05 03:16:32.000000000","message":"Done","commit_id":"94289c245e9140fc22888ea7147958dac8dceccd"}]}