)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"18641d662d689a52e0bd0d2c4a78f01c8259401c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                      \u0027ram\u0027: \u0027nova.vm.mem.total_allocated_mb\u0027,"},{"line_number":155,"context_line":"                      \u0027disk\u0027: \u0027nova.vm.disk.total_allocated_gb\u0027}"},{"line_number":156,"context_line":"        agg_values \u003d {}"},{"line_number":157,"context_line":"        for gauge in agg_gauges:"},{"line_number":158,"context_line":"            agg_values[gauge] \u003d 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        insp \u003d inspector.get_hypervisor_inspector()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_c3b96130","line":157,"updated":"2015-04-16 17:07:15.000000000","message":"Based on the code where this is used, I think it should be:\nfor gauge in agg_guages.keys():","commit_id":"8ad4be9d5205d4cfd94aace7a09884f2c5126866"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"11ffa6beedbe9dcd5c6f5a92c3b100a3773d5ef1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                      \u0027ram\u0027: \u0027nova.vm.mem.total_allocated_mb\u0027,"},{"line_number":155,"context_line":"                      \u0027disk\u0027: \u0027nova.vm.disk.total_allocated_gb\u0027}"},{"line_number":156,"context_line":"        agg_values \u003d {}"},{"line_number":157,"context_line":"        for gauge in agg_gauges:"},{"line_number":158,"context_line":"            agg_values[gauge] \u003d 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        insp \u003d inspector.get_hypervisor_inspector()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_e379fd30","line":157,"in_reply_to":"5aa745d1_c3b96130","updated":"2015-04-16 17:17:08.000000000","message":"PEP 234 indicates that \"for gauge in agg_gauges:\" is faster than \"for gauge in agg_gauges.keys():\"","commit_id":"8ad4be9d5205d4cfd94aace7a09884f2c5126866"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a9e4a9158a18db6be53aea7f6abecf33b873c33c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                      \u0027ram\u0027: \u0027nova.vm.mem.total_allocated_mb\u0027,"},{"line_number":155,"context_line":"                      \u0027disk\u0027: \u0027nova.vm.disk.total_allocated_gb\u0027}"},{"line_number":156,"context_line":"        agg_values \u003d {}"},{"line_number":157,"context_line":"        for gauge in agg_gauges:"},{"line_number":158,"context_line":"            agg_values[gauge] \u003d 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        insp \u003d inspector.get_hypervisor_inspector()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_1e96804c","line":157,"in_reply_to":"5aa745d1_e379fd30","updated":"2015-04-16 17:50:58.000000000","message":"That is just weird. But you are obviously right. Sorry","commit_id":"8ad4be9d5205d4cfd94aace7a09884f2c5126866"}]}
