)]}'
{"monasca_setup/main.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"60daba7f569c89cd02b5a6993e45765baf873490","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Don\u0027t restart if only doing detection plugins and no changes found"},{"line_number":189,"context_line":"    if args.detection_plugins is not None and not changes:"},{"line_number":190,"context_line":"        log.info(\u0027No changes found\u0027)"},{"line_number":191,"context_line":"        return 0"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # Now that the config is built, start the service"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_f163d83f","line":190,"updated":"2015-05-01 17:09:55.000000000","message":"Would like to see a more clarifying message when nothing needs to be changed. For example: No changes found for the detection plugins monasca-agent not restarting. Ideally it could also include the list of plugins that were not changed so the user can see that information","commit_id":"fe48e77d49903d5d8f102433cbb975e516eac1a3"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"2ffc5e738d1db813e3eb612864ff00551e3c657c","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Don\u0027t restart if only doing detection plugins and no changes found"},{"line_number":189,"context_line":"    if args.detection_plugins is not None and not changes:"},{"line_number":190,"context_line":"        plugin_names \u003d [p.__name__ for p in plugins]"},{"line_number":191,"context_line":"        log.info(\u0027No changes found for plugins {0}, skipping restart of Monasca Agent\u0027.format(plugin_names))"},{"line_number":192,"context_line":"        return 0"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_944012a7","line":190,"updated":"2015-05-01 17:43:07.000000000","message":"Should this be plugin_names \u003d [p.__name__ for p in DETECTION_PLUGINS] with the plugins I get nothing to return for DETECTION_PLUGINS I get the list back","commit_id":"a3a77ba227f49f1f0b2f27fdef839fa94e3087cf"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"cccc616b91c1afe45538be4cabf20c7892bc3cf4","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Don\u0027t restart if only doing detection plugins and no changes found"},{"line_number":189,"context_line":"    if args.detection_plugins is not None and not changes:"},{"line_number":190,"context_line":"        plugin_names \u003d [p.__name__ for p in plugins]"},{"line_number":191,"context_line":"        log.info(\u0027No changes found for plugins {0}, skipping restart of Monasca Agent\u0027.format(plugin_names))"},{"line_number":192,"context_line":"        return 0"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_82cb3453","line":190,"in_reply_to":"3acd31a7_17008400","updated":"2015-05-01 18:54:54.000000000","message":"I was running the same thing just when I forgot to give it a plugin so just monasca-setup -d it returned an empty list","commit_id":"a3a77ba227f49f1f0b2f27fdef839fa94e3087cf"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"024435dd75a594756948454b9ad6eda79abbab4b","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    # Don\u0027t restart if only doing detection plugins and no changes found"},{"line_number":189,"context_line":"    if args.detection_plugins is not None and not changes:"},{"line_number":190,"context_line":"        plugin_names \u003d [p.__name__ for p in plugins]"},{"line_number":191,"context_line":"        log.info(\u0027No changes found for plugins {0}, skipping restart of Monasca Agent\u0027.format(plugin_names))"},{"line_number":192,"context_line":"        return 0"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_17008400","line":190,"in_reply_to":"3acd31a7_944012a7","updated":"2015-05-01 17:57:30.000000000","message":"No DETECTION_PLUGINS is all of the available plugins, plugins should be the list that were selected fro this particular run. The fact that it was empty for you is odd, what was your command line? This is what I get:\n(monasca)root@mini-mon:~# monasca-setup -d ntp                                                                                                                 \nINFO: Configuring Ntp\nINFO:   Enabling the ntp plugin\nINFO: No changes found for plugins [\u0027Ntp\u0027], skipping restart of Monasca Agent","commit_id":"a3a77ba227f49f1f0b2f27fdef839fa94e3087cf"}]}