)]}'
{"monasca_agent/collector/checks_d/mk_livestatus.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"cdbb923c5d937ca161eb7e6e4d11176bf832a1fa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":24,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_status_event(self, status, msg, instance):"},{"line_number":27,"context_line":"        \"\"\"Does nothing: status events are not yet supported by Mon API."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_25a8951f","line":26,"updated":"2015-05-05 22:20:03.000000000","message":"Clearly not something to tackle for this review but I can\u0027t help thinking we should pulls this from the collector altogether.","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"}],"monasca_setup/detection/plugins/check_mk_local.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"a3ba662ab32f76393890b2b998685c5b69e695a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1aca2d91_a9263b66","updated":"2015-05-06 22:43:57.000000000","message":"Should you have a file header? This comment would apply to a bunch of files.","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"3d85f9eb6181ddb19209541c3c1a59cb8274997e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1aca2d91_59e18c99","in_reply_to":"1aca2d91_a9263b66","updated":"2015-05-07 19:28:42.000000000","message":"I added a docstring to this file, and copyright info to the collector plugins.","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"a3ba662ab32f76393890b2b998685c5b69e695a2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                        \u0027/usr/local/bin/check_mk_agent\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class Check_MK_Local(monasca_setup.detection.Plugin):"},{"line_number":13,"context_line":"    \"\"\"Identify existance of check_mk_agent by looking for the executable."},{"line_number":14,"context_line":"       The check_mk_agent process itself does not need to be running in order"},{"line_number":15,"context_line":"       for this plugin to work, the agent program itself can return local data."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_296d8b98","line":12,"updated":"2015-05-06 22:43:57.000000000","message":"I think this should be named CheckMkLocal following the conventions for class names.","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"3d85f9eb6181ddb19209541c3c1a59cb8274997e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                        \u0027/usr/local/bin/check_mk_agent\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class Check_MK_Local(monasca_setup.detection.Plugin):"},{"line_number":13,"context_line":"    \"\"\"Identify existance of check_mk_agent by looking for the executable."},{"line_number":14,"context_line":"       The check_mk_agent process itself does not need to be running in order"},{"line_number":15,"context_line":"       for this plugin to work, the agent program itself can return local data."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_7c8afbc0","line":12,"in_reply_to":"1aca2d91_296d8b98","updated":"2015-05-07 19:28:42.000000000","message":"Done","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"83dcc2c1cfd5a7c167d801af200d614de592b576","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                        \u0027/usr/local/bin/check_mk_agent\u0027]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"class Check_MK_Local(monasca_setup.detection.Plugin):"},{"line_number":13,"context_line":"    \"\"\"Identify existance of check_mk_agent by looking for the executable."},{"line_number":14,"context_line":"       The check_mk_agent process itself does not need to be running in order"},{"line_number":15,"context_line":"       for this plugin to work, the agent program itself can return local data."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_9992849e","line":12,"in_reply_to":"1aca2d91_296d8b98","updated":"2015-05-07 19:11:22.000000000","message":"Good catch Roland, https://www.python.org/dev/peps/pep-0008/#class-names","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"}],"monasca_setup/detection/plugins/mk_livestatus.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"cdbb923c5d937ca161eb7e6e4d11176bf832a1fa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                with open(cfg_file) as cfg:"},{"line_number":46,"context_line":"                    for line in cfg:"},{"line_number":47,"context_line":"                        if line.startswith(\u0027broker_module\u0027) and line.find(\u0027mk\u0027) \u003e 0:"},{"line_number":48,"context_line":"                            socket_path \u003d line.split(\u0027 \u0027)[-1].rstrip()"},{"line_number":49,"context_line":"        return(socket_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _detect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_af9c860e","line":48,"updated":"2015-05-05 22:20:03.000000000","message":"It seems you should stop searching once you have found the socket path. ie return line.split(\u0027 \u0027)[-1].rstrip() here and just return None at the end of the file, no socket_path var needed.","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"3d85f9eb6181ddb19209541c3c1a59cb8274997e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                with open(cfg_file) as cfg:"},{"line_number":46,"context_line":"                    for line in cfg:"},{"line_number":47,"context_line":"                        if line.startswith(\u0027broker_module\u0027) and line.find(\u0027mk\u0027) \u003e 0:"},{"line_number":48,"context_line":"                            socket_path \u003d line.split(\u0027 \u0027)[-1].rstrip()"},{"line_number":49,"context_line":"        return(socket_path)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _detect(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_5c85ffaa","line":48,"in_reply_to":"3acd31a7_af9c860e","updated":"2015-05-07 19:28:42.000000000","message":"Done","commit_id":"88d693769a637e833b41c6147e36c9cee56e02dc"}]}