)]}'
{"monasca_setup/detection/plugin.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1dafc2c1990e140466d03dc427b34401e106960e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        self.dependencies \u003d ()"},{"line_number":19,"context_line":"        self.overwrite \u003d overwrite"},{"line_number":20,"context_line":"        if args is None:"},{"line_number":21,"context_line":"            self.args \u003d args"},{"line_number":22,"context_line":"        else:"},{"line_number":23,"context_line":"            try:"},{"line_number":24,"context_line":"                # Turn \u0027hostname\u003dhost type\u003dping\u0027 to dictionary {\u0027hostname\u0027: \u0027host\u0027, \u0027type\u0027: \u0027ping\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_1859035b","line":21,"updated":"2015-05-12 22:42:30.000000000","message":"Setting self.args \u003d args which is None. Is that what you want? Do you want this to be an empty dict?\n\nAlso, as a coding style, could initialize self.args \u003d {} or something, and then only then\n\nif args is not None:\n    self.args \u003d dict([a.split(\u0027\u003d\u0027) for a in args.split()])\n\nand avoid the else completely.","commit_id":"1498e5209532dc6a285c84ec16e12401ac5d279f"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"e186298ccd09f973f9d8e0d046bf83e31d7e18c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        self.dependencies \u003d ()"},{"line_number":19,"context_line":"        self.overwrite \u003d overwrite"},{"line_number":20,"context_line":"        if args is None:"},{"line_number":21,"context_line":"            self.args \u003d args"},{"line_number":22,"context_line":"        else:"},{"line_number":23,"context_line":"            try:"},{"line_number":24,"context_line":"                # Turn \u0027hostname\u003dhost type\u003dping\u0027 to dictionary {\u0027hostname\u0027: \u0027host\u0027, \u0027type\u0027: \u0027ping\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_9bb4cdf2","line":21,"in_reply_to":"9a0c5dc1_1859035b","updated":"2015-05-12 22:51:17.000000000","message":"I need to define self.args as something, an empty dict should work but None works also and is explicit as not set rather than set to nothing. Perhaps it would be better to do self.args \u003d None then after that if args is not None, I can go either way with it.","commit_id":"1498e5209532dc6a285c84ec16e12401ac5d279f"}],"monasca_setup/detection/plugins/http_check.py":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"cb7eb92ba609f3aa9c2ad4a1ab93ca3b604c4265","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # nearly any specified arg will get passed to the config but some I overwrite and args that are a dictionary"},{"line_number":31,"context_line":"        # themselves are not likely parsed correctly"},{"line_number":32,"context_line":"        instance \u003d self.args.copy()"},{"line_number":33,"context_line":"        instance[\u0027name\u0027] \u003d self.args[\u0027url\u0027]"},{"line_number":34,"context_line":"        instance[\u0027collect_response_time\u0027] \u003d True"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        config[\u0027http_check\u0027] \u003d {\u0027init_config\u0027: None, \u0027instances\u0027: [instance]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_75d6cac6","line":33,"updated":"2015-05-12 22:03:40.000000000","message":"Should you be checking if the optional arg names (disable_ssl_validation, match_pattern) are input?","commit_id":"1498e5209532dc6a285c84ec16e12401ac5d279f"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"5d53962e936bd1a8feca45c2e095d4b3001d138e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # nearly any specified arg will get passed to the config but some I overwrite and args that are a dictionary"},{"line_number":31,"context_line":"        # themselves are not likely parsed correctly"},{"line_number":32,"context_line":"        instance \u003d self.args.copy()"},{"line_number":33,"context_line":"        instance[\u0027name\u0027] \u003d self.args[\u0027url\u0027]"},{"line_number":34,"context_line":"        instance[\u0027collect_response_time\u0027] \u003d True"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        config[\u0027http_check\u0027] \u003d {\u0027init_config\u0027: None, \u0027instances\u0027: [instance]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_f81d0fbe","line":33,"in_reply_to":"9a0c5dc1_75d6cac6","updated":"2015-05-12 22:27:43.000000000","message":"I was taking the approach that these will just be added to the config and the check plugin will do any validation when it tries to run. That way this detection plugin doesn\u0027t need to be updated when new options are added.","commit_id":"1498e5209532dc6a285c84ec16e12401ac5d279f"}]}