)]}'
{"monasca_setup/detection/plugins/mon.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"24b8269a22a2af750c9e6882d1fd91af61b4566d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        if monasca_api is not None:"},{"line_number":22,"context_line":"            # monasca-api can show up in urls and be an arg to this setup program, check port also"},{"line_number":23,"context_line":"            for conn in monasca_api.connections(\u0027inet\u0027):"},{"line_number":24,"context_line":"                if conn.laddr[1] \u003d\u003d 8080:"},{"line_number":25,"context_line":"                    self.available \u003d True"},{"line_number":26,"context_line":"                    return"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_b8d76522","line":24,"updated":"2015-05-17 02:59:28.000000000","message":"How can we handle if this is configured to not be the default port of 8080?","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"d06929c89f9b1330d4846633580670084f1d4d48","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        if monasca_api is not None:"},{"line_number":22,"context_line":"            # monasca-api can show up in urls and be an arg to this setup program, check port also"},{"line_number":23,"context_line":"            for conn in monasca_api.connections(\u0027inet\u0027):"},{"line_number":24,"context_line":"                if conn.laddr[1] \u003d\u003d 8080:"},{"line_number":25,"context_line":"                    self.available \u003d True"},{"line_number":26,"context_line":"                    return"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_55102401","line":24,"in_reply_to":"7a016987_b8d76522","updated":"2015-05-18 14:41:00.000000000","message":"Right now if it isn\u0027t the standard port this detection just doesn\u0027t find it and the config must be done by hand. I like the idea of detecting it better though, likely we need to parse the config for that to work. I think that is another review.","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"24b8269a22a2af750c9e6882d1fd91af61b4566d","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def build_config(self):"},{"line_number":29,"context_line":"        \"\"\"Build the config as a Plugins object and return.\"\"\""},{"line_number":30,"context_line":"        log.info(\"\\tEnabling the mon api healthcheck\")"},{"line_number":31,"context_line":"        return dropwizard_health_check(\u0027monitoring\u0027, \u0027api\u0027, \u0027http://localhost:8081/healthcheck\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # todo"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_d8d46121","line":30,"updated":"2015-05-17 02:59:28.000000000","message":"s/mon/Monasca","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"24b8269a22a2af750c9e6882d1fd91af61b4566d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def build_config(self):"},{"line_number":29,"context_line":"        \"\"\"Build the config as a Plugins object and return.\"\"\""},{"line_number":30,"context_line":"        log.info(\"\\tEnabling the mon api healthcheck\")"},{"line_number":31,"context_line":"        return dropwizard_health_check(\u0027monitoring\u0027, \u0027api\u0027, \u0027http://localhost:8081/healthcheck\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        # todo"},{"line_number":34,"context_line":"        # log.info(\"\\tEnabling the mon api metric collection\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_5822b153","line":31,"updated":"2015-05-17 02:59:28.000000000","message":"How should we handle when the health check is on a different port?","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"24b8269a22a2af750c9e6882d1fd91af61b4566d","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def build_config(self):"},{"line_number":65,"context_line":"        \"\"\"Build the config as a Plugins object and return.\"\"\""},{"line_number":66,"context_line":"        log.info(\"\\tEnabling the mon persister healthcheck\")"},{"line_number":67,"context_line":"        return dropwizard_health_check(\u0027monitoring\u0027, \u0027persister\u0027, \u0027http://localhost:8091/healthcheck\u0027)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # todo"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_78e1edfd","line":66,"updated":"2015-05-17 02:59:28.000000000","message":"s/mon/Monasca","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"24b8269a22a2af750c9e6882d1fd91af61b4566d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"\"\"Detect the running mon-thresh and monitor.\"\"\""},{"line_number":79,"context_line":"    def _detect(self):"},{"line_number":80,"context_line":"        \"\"\"Run detection, set self.available True if the service is detected.\"\"\""},{"line_number":81,"context_line":"        if find_process_cmdline(\u0027backtype.storm.daemon\u0027) is not None:"},{"line_number":82,"context_line":"            self.available \u003d True"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_b8be45d2","line":81,"updated":"2015-05-17 02:59:28.000000000","message":"It would be better if we were actually watching the worker process. We could identify them by -Dworker.port\u003d\n\nOf course, if we could watch nimbus, supervisor and the workers, that would be even better","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"d06929c89f9b1330d4846633580670084f1d4d48","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"\"\"Detect the running mon-thresh and monitor.\"\"\""},{"line_number":79,"context_line":"    def _detect(self):"},{"line_number":80,"context_line":"        \"\"\"Run detection, set self.available True if the service is detected.\"\"\""},{"line_number":81,"context_line":"        if find_process_cmdline(\u0027backtype.storm.daemon\u0027) is not None:"},{"line_number":82,"context_line":"            self.available \u003d True"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def build_config(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_95133cb8","line":81,"in_reply_to":"7a016987_b8be45d2","updated":"2015-05-18 14:41:00.000000000","message":"Good catch, looks like backtype.storm.daemon.worker also works I will use that.","commit_id":"228457daeed75c9af6ee390a2deba9b6dede3952"}]}