)]}'
{"monasca_setup/main.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"1440feed67e3b342e418962c397bea307d64bdd3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        base_configuration(args)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # Collect the set of detection plugins to run"},{"line_number":55,"context_line":"    detected_plugins \u003d utils.discover_plugins(CUSTOM_PLUGIN_PATH)"},{"line_number":56,"context_line":"    if args.system_only:"},{"line_number":57,"context_line":"        from detection.plugins.system import System"},{"line_number":58,"context_line":"        plugins \u003d [System]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_71183385","line":55,"updated":"2015-07-20 17:46:41.000000000","message":"Would it be better to only load this list if we need it?\nSeems a shame to do the full search even when the user only wants system metrics","commit_id":"afb1d280e5291aa3492ae640c541b09936995524"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"e0f939e4e6b45cb489d242d1b46b408ac5b80e11","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        base_configuration(args)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # Collect the set of detection plugins to run"},{"line_number":55,"context_line":"    detected_plugins \u003d utils.discover_plugins(CUSTOM_PLUGIN_PATH)"},{"line_number":56,"context_line":"    if args.system_only:"},{"line_number":57,"context_line":"        from detection.plugins.system import System"},{"line_number":58,"context_line":"        plugins \u003d [System]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_75407f07","line":55,"in_reply_to":"3a50d1a3_0d17c148","updated":"2015-07-23 04:49:31.000000000","message":"In this case since this is a script that is run infrequently and it doesn\u0027t take very long to crawl the filesystem I\u0027d lean towards making the code easy.  I\u0027d be surprised if we noticed any real difference in runtime if we didn\u0027t just do this every time.","commit_id":"afb1d280e5291aa3492ae640c541b09936995524"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"a5ba1804c9bc9e4afbcf7341bfd4b3f39416c7dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        base_configuration(args)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # Collect the set of detection plugins to run"},{"line_number":55,"context_line":"    detected_plugins \u003d utils.discover_plugins(CUSTOM_PLUGIN_PATH)"},{"line_number":56,"context_line":"    if args.system_only:"},{"line_number":57,"context_line":"        from detection.plugins.system import System"},{"line_number":58,"context_line":"        plugins \u003d [System]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0d17c148","line":55,"in_reply_to":"3a50d1a3_71183385","updated":"2015-07-22 22:41:01.000000000","message":"Maybe, in general avoid work you don\u0027t need but it is only looking for files on the local disk and loading them up, so it isn\u0027t much work and the code would have to be changed to have a nested if inside the else statement rather than if/elif/else so it would be a tiny bit uglier. I could go either way.","commit_id":"afb1d280e5291aa3492ae640c541b09936995524"},{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"f39f72593b0c8b4a5b69aae8f0e8ca89c01a5417","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                   os.path.join(args.config_dir, \u0027supervisor.conf\u0027),"},{"line_number":116,"context_line":"                   {\u0027prefix\u0027: PREFIX_DIR, \u0027log_dir\u0027: args.log_dir, \u0027monasca_user\u0027: args.user},"},{"line_number":117,"context_line":"                   gid)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def modify_config(args, detected_config):"},{"line_number":121,"context_line":"    changes \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2da2bd99","line":118,"updated":"2015-07-22 22:57:45.000000000","message":"Looks like the modify_config could be useful for the HLM update requirement - with this are updates now fully supported?","commit_id":"afb1d280e5291aa3492ae640c541b09936995524"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"04595911c9a48ae3aa539b6be451c04d08005a8b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                   os.path.join(args.config_dir, \u0027supervisor.conf\u0027),"},{"line_number":116,"context_line":"                   {\u0027prefix\u0027: PREFIX_DIR, \u0027log_dir\u0027: args.log_dir, \u0027monasca_user\u0027: args.user},"},{"line_number":117,"context_line":"                   gid)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def modify_config(args, detected_config):"},{"line_number":121,"context_line":"    changes \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e36b5def","line":118,"in_reply_to":"3a50d1a3_2da2bd99","updated":"2015-07-23 14:15:15.000000000","message":"Yes that is exactly the use case that has prompted adding this feature. With this service teams can easily remove config and do the HLM update tasks they need.","commit_id":"afb1d280e5291aa3492ae640c541b09936995524"}]}