)]}'
{"monasca_agent/common/aggregator.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"0e6042738a329421763fa6a09e48cd5f1e372058","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        invalid_chars \u003d \"\u003c\u003e\u003d{}(),\u0027\\\"\\\\\\\\;\u0026\""},{"line_number":147,"context_line":"        restricted_chars \u003d re.compile(\u0027[\u0027 + invalid_chars + \u0027]\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if dimensions:"},{"line_number":150,"context_line":"            for k,v in dimensions:"},{"line_number":151,"context_line":"                if restricted_chars.search(k):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_f6e93de7","line":148,"updated":"2015-07-22 02:33:24.000000000","message":"Does it make sense to move these two statements to the top of the file?\n\nAlso, am wondering if you should check the length of the name and key, value.","commit_id":"12647bba3a377cb7888f56686794b7bf3fded34b"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"251023c3f41a0c928654b9366bde0b922468ef58","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        invalid_chars \u003d \"\u003c\u003e\u003d{}(),\u0027\\\"\\\\\\\\;\u0026\""},{"line_number":147,"context_line":"        restricted_chars \u003d re.compile(\u0027[\u0027 + invalid_chars + \u0027]\u0027)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if dimensions:"},{"line_number":150,"context_line":"            for k,v in dimensions:"},{"line_number":151,"context_line":"                if restricted_chars.search(k):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_16caa94e","line":148,"in_reply_to":"3a50d1a3_f6e93de7","updated":"2015-07-22 02:38:33.000000000","message":"Yeah, that would make sense.  No point compiling the expression each time we hit the function.\n\nShould we just do all the validation that we would do in the API in the agent as well?  If we add the length checks then the only thing we wouldn\u0027t have is some basic type checks.","commit_id":"12647bba3a377cb7888f56686794b7bf3fded34b"}]}