)]}'
{"monasca_setup/detection/plugins/haproxy.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0e6a3f45149863d78537fa387cf96aed83f9d12f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    port \u003d listen_socket[1].strip()"},{"line_number":51,"context_line":"                    url \u003d \u0027http://{0}:{1}\u0027.format(host, port)"},{"line_number":52,"context_line":"                if url is not None and line.strip().startswith(\u0027stats auth\u0027):"},{"line_number":53,"context_line":"                    auth \u003d re.search(\u0027stats auth\\s(.*)\u0027, line).group(1).split(\u0027:\u0027)"},{"line_number":54,"context_line":"                    user \u003d auth[0].strip()"},{"line_number":55,"context_line":"                    password \u003d auth[1].strip()"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_b67487fd","line":53,"updated":"2015-08-03 22:30:50.000000000","message":"Shouldn\u0027t this be a split(\u0027:\u0027, 2)? That would allow a : to be in the password","commit_id":"ffc8b5d1371c56edf2cae59925ee900ee23db260"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"af17e16b76fbb22805e1a62a35ce23c0dc995d62","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    port \u003d listen_socket[1].strip()"},{"line_number":51,"context_line":"                    url \u003d \u0027http://{0}:{1}\u0027.format(host, port)"},{"line_number":52,"context_line":"                if url is not None and line.strip().startswith(\u0027stats auth\u0027):"},{"line_number":53,"context_line":"                    auth \u003d re.search(\u0027stats auth\\s(.*)\u0027, line).group(1).split(\u0027:\u0027)"},{"line_number":54,"context_line":"                    user \u003d auth[0].strip()"},{"line_number":55,"context_line":"                    password \u003d auth[1].strip()"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5618a384","line":53,"in_reply_to":"1a4dcd0f_b67487fd","updated":"2015-08-03 22:34:10.000000000","message":"Yes good catch.","commit_id":"ffc8b5d1371c56edf2cae59925ee900ee23db260"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0e6a3f45149863d78537fa387cf96aed83f9d12f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                if url is not None and line.strip().startswith(\u0027stats auth\u0027):"},{"line_number":53,"context_line":"                    auth \u003d re.search(\u0027stats auth\\s(.*)\u0027, line).group(1).split(\u0027:\u0027)"},{"line_number":54,"context_line":"                    user \u003d auth[0].strip()"},{"line_number":55,"context_line":"                    password \u003d auth[1].strip()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            if url is None:"},{"line_number":58,"context_line":"                log.warn(\u0027Unable to parse haproxy config for stats url, skipping HAProxy check plugin configuration\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_96938bfa","line":55,"updated":"2015-08-03 22:30:50.000000000","message":"Seems like there is no way for the user to configure a password with a leading or trailing blank if we do this. But, I\u0027m not sure there is anything we can do about that.","commit_id":"ffc8b5d1371c56edf2cae59925ee900ee23db260"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"af17e16b76fbb22805e1a62a35ce23c0dc995d62","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                if url is not None and line.strip().startswith(\u0027stats auth\u0027):"},{"line_number":53,"context_line":"                    auth \u003d re.search(\u0027stats auth\\s(.*)\u0027, line).group(1).split(\u0027:\u0027)"},{"line_number":54,"context_line":"                    user \u003d auth[0].strip()"},{"line_number":55,"context_line":"                    password \u003d auth[1].strip()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            if url is None:"},{"line_number":58,"context_line":"                log.warn(\u0027Unable to parse haproxy config for stats url, skipping HAProxy check plugin configuration\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f910c050","line":55,"in_reply_to":"1a4dcd0f_96938bfa","updated":"2015-08-03 22:34:10.000000000","message":"If the password is quoted it should be possible to have spaces. It would have to be quoted anyway for haproxy.cfg itself to handle spaces.","commit_id":"ffc8b5d1371c56edf2cae59925ee900ee23db260"}]}