)]}'
{"monasca_setup/detection/plugins/trove.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"d2a3cd24ac5dcb1bb67773a9fad316dc95be28c4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":13,"context_line":"            \u0027service_name\u0027: \u0027database\u0027,"},{"line_number":14,"context_line":"            \u0027process_names\u0027: [\u0027trove-api\u0027, \u0027trove-taskmanager\u0027, \u0027trove-conductor\u0027],"},{"line_number":15,"context_line":"            \u0027service_api_url\u0027: \u0027http://localhost:8779/v1\u0027,"},{"line_number":16,"context_line":"            \u0027search_pattern\u0027: \u0027.*v1.*\u0027"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_51f14194","line":15,"updated":"2015-09-10 03:52:21.000000000","message":"The Ironic team put a similar plugin up for review and ultimately we decided that the service_api_url should be configurable because Ironic was not always bound to localhost.  Is that something that Trove needs as well?","commit_id":"8fa46e39914c743c02004b5f473251019fc38214"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"902f55197e3ae044bb1f84dfd30589d9ea05fa6f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":13,"context_line":"            \u0027service_name\u0027: \u0027database\u0027,"},{"line_number":14,"context_line":"            \u0027process_names\u0027: [\u0027trove-api\u0027, \u0027trove-taskmanager\u0027, \u0027trove-conductor\u0027],"},{"line_number":15,"context_line":"            \u0027service_api_url\u0027: \u0027http://localhost:8779/v1\u0027,"},{"line_number":16,"context_line":"            \u0027search_pattern\u0027: \u0027.*v1.*\u0027"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_e36c2738","line":15,"in_reply_to":"da20952f_2d576ecb","updated":"2015-09-10 20:10:52.000000000","message":"The ServicePlugin class will switch to another local ip if the service is listening on something besides localhost, see https://github.com/stackforge/monasca-agent/blob/master/monasca_setup/detection/service_plugin.py#L68","commit_id":"8fa46e39914c743c02004b5f473251019fc38214"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6e2740cf606cb976ac227873fcffb9f192d9bb7d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027overwrite\u0027: overwrite,"},{"line_number":13,"context_line":"            \u0027service_name\u0027: \u0027database\u0027,"},{"line_number":14,"context_line":"            \u0027process_names\u0027: [\u0027trove-api\u0027, \u0027trove-taskmanager\u0027, \u0027trove-conductor\u0027],"},{"line_number":15,"context_line":"            \u0027service_api_url\u0027: \u0027http://localhost:8779/v1\u0027,"},{"line_number":16,"context_line":"            \u0027search_pattern\u0027: \u0027.*v1.*\u0027"},{"line_number":17,"context_line":"        }"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_2d576ecb","line":15,"in_reply_to":"da20952f_51f14194","updated":"2015-09-10 19:12:41.000000000","message":"See https://review.openstack.org/216779. Please add code like the code from that review","commit_id":"8fa46e39914c743c02004b5f473251019fc38214"}]}