)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3332f2f90abe85e8f43561d5445217daefbdf2f1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                    val_diff \u003d value - metric_cache[inst_name][metric_name][vnic[0].name][\u0027value\u0027]"},{"line_number":164,"context_line":"                    if val_diff \u003c 0:"},{"line_number":165,"context_line":"                        # Bad value, save current reading and skip"},{"line_number":166,"context_line":"                        self.log.error(\"Ignoring negative network sample for: \""},{"line_number":167,"context_line":"                                       \"{0} new value: {1} old value: {2}\""},{"line_number":168,"context_line":"                                       .format(inst_name, value,"},{"line_number":169,"context_line":"                                               metric_cache[inst_name][metric_name][vnic[0].name][\u0027value\u0027]))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_fab6ec3c","line":166,"updated":"2015-09-23 14:21:19.000000000","message":"You might want to log.warn instead of an error.","commit_id":"cf70206a9d70c3aa8ce8609c1345ef2953e10e2d"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"e901f54efe796b6300b6b03d8711dc64c510c7ac","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                        metric_cache[inst_name][metric_name][vnic[0].name] \u003d {"},{"line_number":171,"context_line":"                            \u0027timestamp\u0027: sample_time,"},{"line_number":172,"context_line":"                            \u0027value\u0027: value}"},{"line_number":173,"context_line":"                        continue"},{"line_number":174,"context_line":"                    # Change the metric name to a rate, ie. \"net.rx_bytes\""},{"line_number":175,"context_line":"                    # gets converted to \"net.rx_bytes_sec\""},{"line_number":176,"context_line":"                    rate_name \u003d \"{0}_sec\".format(metric_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_90b6aff7","line":173,"updated":"2015-09-23 15:00:21.000000000","message":"The only problem with skipping a measurement would be if it caused an alarm to go to the UNDETERMINED state because there was no measurement during the alarm evaluation period. I\u0027m not sure what to do to avoid that issue, but just wanted to point it out.","commit_id":"56bcaafc01c27b21ce66b3d7fd3e03922307cd54"}]}
