)]}'
{"monasca_setup/main.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"5885e174d3560775b1e3ce2d0b0712e810e0e596","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Now that the config is built, start the service"},{"line_number":87,"context_line":"    if args.plugins_only:"},{"line_number":88,"context_line":"        log.info(\u0027Command line option plugins_only set, so skipping service start\u0027)"},{"line_number":89,"context_line":"    else:"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            agent_service.start(restart\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_7b1b101c","line":88,"updated":"2015-10-06 22:34:27.000000000","message":"I don\u0027t think that plugins_only implies that the agent isn\u0027t restarted. system_only restarts the agent. With this code, if the user does a plugins_only, the plugins configuration files will get created but those configurations won\u0027t be used because the agent hasn\u0027t been restarted. That could be very confusing.\n\nMaybe there should be a separate arg \"skip_restart\" for that behavior?","commit_id":"d89f2231b3b5b2d4ecff4edb656b314463444dfa"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ab4e1f2432a7857a5ca56de5d7bff547127627af","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Now that the config is built, start the service"},{"line_number":87,"context_line":"    if args.plugins_only:"},{"line_number":88,"context_line":"        log.info(\u0027Command line option plugins_only set, so skipping service start\u0027)"},{"line_number":89,"context_line":"    else:"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            agent_service.start(restart\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_52d70eed","line":88,"in_reply_to":"7a2fa921_7b1b101c","updated":"2015-10-07 05:22:48.000000000","message":"I agree with Craig, from the place where I stand it\u0027d be better to explicitly state that restarting is skipped or not.\n\nI am not sure if I understand it correctly, but if that is all about updating/installing plugins configuration, wouldn\u0027t it be better to have option \n\n --install-plugins-only\ninstead of \n --plugins-only \n\nThat seems more verbose to me and clearly states what is going to happen. Along with Craig suggestion it seems like a nice way to increase flexibility here.","commit_id":"d89f2231b3b5b2d4ecff4edb656b314463444dfa"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"1608395b638303a8de325ae58f1f850a5c84abca","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Now that the config is built, start the service"},{"line_number":87,"context_line":"    if args.plugins_only:"},{"line_number":88,"context_line":"        log.info(\u0027Command line option plugins_only set, so skipping service start\u0027)"},{"line_number":89,"context_line":"    else:"},{"line_number":90,"context_line":"        try:"},{"line_number":91,"context_line":"            agent_service.start(restart\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b40bb28d","line":88,"in_reply_to":"7a2fa921_7b1b101c","updated":"2015-10-08 09:41:05.000000000","message":"So for the purposes of this patch there are 5 (?) basic things that monasca_setup does;\n\n1. Create users and groups, configure supervisord, write core agent config\n\n2. Enable supervisord\n\n3. Install base set of plugins\n\n4. Detection and auto-configure extended set of plugins\n\n5. Restart services after plugin detection\n\nThe relevant options that currently exist, including this patch:\n* system_only - skip 4 (does 1,2,3,5)\n* detection_plugins - skip 1,2,3 modify 4 (does 4, 5)\n* skip_enable - skip 2 (does 1,3,4,5)\n* install_plugins_only - skips 1,2,3,5 (does 4)\n\nIf \u0027skip_restart\u0027 were added, and install_plugins_only were changed to still do the restart, then that would mean:\n* install_plugins_only - skips 1,2,3 (does 4, 5)\n* skip_restart - skips 5 (does 1,2,3,4)\n\n...which I\u0027m not sure is significantly less confusing :)","commit_id":"d89f2231b3b5b2d4ecff4edb656b314463444dfa"}]}