)]}'
{"monasca_agent/collector/checks_d/kafka_consumer.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"0d6ce4a0bac5e6366bef7ba357de295a3eaba756","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        topics \u003d collections.defaultdict(set)"},{"line_number":65,"context_line":"        for consumer_group, topic_partitions in consumer_groups.iteritems():"},{"line_number":66,"context_line":"            for topic, partitions in topic_partitions.iteritems():"},{"line_number":67,"context_line":"                kafka_consumer \u003d None"},{"line_number":68,"context_line":"                try:"},{"line_number":69,"context_line":"                    kafka_consumer \u003d consumer.SimpleConsumer(kafka_conn, consumer_group, topic)"},{"line_number":70,"context_line":"                    partitions \u003d kafka_consumer.offsets.keys()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_897ab222","line":67,"updated":"2015-10-01 08:58:45.000000000","message":"This has lost the \"if len(partition) \u003d\u003d 0\" check, so it\u0027ll now always discard the list of partitions from topic_partitions.","commit_id":"35fcf2dd91b04de18fcea919e01d9c6dd3acefed"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4497afbae1a16c6685985b5b349c159131766167","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        topics \u003d collections.defaultdict(set)"},{"line_number":65,"context_line":"        for consumer_group, topic_partitions in consumer_groups.iteritems():"},{"line_number":66,"context_line":"            for topic, partitions in topic_partitions.iteritems():"},{"line_number":67,"context_line":"                kafka_consumer \u003d None"},{"line_number":68,"context_line":"                try:"},{"line_number":69,"context_line":"                    kafka_consumer \u003d consumer.SimpleConsumer(kafka_conn, consumer_group, topic)"},{"line_number":70,"context_line":"                    partitions \u003d kafka_consumer.offsets.keys()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_11cb1c20","line":67,"in_reply_to":"9a1a9d01_897ab222","updated":"2015-10-01 13:57:17.000000000","message":"That was actually on purpose. Given how Kafka works, it makes no sense to specify a set of partitions to watch. The partitions will be distributed among the consumers and there is no guarantee of that this system is consuming any given set of partitions.\n\nWhat probably needs to be done is completely remove the configuration of partitions so it is obvious that it is not being used. And add comments in the review to explain.","commit_id":"35fcf2dd91b04de18fcea919e01d9c6dd3acefed"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"92c18c4ca08a49573badcc2a3f9c75fd92f41ee9","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            for group, topics in raw_val.iteritems():"},{"line_number":46,"context_line":"                assert isinstance(group, (str, unicode))"},{"line_number":47,"context_line":"                if isinstance(topics, dict):"},{"line_number":48,"context_line":"                    self.log.info(\"Found old config format, discarding partition lists\")"},{"line_number":49,"context_line":"                    topics \u003d topics.keys()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_1c1ea7ba","line":46,"updated":"2015-10-14 09:10:16.000000000","message":"NB, this could also be;\n  assert isinstance(group, basestring)","commit_id":"b272d61116f1b51e12cd6982c3ed12722ae2491f"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"454abf9d9666b740be121d28d8dd8d55e34595ce","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            for group, topics in raw_val.iteritems():"},{"line_number":46,"context_line":"                assert isinstance(group, (str, unicode))"},{"line_number":47,"context_line":"                if isinstance(topics, dict):"},{"line_number":48,"context_line":"                    self.log.info(\"Found old config format, discarding partition lists\")"},{"line_number":49,"context_line":"                    topics \u003d topics.keys()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_b1ccfe6a","line":46,"in_reply_to":"5a2ca52d_1c1ea7ba","updated":"2015-10-16 15:13:13.000000000","message":"True, I\u0027ll add that in the next patch set","commit_id":"b272d61116f1b51e12cd6982c3ed12722ae2491f"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"4cf09342f149cb8c2c9902bf36d44c5d0f818932","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - mytopic0"},{"line_number":60,"context_line":"  myconsumer1:"},{"line_number":61,"context_line":"    - mytopic0"},{"line_number":62,"context_line":"    - mytopic1"},{"line_number":63,"context_line":"    \u0027\u0027\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_kafka_offsets(self, kafka_conn, consumer_groups):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_8b5be6f5","line":62,"updated":"2015-10-16 03:30:47.000000000","message":"Do you really want to supply a multi-line exception msg for this type of failure? I like the detailed information, but this is going to turn into multiple lines in the log.\n\nI guess I prefer just having a single line exception msg. Then moving this block to the description of the function.\n\n_parse_consumer_groups, might be a better name for this function too. \n\nPrivate config validation/marshalling function, just seems a bit generic of a description, so if the Exception msg is used to describe the function that would probably be clearer.\n\nAlso, seem Ben\u0027s comments on using \"basestring\" insted of (str, unicode).","commit_id":"b272d61116f1b51e12cd6982c3ed12722ae2491f"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"454abf9d9666b740be121d28d8dd8d55e34595ce","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - mytopic0"},{"line_number":60,"context_line":"  myconsumer1:"},{"line_number":61,"context_line":"    - mytopic0"},{"line_number":62,"context_line":"    - mytopic1"},{"line_number":63,"context_line":"    \u0027\u0027\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_kafka_offsets(self, kafka_conn, consumer_groups):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_71ef46e9","line":62,"in_reply_to":"5a2ca52d_8b5be6f5","updated":"2015-10-16 15:13:13.000000000","message":"Sounds good.","commit_id":"b272d61116f1b51e12cd6982c3ed12722ae2491f"}]}
