)]}'
{"docs/Plugins.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dc5dc0fbd2eb34a2eca463c8778bb4e4499dff95","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"```"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"## PostgreSQL Checks"},{"line_number":1156,"context_line":"This section describes the PostgreSQL checks that can be performed by the Agent. "},{"line_number":1157,"context_line":"The PostgreSQL checks requires a configuration file called postgres.yaml to be available in the agent conf.d configuration directory."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"Sample config:"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_185ea576","line":1156,"updated":"2015-10-06 20:44:57.000000000","message":"You have a trailing space on this line","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":17333,"name":"Sayako Kondo","email":"kondoh.sayako@jp.fujitsu.com","username":"sayako"},"change_message_id":"979e0a5090ce3039f53ac8de9d602bb041ca447e","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"```"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"## PostgreSQL Checks"},{"line_number":1156,"context_line":"This section describes the PostgreSQL checks that can be performed by the Agent. "},{"line_number":1157,"context_line":"The PostgreSQL checks requires a configuration file called postgres.yaml to be available in the agent conf.d configuration directory."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"Sample config:"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_af9f1b02","line":1156,"in_reply_to":"7a2fa921_185ea576","updated":"2015-10-07 12:26:17.000000000","message":"Thank you. I fix.","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dc5dc0fbd2eb34a2eca463c8778bb4e4499dff95","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1183,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1184,"context_line":"| postgresql.connections | hostname, db, service | Corresponding to \"numbackends\" of \"pg_stat_database\". |"},{"line_number":1185,"context_line":"| postgresql.commits | hostname, db, service | Corresponding to \"xact_commit\" of \"pg_stat_database\". |"},{"line_number":1186,"context_line":"| postgresql.rollbacks | hostname, db, service | Corresponding to \"xact_rollback\" of \"pg_stat_database\". |"},{"line_number":1187,"context_line":"| postgresql.disk_read | hostname, db, service | Corresponding to \"blks_read\" of \"pg_stat_database\". |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_789479e1","line":1184,"updated":"2015-10-06 20:44:57.000000000","message":"Would be good to document the value of service that is output by this plugin","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":17333,"name":"Sayako Kondo","email":"kondoh.sayako@jp.fujitsu.com","username":"sayako"},"change_message_id":"979e0a5090ce3039f53ac8de9d602bb041ca447e","unresolved":false,"context_lines":[{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1183,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1184,"context_line":"| postgresql.connections | hostname, db, service | Corresponding to \"numbackends\" of \"pg_stat_database\". |"},{"line_number":1185,"context_line":"| postgresql.commits | hostname, db, service | Corresponding to \"xact_commit\" of \"pg_stat_database\". |"},{"line_number":1186,"context_line":"| postgresql.rollbacks | hostname, db, service | Corresponding to \"xact_rollback\" of \"pg_stat_database\". |"},{"line_number":1187,"context_line":"| postgresql.disk_read | hostname, db, service | Corresponding to \"blks_read\" of \"pg_stat_database\". |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_efee738a","line":1184,"in_reply_to":"7a2fa921_789479e1","updated":"2015-10-07 12:26:17.000000000","message":"I think that the value of service isn\u0027t necessary, because it isn\u0027t fixed value. As far as I checked, PostgreSQL checks doesn\u0027t set \"service\" dimension in postgres.py(PostgreSQL Plugin).","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dc5dc0fbd2eb34a2eca463c8778bb4e4499dff95","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"| postgresql.temp_bytes | hostname, db, service | Corresponding to \"temp_bytes\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1193,"context_line":"| postgresql.temp_files | hostname, db, service | Corresponding to \"temp_files\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1194,"context_line":"| postgresql.seq_scans | hostname, db, service, table | Corresponding to \"seq_scan\" of \"pg_stat_user_tables\" |"},{"line_number":1195,"context_line":"| postgresql.seq_rows_read | hostname, db, service, table |Corresponding to \"seq_tup_read\" of \"pg_stat_user_tables\" |"},{"line_number":1196,"context_line":"| postgresql.index_scans | hostname, db, service, table, index |Corresponding to \"idx_scan\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1197,"context_line":"| postgresql.index_rows_fetched | hostname, db, service, table, index | Corresponding to \"idx_tup_fetch\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1198,"context_line":"| postgresql.rows_inserted | hostname, db, service, table | Corresponding to \"n_tup_ins\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_7821d9fa","line":1195,"updated":"2015-10-06 20:44:57.000000000","message":"You are missing a space before Corresponding","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":17333,"name":"Sayako Kondo","email":"kondoh.sayako@jp.fujitsu.com","username":"sayako"},"change_message_id":"979e0a5090ce3039f53ac8de9d602bb041ca447e","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"| postgresql.temp_bytes | hostname, db, service | Corresponding to \"temp_bytes\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1193,"context_line":"| postgresql.temp_files | hostname, db, service | Corresponding to \"temp_files\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1194,"context_line":"| postgresql.seq_scans | hostname, db, service, table | Corresponding to \"seq_scan\" of \"pg_stat_user_tables\" |"},{"line_number":1195,"context_line":"| postgresql.seq_rows_read | hostname, db, service, table |Corresponding to \"seq_tup_read\" of \"pg_stat_user_tables\" |"},{"line_number":1196,"context_line":"| postgresql.index_scans | hostname, db, service, table, index |Corresponding to \"idx_scan\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1197,"context_line":"| postgresql.index_rows_fetched | hostname, db, service, table, index | Corresponding to \"idx_tup_fetch\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1198,"context_line":"| postgresql.rows_inserted | hostname, db, service, table | Corresponding to \"n_tup_ins\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_cfa2974b","line":1195,"in_reply_to":"7a2fa921_7821d9fa","updated":"2015-10-07 12:26:17.000000000","message":"Thank you. I fix.","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dc5dc0fbd2eb34a2eca463c8778bb4e4499dff95","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"| postgresql.temp_files | hostname, db, service | Corresponding to \"temp_files\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1194,"context_line":"| postgresql.seq_scans | hostname, db, service, table | Corresponding to \"seq_scan\" of \"pg_stat_user_tables\" |"},{"line_number":1195,"context_line":"| postgresql.seq_rows_read | hostname, db, service, table |Corresponding to \"seq_tup_read\" of \"pg_stat_user_tables\" |"},{"line_number":1196,"context_line":"| postgresql.index_scans | hostname, db, service, table, index |Corresponding to \"idx_scan\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1197,"context_line":"| postgresql.index_rows_fetched | hostname, db, service, table, index | Corresponding to \"idx_tup_fetch\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1198,"context_line":"| postgresql.rows_inserted | hostname, db, service, table | Corresponding to \"n_tup_ins\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"},{"line_number":1199,"context_line":"| postgresql.rows_updated | hostname, db, service, table | Corresponding to \"n_tup_upd\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_d8d7cdbd","line":1196,"updated":"2015-10-06 20:44:57.000000000","message":"You are missing a space before Corresponding","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":17333,"name":"Sayako Kondo","email":"kondoh.sayako@jp.fujitsu.com","username":"sayako"},"change_message_id":"979e0a5090ce3039f53ac8de9d602bb041ca447e","unresolved":false,"context_lines":[{"line_number":1193,"context_line":"| postgresql.temp_files | hostname, db, service | Corresponding to \"temp_files\" of \"pg_stat_database\". This is supported only in PostgreSQL 9.2 or later. |"},{"line_number":1194,"context_line":"| postgresql.seq_scans | hostname, db, service, table | Corresponding to \"seq_scan\" of \"pg_stat_user_tables\" |"},{"line_number":1195,"context_line":"| postgresql.seq_rows_read | hostname, db, service, table |Corresponding to \"seq_tup_read\" of \"pg_stat_user_tables\" |"},{"line_number":1196,"context_line":"| postgresql.index_scans | hostname, db, service, table, index |Corresponding to \"idx_scan\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1197,"context_line":"| postgresql.index_rows_fetched | hostname, db, service, table, index | Corresponding to \"idx_tup_fetch\" of \"pg_stat_user_tables\" or \"pg_stat_user_indexes\" |"},{"line_number":1198,"context_line":"| postgresql.rows_inserted | hostname, db, service, table | Corresponding to \"n_tup_ins\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"},{"line_number":1199,"context_line":"| postgresql.rows_updated | hostname, db, service, table | Corresponding to \"n_tup_upd\" of \"pg_stat_user_tables\" or \"pg_stat_database\" |"}],"source_content_type":"text/x-markdown","patch_set":2,"id":"7a2fa921_2f946be0","line":1196,"in_reply_to":"7a2fa921_d8d7cdbd","updated":"2015-10-07 12:26:17.000000000","message":"Thank you. I fix.","commit_id":"27137d96ac2f258f485700cd0b057a29ec7b6b66"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"511e58002011e15d593423be65bbbd7f89a3a540","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1235,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1236,"context_line":"| postgresql.connections | hostname, db, service | Corresponding to \"numbackends\" of \"pg_stat_database\". |"},{"line_number":1237,"context_line":"| postgresql.commits | hostname, db, service | Corresponding to \"xact_commit\" of \"pg_stat_database\". |"},{"line_number":1238,"context_line":"| postgresql.rollbacks | hostname, db, service | Corresponding to \"xact_rollback\" of \"pg_stat_database\". |"},{"line_number":1239,"context_line":"| postgresql.disk_read | hostname, db, service | Corresponding to \"blks_read\" of \"pg_stat_database\". |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"5a2ca52d_81ebc777","line":1236,"updated":"2015-10-16 06:03:21.000000000","message":"See comment that Brad Klein left in the review for the rabbitmq checks regarding the language at, https://review.openstack.org/#/c/227717/.\n\nAlso, I think that service\u003dpostgres, should be the default in this case as Craig mentioned in an earlier comment. This is the convention that I believe that we\u0027ve set in other plugins. For example, the mysql and rabbitmq plugins set service\u003dmyslq and servie\u003drabbitmq respectively.","commit_id":"dd74d9392351045dc49da524a376568ddf439e1c"},{"author":{"_account_id":17333,"name":"Sayako Kondo","email":"kondoh.sayako@jp.fujitsu.com","username":"sayako"},"change_message_id":"8a60d64c7a246095e0a784e2a4df96675e836856","unresolved":false,"context_lines":[{"line_number":1233,"context_line":""},{"line_number":1234,"context_line":"| Metric Name | Dimensions | Semantics |"},{"line_number":1235,"context_line":"| ----------- | ---------- | --------- |"},{"line_number":1236,"context_line":"| postgresql.connections | hostname, db, service | Corresponding to \"numbackends\" of \"pg_stat_database\". |"},{"line_number":1237,"context_line":"| postgresql.commits | hostname, db, service | Corresponding to \"xact_commit\" of \"pg_stat_database\". |"},{"line_number":1238,"context_line":"| postgresql.rollbacks | hostname, db, service | Corresponding to \"xact_rollback\" of \"pg_stat_database\". |"},{"line_number":1239,"context_line":"| postgresql.disk_read | hostname, db, service | Corresponding to \"blks_read\" of \"pg_stat_database\". |"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"3a29b11f_7b0021ab","line":1236,"in_reply_to":"5a2ca52d_81ebc777","updated":"2015-10-19 05:27:59.000000000","message":"Thank you for your comments. I\u0027m going to fix the expression of \"Semantics\" like the Brad Klein\u0027s comment.\n\nAnd I\u0027m going to add the value of service.\nHowever now the value of service for PostgreSQL isn\u0027t fixed, I will additionally fix the below file.\n  monasca_agent/collector/checks_d/postgres.py","commit_id":"dd74d9392351045dc49da524a376568ddf439e1c"}]}