)]}'
{"monasca_setup/detection/plugins/apache.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b5bdd0cf87ddf2ca865028130c7ecf284ba7b0df","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # or relying on a configured /root/.apache.cnf"},{"line_number":72,"context_line":"        if self.dependencies_installed():"},{"line_number":73,"context_line":"            # If any of the exact keys are present, use them."},{"line_number":74,"context_line":"            if self.args and self.args.viewkeys() \u0026 set([\"url\", \"user\", \"password\"]):"},{"line_number":75,"context_line":"                log.info(\"Attempting to use credentials from command args\")"},{"line_number":76,"context_line":"                apache_url \u003d self.args.get(\"url\", None)"},{"line_number":77,"context_line":"                apache_user \u003d self.args.get(\"user\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_1b01d1ae","line":74,"updated":"2015-10-14 07:37:41.000000000","message":"Seems like a constant. Could you pull it up with meaningful name like \nEXPECTED_CONFIGURATION_KEYS ? That way it\u0027d take less time to understand it, even though you\u0027ve added a tip to make it understandable.","commit_id":"980da5bca2fc06c9b4eab47d489b450b0f059d02"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"5cdbaf6cfd5d2dccbddeef6546bf08da6a1768c1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        # or relying on a configured /root/.apache.cnf"},{"line_number":72,"context_line":"        if self.dependencies_installed():"},{"line_number":73,"context_line":"            # If any of the exact keys are present, use them."},{"line_number":74,"context_line":"            if self.args and self.args.viewkeys() \u0026 set([\"url\", \"user\", \"password\"]):"},{"line_number":75,"context_line":"                log.info(\"Attempting to use credentials from command args\")"},{"line_number":76,"context_line":"                apache_url \u003d self.args.get(\"url\", None)"},{"line_number":77,"context_line":"                apache_user \u003d self.args.get(\"user\", None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_0a895426","line":74,"in_reply_to":"5a2ca52d_1b01d1ae","updated":"2015-10-14 22:24:50.000000000","message":"Done","commit_id":"980da5bca2fc06c9b4eab47d489b450b0f059d02"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1d2ad357b026e009af68fd219759befd757976e5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            self.available \u003d True"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _read_apache_config(self, config_location):"},{"line_number":37,"context_line":"        log.info(\"\\tAttempting to use client credentials from {:s}\".format(config_location))"},{"line_number":38,"context_line":"        # Read the apache config file to extract the needed variables."},{"line_number":39,"context_line":"        client_section \u003d False"},{"line_number":40,"context_line":"        apache_url \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_498b9568","line":37,"updated":"2015-10-16 06:22:03.000000000","message":"Is this log.into statement really adding any value and/or helpful? Just seems like it could be extra noise in the log files.","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"1b515d6d4fea11a951d603643e6bd03760cf136c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            self.available \u003d True"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _read_apache_config(self, config_location):"},{"line_number":37,"context_line":"        log.info(\"\\tAttempting to use client credentials from {:s}\".format(config_location))"},{"line_number":38,"context_line":"        # Read the apache config file to extract the needed variables."},{"line_number":39,"context_line":"        client_section \u003d False"},{"line_number":40,"context_line":"        apache_url \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_eb57e357","line":37,"in_reply_to":"5a2ca52d_498b9568","updated":"2015-10-16 14:33:45.000000000","message":"Leftover from the original code, would it be better at debug level? Or would you rather remove it entirely?","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1d2ad357b026e009af68fd219759befd757976e5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        apache_user \u003d None"},{"line_number":42,"context_line":"        apache_pass \u003d None"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            with open(config_location, \"r\") as confFile:"},{"line_number":45,"context_line":"                for row in confFile:"},{"line_number":46,"context_line":"                    if \"[client]\" in row:"},{"line_number":47,"context_line":"                        client_section \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_29e5f936","line":44,"updated":"2015-10-16 06:22:03.000000000","message":"confFile isn\u0027t snake case. Probably needs to be config_file.","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"1b515d6d4fea11a951d603643e6bd03760cf136c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        apache_user \u003d None"},{"line_number":42,"context_line":"        apache_pass \u003d None"},{"line_number":43,"context_line":"        try:"},{"line_number":44,"context_line":"            with open(config_location, \"r\") as confFile:"},{"line_number":45,"context_line":"                for row in confFile:"},{"line_number":46,"context_line":"                    if \"[client]\" in row:"},{"line_number":47,"context_line":"                        client_section \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_ab048b49","line":44,"in_reply_to":"5a2ca52d_29e5f936","updated":"2015-10-16 14:33:45.000000000","message":"Leftover from the original code, I will change it","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1d2ad357b026e009af68fd219759befd757976e5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                for row in confFile:"},{"line_number":46,"context_line":"                    if \"[client]\" in row:"},{"line_number":47,"context_line":"                        client_section \u003d True"},{"line_number":48,"context_line":"                        pass"},{"line_number":49,"context_line":"                    if client_section:"},{"line_number":50,"context_line":"                        if \"url\u003d\" in row:"},{"line_number":51,"context_line":"                            apache_url \u003d row.split(\"\u003d\")[1].strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_c9cc85bd","line":48,"updated":"2015-10-16 06:22:03.000000000","message":"Why the pass? Should this be continue?","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"1b515d6d4fea11a951d603643e6bd03760cf136c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                for row in confFile:"},{"line_number":46,"context_line":"                    if \"[client]\" in row:"},{"line_number":47,"context_line":"                        client_section \u003d True"},{"line_number":48,"context_line":"                        pass"},{"line_number":49,"context_line":"                    if client_section:"},{"line_number":50,"context_line":"                        if \"url\u003d\" in row:"},{"line_number":51,"context_line":"                            apache_url \u003d row.split(\"\u003d\")[1].strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_e61dda62","line":48,"in_reply_to":"5a2ca52d_c9cc85bd","updated":"2015-10-16 14:33:45.000000000","message":"Yes, it probably should. I will change it","commit_id":"e5352309ba2a5c1ed58e600ff8022c4925beecc7"}]}