)]}'
{"monasca_agent/collector/checks_d/process.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"a894aeb2a7c53b389ef1a6151db702225f4060aa","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                        if string in \u0027 \u0027.join(cmdline):"},{"line_number":60,"context_line":"                            found \u003d True"},{"line_number":61,"context_line":"                    except psutil.NoSuchProcess:"},{"line_number":62,"context_line":"                        pass"},{"line_number":63,"context_line":"                    except psutil.AccessDenied as e:"},{"line_number":64,"context_line":"                        self.log.error(\u0027Access denied to %s process\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_29d5e71a","line":61,"updated":"2015-10-21 19:55:24.000000000","message":"Usually exceptions where there\u0027s no logging are a really bad sign.  We should have a comment here explaining why we\u0027re ignoring the error in this case.","commit_id":"a32e471ed22b1849d07ac0cf8ef0167239f93e5e"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"73f92744c31cdde47b582502ac3228aa2b186808","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        if string in \u0027 \u0027.join(cmdline):"},{"line_number":65,"context_line":"                            found \u003d True"},{"line_number":66,"context_line":"                    except psutil.NoSuchProcess:"},{"line_number":67,"context_line":"                        # No way to log useful information here so just move on"},{"line_number":68,"context_line":"                        pass"},{"line_number":69,"context_line":"                    except psutil.AccessDenied as e:"},{"line_number":70,"context_line":"                        self.log.error(\u0027Access denied to %s process\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_a174ab67","line":67,"updated":"2015-10-21 21:29:14.000000000","message":"I don\u0027t see how this case is different from the one with exact_match. I would argue they are both the same and this is the correct behavior so change the one above. There is nothing useful to do since we have no idea of what process it was that exited between the process list and getting the details of the process. And it is absolutely fine that a process exited since they do it all of the time. Even if it was the process we were looking for, it dying then and 1 second before is the same.","commit_id":"a6f16bd7c891f36b948cbe0cf9c141b446b5b75e"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4e553cbdbfffec68e7ac16015c647f19e9cd9ee8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                        if string in \u0027 \u0027.join(cmdline):"},{"line_number":65,"context_line":"                            found \u003d True"},{"line_number":66,"context_line":"                    except psutil.NoSuchProcess:"},{"line_number":67,"context_line":"                        # No way to log useful information here so just move on"},{"line_number":68,"context_line":"                        pass"},{"line_number":69,"context_line":"                    except psutil.AccessDenied as e:"},{"line_number":70,"context_line":"                        self.log.error(\u0027Access denied to %s process\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_a16fcb29","line":67,"in_reply_to":"3a29b11f_a174ab67","updated":"2015-10-21 21:41:27.000000000","message":"I agree. The thought was we might be able to report something if we knew we cared about the process that died, but that seems like a marginal case to support.","commit_id":"a6f16bd7c891f36b948cbe0cf9c141b446b5b75e"}]}