)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bff3ccfa33906e764ef94895e7f645377e8d9815","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"Inherit Agent class and gather libvirt metrics\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":36,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances\u003d[{}])"},{"line_number":37,"context_line":"        self.instance_cache_file \u003d \"{0}/{1}\".format(self.init_config.get(\u0027cache_dir\u0027),"},{"line_number":38,"context_line":"                                                    \u0027libvirt_instances.yaml\u0027)"},{"line_number":39,"context_line":"        self.metric_cache_file \u003d \"{0}/{1}\".format(self.init_config.get(\u0027cache_dir\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_9ff260d1","line":36,"updated":"2015-10-30 20:22:11.000000000","message":"Why are you defaulting instances to [{}]? AgentCheck defaults it to [] if instances is None","commit_id":"24d170fbb5d43fb8efa8459c0c19584f3cde4b04"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"cf0f789a43ec795002153d9fce16e69e4685117b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"Inherit Agent class and gather libvirt metrics\"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def __init__(self, name, init_config, agent_config, instances\u003dNone):"},{"line_number":36,"context_line":"        AgentCheck.__init__(self, name, init_config, agent_config, instances\u003d[{}])"},{"line_number":37,"context_line":"        self.instance_cache_file \u003d \"{0}/{1}\".format(self.init_config.get(\u0027cache_dir\u0027),"},{"line_number":38,"context_line":"                                                    \u0027libvirt_instances.yaml\u0027)"},{"line_number":39,"context_line":"        self.metric_cache_file \u003d \"{0}/{1}\".format(self.init_config.get(\u0027cache_dir\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_43d2b65d","line":36,"in_reply_to":"1a26ad4f_9ff260d1","updated":"2015-10-30 21:41:03.000000000","message":"True, but AgentCheck.run() won\u0027t enumerate an empty list, so if \u0027instances\u0027 is [], the actual check will not be performed.","commit_id":"24d170fbb5d43fb8efa8459c0c19584f3cde4b04"}]}