)]}'
{"monasca_agent/collector/checks_d/libvirt.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"597d3c4cd49d28bf229af78263b3cedf4a2847af","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        inst_name \u003d inst.name()"},{"line_number":309,"context_line":"        dom_status \u003d inst.state()[0] - 1"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        detail \u003d DOM_STATES[inst.state()[0]]"},{"line_number":312,"context_line":"        # A nova-suspended VM has a SHUTOFF Power State, but alternate Status"},{"line_number":313,"context_line":"        if inst.state() \u003d\u003d [libvirt.VIR_DOMAIN_SHUTOFF, 5]:"},{"line_number":314,"context_line":"            detail \u003d \u0027VM has been suspended\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_bfc07c2b","line":311,"updated":"2015-10-30 20:37:54.000000000","message":"I think it would be better if no detail was set for libvirt.VIR_DOMAIN_RUNNING. That should be the normal case and it would save space in the database.","commit_id":"d27e219fdb96d523fc0fcd0e36444e6c4dcac2f5"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"3612c9dd6a61ceb0272174da2cb785e7448aff0d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        inst_name \u003d inst.name()"},{"line_number":309,"context_line":"        dom_status \u003d inst.state()[0] - 1"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        detail \u003d DOM_STATES[inst.state()[0]]"},{"line_number":312,"context_line":"        # A nova-suspended VM has a SHUTOFF Power State, but alternate Status"},{"line_number":313,"context_line":"        if inst.state() \u003d\u003d [libvirt.VIR_DOMAIN_SHUTOFF, 5]:"},{"line_number":314,"context_line":"            detail \u003d \u0027VM has been suspended\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_df0d383f","line":311,"in_reply_to":"1a26ad4f_bfc07c2b","updated":"2015-10-30 21:17:17.000000000","message":"Done","commit_id":"d27e219fdb96d523fc0fcd0e36444e6c4dcac2f5"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"597d3c4cd49d28bf229af78263b3cedf4a2847af","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                                              stdout\u003dfnull,"},{"line_number":431,"context_line":"                                              stderr\u003dfnull)"},{"line_number":432,"context_line":"                        if res \u003e 0:"},{"line_number":433,"context_line":"                            detail \u003d \u0027Instance failed ping check\u0027"},{"line_number":434,"context_line":"                        self.gauge(\u0027ping_status\u0027, res, dimensions\u003ddims_customer,"},{"line_number":435,"context_line":"                                   delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"},{"line_number":436,"context_line":"                                   hostname\u003dinstance_cache.get(inst_name)[\u0027hostname\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_5f05a877","line":433,"updated":"2015-10-30 20:37:54.000000000","message":"I realize this used to be there, but this detail doesn\u0027t add any useful information. It is always the same thing if the check fails. If it has info about why the check failed such as network down, hostname resolution failed, etc. then that would be useful. This detail is just taking up space in the database.","commit_id":"d27e219fdb96d523fc0fcd0e36444e6c4dcac2f5"},{"author":{"_account_id":12443,"name":"David Schroeder","email":"openstack@a7n.net","username":"dschroeder"},"change_message_id":"3612c9dd6a61ceb0272174da2cb785e7448aff0d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                                              stdout\u003dfnull,"},{"line_number":431,"context_line":"                                              stderr\u003dfnull)"},{"line_number":432,"context_line":"                        if res \u003e 0:"},{"line_number":433,"context_line":"                            detail \u003d \u0027Instance failed ping check\u0027"},{"line_number":434,"context_line":"                        self.gauge(\u0027ping_status\u0027, res, dimensions\u003ddims_customer,"},{"line_number":435,"context_line":"                                   delegated_tenant\u003dinstance_cache.get(inst_name)[\u0027tenant_id\u0027],"},{"line_number":436,"context_line":"                                   hostname\u003dinstance_cache.get(inst_name)[\u0027hostname\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_ff08342f","line":433,"in_reply_to":"1a26ad4f_5f05a877","updated":"2015-10-30 21:17:17.000000000","message":"Done","commit_id":"d27e219fdb96d523fc0fcd0e36444e6c4dcac2f5"}]}