)]}'
{"agent.yaml.template":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9e47927e3f077f112355670624dc5ed1403bf3c6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  # time to wait between collection runs"},{"line_number":73,"context_line":"  check_freq: {args.check_frequency}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  # threshold value for collection time of each check"},{"line_number":76,"context_line":"  sub_collection_warn: {args.sub_collection_warn}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  # Change port the Agent is listening to"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_7b9762ec","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":53},"updated":"2016-01-14 02:05:56.000000000","message":"Your help text of \"Threshold value for warning on collection time of each check (in second)\" would make a better comment here","commit_id":"b85270a899d8ce3e656424aaf3019a06a7ac26f0"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"d4767ae5915ffbf7abaf683f16e59ee1fbd8c8fe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  # time to wait between collection runs"},{"line_number":73,"context_line":"  check_freq: {args.check_frequency}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  # threshold value for collection time of each check"},{"line_number":76,"context_line":"  sub_collection_warn: {args.sub_collection_warn}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  # Change port the Agent is listening to"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"da6ed579_8cf0b592","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":53},"in_reply_to":"da6ed579_7b9762ec","updated":"2016-01-14 15:57:09.000000000","message":"Will change it! Thanks Craig!","commit_id":"b85270a899d8ce3e656424aaf3019a06a7ac26f0"}],"monasca_agent/collector/checks/collector.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"125f65a29d83a789b959472d209bcc6fac40c9a1","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            sub_collect_duration_mills \u003d sub_collect_duration * 1000"},{"line_number":201,"context_line":"            log.info(\"Finished run check %s. Collection time: %sms.\" % ("},{"line_number":202,"context_line":"                check.name, round(sub_collect_duration_mills, 2)))"},{"line_number":203,"context_line":"            if sub_collect_duration \u003e SUB_COLLECTION_TIME:"},{"line_number":204,"context_line":"                log.warn(\"Collection time for check %s is high: %ss.\" % ("},{"line_number":205,"context_line":"                    check.name, round(sub_collect_duration, 2)))"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8e9554e5","line":203,"updated":"2016-01-08 16:07:47.000000000","message":"Let\u0027s make this configurable via the agent config file","commit_id":"fa531fca8e9621261662f0cffbf0481bb0800b12"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"0e20cba4958bf24305ac2ac611237fe9052046e7","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            sub_collect_duration \u003d sub_timer.step()"},{"line_number":199,"context_line":"            sub_collect_duration_mills \u003d sub_collect_duration * 1000"},{"line_number":200,"context_line":"            log.info(\"Finished run check %s. Collection time: %.2fms.\" % ("},{"line_number":201,"context_line":"                check.name, round(sub_collect_duration_mills, 2)))"},{"line_number":202,"context_line":"            if sub_collect_duration \u003e util.get_sub_collection_time():"},{"line_number":203,"context_line":"                log.warn(\"Collection time for check %s is high: %.2fs.\" % ("},{"line_number":204,"context_line":"                    check.name, round(sub_collect_duration, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_c9b1f290","line":201,"range":{"start_line":201,"start_character":16,"end_line":201,"end_character":21},"updated":"2016-01-13 21:00:43.000000000","message":"This logging statement is getting executed for each sub-collection run. Normally, I get a little concerned about filling up log files with messages that for the most part are never looked at or reviewed.","commit_id":"e5aea68ef57f9fa2017694af49f79f2508f46838"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ef61c210bb17453c1b3a192650994f3f89a32bcf","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            sub_collect_duration \u003d sub_timer.step()"},{"line_number":199,"context_line":"            sub_collect_duration_mills \u003d sub_collect_duration * 1000"},{"line_number":200,"context_line":"            log.info(\"Finished run check %s. Collection time: %.2fms.\" % ("},{"line_number":201,"context_line":"                check.name, round(sub_collect_duration_mills, 2)))"},{"line_number":202,"context_line":"            if sub_collect_duration \u003e util.get_sub_collection_time():"},{"line_number":203,"context_line":"                log.warn(\"Collection time for check %s is high: %.2fs.\" % ("},{"line_number":204,"context_line":"                    check.name, round(sub_collect_duration, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_dcd3f102","line":201,"range":{"start_line":201,"start_character":16,"end_line":201,"end_character":21},"in_reply_to":"da6ed579_c9b1f290","updated":"2016-01-13 21:28:56.000000000","message":"Thanks Roland! DEBUG level is probably better here.","commit_id":"e5aea68ef57f9fa2017694af49f79f2508f46838"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"228f8063f5ac1831248f31cd9e5aef161963b1bf","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        for check in self.initialized_checks_d:"},{"line_number":167,"context_line":"            if not self.continue_running:"},{"line_number":168,"context_line":"                return"},{"line_number":169,"context_line":"            log.info(\"Running check %s\" % check.name)"},{"line_number":170,"context_line":"            instance_statuses \u003d []"},{"line_number":171,"context_line":"            metric_count \u003d 0"},{"line_number":172,"context_line":"            event_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_45587d8a","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":20},"updated":"2016-01-14 01:04:17.000000000","message":"Should this also be DEBUG?  Also, there\u0027s another statement at INFO somewhere that prints out every 10 collections.  Should that also be debug?","commit_id":"b85270a899d8ce3e656424aaf3019a06a7ac26f0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9e47927e3f077f112355670624dc5ed1403bf3c6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        for check in self.initialized_checks_d:"},{"line_number":167,"context_line":"            if not self.continue_running:"},{"line_number":168,"context_line":"                return"},{"line_number":169,"context_line":"            log.info(\"Running check %s\" % check.name)"},{"line_number":170,"context_line":"            instance_statuses \u003d []"},{"line_number":171,"context_line":"            metric_count \u003d 0"},{"line_number":172,"context_line":"            event_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_fbdd92e0","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":20},"in_reply_to":"da6ed579_45587d8a","updated":"2016-01-14 02:05:56.000000000","message":"This one definitely should be debug","commit_id":"b85270a899d8ce3e656424aaf3019a06a7ac26f0"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"d4767ae5915ffbf7abaf683f16e59ee1fbd8c8fe","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        for check in self.initialized_checks_d:"},{"line_number":167,"context_line":"            if not self.continue_running:"},{"line_number":168,"context_line":"                return"},{"line_number":169,"context_line":"            log.info(\"Running check %s\" % check.name)"},{"line_number":170,"context_line":"            instance_statuses \u003d []"},{"line_number":171,"context_line":"            metric_count \u003d 0"},{"line_number":172,"context_line":"            event_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_0cfcc570","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":20},"in_reply_to":"da6ed579_45587d8a","updated":"2016-01-14 15:57:09.000000000","message":"Yes agreed! I changed the other INFO to DEBUG but forgot this one... Thanks!","commit_id":"b85270a899d8ce3e656424aaf3019a06a7ac26f0"}],"monasca_agent/common/config.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"0e20cba4958bf24305ac2ac611237fe9052046e7","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                 \u0027skip_ssl_validation\u0027: False,"},{"line_number":49,"context_line":"                                 \u0027autorestart\u0027: False,"},{"line_number":50,"context_line":"                                 \u0027non_local_traffic\u0027: False,"},{"line_number":51,"context_line":"                                 \u0027sub_collection_time\u0027: 5},"},{"line_number":52,"context_line":"                        \u0027Api\u0027: {\u0027is_enabled\u0027: False,"},{"line_number":53,"context_line":"                                \u0027url\u0027: \u0027\u0027,"},{"line_number":54,"context_line":"                                \u0027project_name\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_2948ce86","line":51,"range":{"start_line":51,"start_character":34,"end_line":51,"end_character":53},"updated":"2016-01-13 21:00:43.000000000","message":"Maybe a more descriptive name would be sub_collection_warn, just to be more explicit that this is the threshold that is used for writing warning messages to the log file.","commit_id":"e5aea68ef57f9fa2017694af49f79f2508f46838"}]}